Skip to content

Add feature flags to flutter doctor -v - #171307

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
matanlurey:add-feature-flags-to-flutter-doctor
Jul 1, 2025
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
matanlurey:add-feature-flags-to-flutter-doctor

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

Towards #38901.

@matanlurey
matanlurey requested review from bkonyi and loic-sharma June 27, 2025 22:48
@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 27, 2025
@loic-sharma

Copy link
Copy Markdown
Member

Example output:

$ flutter doctor --verbose
[!] Flutter (Channel [user-branch], 3.33.0-1.0.pre.729, on macOS 15.5 24F74 darwin-arm64, locale en) [252ms]
    ...
    • Framework revision 9c3e4a7821 (3 hours ago), 2025-06-27 15:47:18 -0700
    • Engine revision 3bc69cb262
    • Dart version 3.9.0 (build 3.9.0-268.0.dev)
    • DevTools version 2.48.0-dev.0
    • Feature flags: enable-web, enable-linux-desktop, enable-macos-desktop, enable-windows-desktop, enable-android, enable-ios, cli-animations, enable-native-assets,
      enable-swift-package-manager
    ...

}
// Add feature flags that are either enabled, or disabled compared to the default setting.
final List<String> featureFlags = <String>[
..._featureFlags.allConfigurableFeatures

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider replacing splatting + list literal with a .toList() as that's shorter and less indented. I don't feel strongly about this, feel free to skip

///
/// [Feature.configSetting] is not `null`.
Iterable<Feature> get allConfigurableFeatures {
return allFeatures.where((Feature feature) => feature.configSetting != null);

@loic-sharma loic-sharma Jun 28, 2025 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include features that have a environmentOverride?

I don't know why someone would do this, but one could create a feature that has an environmentOverride but not a configSetting.

@loic-sharma loic-sharma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Jul 1, 2025
Merged via the queue into flutter:master with commit 4fbc812 Jul 1, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants