Skip to content

feat: add "stamp" to et and create build-time engine_stamp.json - #171310

Merged
jtmcdole merged 5 commits into
flutter:masterfrom
jtmcdole:stampBuilds
Jun 30, 2025
Merged

feat: add "stamp" to et and create build-time engine_stamp.json#171310
jtmcdole merged 5 commits into
flutter:masterfrom
jtmcdole:stampBuilds

Conversation

@jtmcdole

@jtmcdole jtmcdole commented Jun 28, 2025

Copy link
Copy Markdown
Member

Writes a stamp file, engine_stamp.json, containing interesting information about this build:

{
  "build_date": "2025-06-27T16:35:13.279188",
  "build_time_ms": 1751067313279,
  "git_revision": "e68e105667e9e5cace56b0431781062b773e4831",
  "git_revision_date": "2025-06-27 15:51:55 -0700",
  "content_hash": "23542e452fc55890626fd1c5eb77c4788c19f983"
}

Later; I'll update to the flutter tool to download this artifact to bin/cache so it can be used instead of git commands.

@jtmcdole
feat: add "stamp" to et
37b74c8 
Writes a stamp file, engine_stamp.json, containing interesting
information about this build:

```json
{
  "build_date": "2025-06-27T16:35:13.279188",
  "build_time_ms": 1751067313279,
  "git_revision": "e68e105667e9e5cace56b0431781062b773e4831",
  "git_revision_date": "2025-06-27 15:51:55 -0700",
  "content_hash": "23542e452fc55890626fd1c5eb77c4788c19f983"
}
```
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Jun 28, 2025
jtmcdole
jtmcdole commented Jun 28, 2025
View reviewed changes
Comment thread engine/src/flutter/tools/engine_tool/test/commands/stamp_command_test.dart
@jtmcdole

jtmcdole commented Jun 28, 2025

Copy link
Copy Markdown
Member Author

"That worked?!"

{
  "build_date": "2025-06-27T17:21:54.171573",
  "build_time_ms": 1751070114171,
  "git_revision": "37b74c8da150b22a4a66f4ce9bd3714a284211cf",
  "git_revision_date": "2025-06-27 15:51:55 -0700",
  "content_hash": "8d0c3fec9b907726f1cfb0298a5bf89bba84394e"
}

jason-simmons
jason-simmons reviewed Jun 28, 2025
View reviewed changes
Comment thread engine/src/flutter/tools/engine_tool/lib/src/commands/stamp_command.dart Outdated
Comment thread engine/src/flutter/tools/engine_tool/lib/src/commands/stamp_command.dart Outdated
Comment thread engine/src/flutter/tools/engine_tool/lib/src/commands/stamp_command.dart Outdated
Comment thread engine/src/flutter/tools/engine_tool/lib/src/commands/stamp_command.dart Outdated
jtmcdole added 2 commits June 28, 2025 07:34
@jtmcdole
Reviewer comments + license headers
94fcc71 
Backdating licenses to match other parts of the engine tool
@jtmcdole
test text
b2e5480
zanderso
zanderso approved these changes Jun 30, 2025
View reviewed changes

@zanderso zanderso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ suggestion to include logs from subprocesses when there's an error.

Comment thread engine/src/flutter/tools/engine_tool/lib/src/commands/stamp_command.dart Outdated
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2025
@jtmcdole jtmcdole changed the title feat: add "stamp" to et feat: add "stamp" to et and create build-time engine_stamp.json Jun 30, 2025
@jtmcdole jtmcdole mentioned this pull request Jun 30, 2025
Closed
zanderso
zanderso approved these changes Jun 30, 2025
View reviewed changes

@zanderso zanderso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@jtmcdole
jtmcdole added this pull request to the merge queue Jun 30, 2025
@jtmcdole jtmcdole mentioned this pull request Jun 30, 2025
Open
Merged via the queue into flutter:master with commit 123e969 Jun 30, 2025
@jtmcdole
jtmcdole deleted the stampBuilds branch June 30, 2025 18:30
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
3816105 
…on (flutter/flutter#171310)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
b95960c 
…on (flutter/flutter#171310)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
41ecfcd 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
8b1816e 
…on (flutter/flutter#171310)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
f18a353 
…on (flutter/flutter#171310)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
8f490be 
…on (flutter/flutter#171310)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
e6a1213 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
d1baeae 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
6ee4b1d 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
cfa2c37 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
bb42680 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
4cbdc4e 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
c5b6ebe 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
22178ea 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
0cbe1a6 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
775c98a 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
cf66814 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
b351fb4 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
c08a6ec 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
3a3df70 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
08d1973 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
03d8978 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
a255b03 
…on (flutter/flutter#171310)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@jtmcdole @mboetger
feat: add "stamp" to et and create build-time engine_stamp.json (flut…
23034fe 
…ter#171310)

Writes a stamp file, engine_stamp.json, containing interesting
information about this build:

```json
{
  "build_date": "2025-06-27T16:35:13.279188",
  "build_time_ms": 1751067313279,
  "git_revision": "e68e105667e9e5cace56b0431781062b773e4831",
  "git_revision_date": "2025-06-27 15:51:55 -0700",
  "content_hash": "23542e452fc55890626fd1c5eb77c4788c19f983"
}
```

Later; I'll update to the flutter tool to download this artifact to
bin/cache so it can be used instead of git commands.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
cffae04 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
1f23211 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
a997e83 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
3cc4262 
…on (flutter/flutter#171310)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
123e969 feat: add "stamp" to et and create build-time engine_stamp.js…
7668d35 
…on (flutter/flutter#171310)
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@jtmcdole @lucaantonelli
feat: add "stamp" to et and create build-time engine_stamp.json (flut…
4567a7f 
…ter#171310)

Writes a stamp file, engine_stamp.json, containing interesting
information about this build:

```json
{
  "build_date": "2025-06-27T16:35:13.279188",
  "build_time_ms": 1751067313279,
  "git_revision": "e68e105667e9e5cace56b0431781062b773e4831",
  "git_revision_date": "2025-06-27 15:51:55 -0700",
  "content_hash": "23542e452fc55890626fd1c5eb77c4788c19f983"
}
```

Later; I'll update to the flutter tool to download this artifact to
bin/cache so it can be used instead of git commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes
@jason-simmons jason-simmons jason-simmons approved these changes
@matanlurey matanlurey Awaiting requested review from matanlurey

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtmcdole @zanderso @jason-simmons