Skip to content

Add support for flutter_test_config.dart - #17141

Merged
tvolkert merged 12 commits into
flutter:masterfrom
tvolkert:test_config
May 1, 2018
Merged

tvolkert merged 12 commits into
flutter:masterfrom
tvolkert:test_config

Conversation

@tvolkert

@tvolkert tvolkert commented May 1, 2018

Copy link
Copy Markdown
Contributor

* Updated contract
* Added docs
* Added tests
/// such a configuration file, the file will be assumed to have a `main` method
/// with the following signature:
///
/// ```

@Hixie Hixie May 1, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

```dart

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

///
/// After the test framework finds a configuration file, it will stop scanning
/// the directory hierarchy. In other words, the test configuration file that
/// lives closest to the test file will "win", and all other test configuration

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "win", use "be the one selected". (Just thinking that the idea of selecting something as being a "win" might be an Americanism, and that if I were using Google Translate to read this, it might make more sense to just say what it means.)

@gspencergoog

Copy link
Copy Markdown
Contributor

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@tvolkert
tvolkert merged commit 28c1973 into flutter:master May 1, 2018
@tvolkert
tvolkert deleted the test_config branch May 1, 2018 19:36
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
This enables support for a `flutter_test_config.dart` configuration file,
which will be discovered and handed the responsibility of running the
test file (thus allowing it to run pre-test setup on a project level).

flutter#16859
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants