Repository navigation
Add Flutter-repo-specific golden comparator - #17205
Merged
Merged
Conversation
Contributor
Author
|
FYI, the tests are failing because this depends on flutter-team-archive/engine#5137, which had rolled into |
gspencergoog
approved these changes
May 2, 2018
Contributor
|
|
Hixie
reviewed
May 2, 2018
Contributor
There was a problem hiding this comment.
let's keep using "new" until we have a lint to tell us not to
Hixie
reviewed
May 2, 2018
Contributor
There was a problem hiding this comment.
what'll happen if you have local changes?
Contributor
Author
There was a problem hiding this comment.
If there are merge conflicts, it'll throw and fail your test run.
Contributor
Author
There was a problem hiding this comment.
(otherwise, it'll just work)
Hixie
reviewed
May 2, 2018
Contributor
|
|
In order to avoid checking binaries into flutter/flutter, this comparator can be used to retrieve golden files from a sibling flutter/goldens repository. #16859
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
In order to avoid checking binaries into flutter/flutter, this comparator can be used to retrieve golden files from a sibling flutter/goldens repository. flutter#16859
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid checking binaries into
flutter/flutter,this comparator is used to retrieve golden files from
a sibling
flutter/goldensrepository.#16859