Skip to content

Use UTC timezone for stamp_command_test to avoid local TZ flakes - #172319

Merged
matanlurey merged 1 commit into
flutter:masterfrom
matanlurey:use-utc-build-stamp
Jul 17, 2025
Merged

matanlurey merged 1 commit into
flutter:masterfrom
matanlurey:use-utc-build-stamp

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

Closes #172318.

@matanlurey
matanlurey requested a review from jtmcdole July 17, 2025 21:50
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Jul 17, 2025
defaultWorkingDirectory: tempRoot,
processManager: permissiveProcessManager,
),
now: () => DateTime(2025, 6, 27, 12, 30),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constructs a DateTime instance specified in the local time zone.

Dangit. I'm a big fan of utc epoch.

@matanlurey matanlurey added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Jul 17, 2025
@flutter-dashboard

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025
@matanlurey
matanlurey added this pull request to the merge queue Jul 17, 2025
Merged via the queue into flutter:master with commit 05845e7 Jul 17, 2025
@matanlurey
matanlurey deleted the use-utc-build-stamp branch July 17, 2025 23:28
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2025
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jul 18, 2025
flutter/flutter@9c626d9...440713c

2025-07-18 [email protected] Add OS version support section to plugin docs (flutter/flutter#172316)
2025-07-18 [email protected] Roll Dart SDK from 7fcc5f48c335 to fe2232bd5b9f (2 revisions) (flutter/flutter#172339)
2025-07-18 [email protected] Refactor handling of frame waiting. (flutter/flutter#172277)
2025-07-18 [email protected] Roll pub packages (flutter/flutter#172332)
2025-07-17 [email protected] Refactor and forbid `base/exit.dart` outside of `lib/runner.dart` (flutter/flutter#171923)
2025-07-17 [email protected] Use UTC timezone for `stamp_command_test` to avoid local TZ flakes (flutter/flutter#172319)
2025-07-17 [email protected] [web] Add tests for unified platform view embedding behavior (flutter/flutter#172313)
2025-07-17 [email protected] Platform views shouldn't receive pointer events when not laid out (flutter/flutter#172043)
2025-07-17 [email protected] Fix Size.isEmpty description (flutter/flutter#172021)
2025-07-17 [email protected] feat: Add `maxCount` parameter to `Badge.count` constructor. (flutter/flutter#171054)
2025-07-17 [email protected] add `debugPaintTextLayoutBoxes` for debugging text layout (flutter/flutter#168876)
2025-07-17 [email protected] Roll Packages from 4a231ae to cb8fef6 (31 revisions) (flutter/flutter#172303)
2025-07-17 [email protected] Fix mutating Paint bug (flutter/flutter#171180)
2025-07-17 [email protected] No SystemContextMenu when readOnly is true (flutter/flutter#171242)
2025-07-17 [email protected] Add a getter to get the recorder used by painting context (flutter/flutter#170223)
2025-07-17 [email protected] [Impeller] Add missing SetPipeline call for the vertices uber pipeline in AtlasContents (flutter/flutter#172273)
2025-07-17 [email protected] Roll Dart SDK from 486f9c0663bc to 7fcc5f48c335 (1 revision) (flutter/flutter#172279)
2025-07-17 [email protected] Roll Skia from 3673a1f26a63 to 9587301e33bc (3 revisions) (flutter/flutter#172281)
2025-07-17 [email protected] Fix a race in FlutterEngineTest.CanLogToStdout (flutter/flutter#172025)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
flutter/flutter@9c626d9...440713c

2025-07-18 [email protected] Add OS version support section to plugin docs (flutter/flutter#172316)
2025-07-18 [email protected] Roll Dart SDK from 7fcc5f48c335 to fe2232bd5b9f (2 revisions) (flutter/flutter#172339)
2025-07-18 [email protected] Refactor handling of frame waiting. (flutter/flutter#172277)
2025-07-18 [email protected] Roll pub packages (flutter/flutter#172332)
2025-07-17 [email protected] Refactor and forbid `base/exit.dart` outside of `lib/runner.dart` (flutter/flutter#171923)
2025-07-17 [email protected] Use UTC timezone for `stamp_command_test` to avoid local TZ flakes (flutter/flutter#172319)
2025-07-17 [email protected] [web] Add tests for unified platform view embedding behavior (flutter/flutter#172313)
2025-07-17 [email protected] Platform views shouldn't receive pointer events when not laid out (flutter/flutter#172043)
2025-07-17 [email protected] Fix Size.isEmpty description (flutter/flutter#172021)
2025-07-17 [email protected] feat: Add `maxCount` parameter to `Badge.count` constructor. (flutter/flutter#171054)
2025-07-17 [email protected] add `debugPaintTextLayoutBoxes` for debugging text layout (flutter/flutter#168876)
2025-07-17 [email protected] Roll Packages from 4a231ae to cb8fef6 (31 revisions) (flutter/flutter#172303)
2025-07-17 [email protected] Fix mutating Paint bug (flutter/flutter#171180)
2025-07-17 [email protected] No SystemContextMenu when readOnly is true (flutter/flutter#171242)
2025-07-17 [email protected] Add a getter to get the recorder used by painting context (flutter/flutter#170223)
2025-07-17 [email protected] [Impeller] Add missing SetPipeline call for the vertices uber pipeline in AtlasContents (flutter/flutter#172273)
2025-07-17 [email protected] Roll Dart SDK from 486f9c0663bc to 7fcc5f48c335 (1 revision) (flutter/flutter#172279)
2025-07-17 [email protected] Roll Skia from 3673a1f26a63 to 9587301e33bc (3 revisions) (flutter/flutter#172281)
2025-07-17 [email protected] Fix a race in FlutterEngineTest.CanLogToStdout (flutter/flutter#172025)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@9c626d9...440713c

2025-07-18 [email protected] Add OS version support section to plugin docs (flutter/flutter#172316)
2025-07-18 [email protected] Roll Dart SDK from 7fcc5f48c335 to fe2232bd5b9f (2 revisions) (flutter/flutter#172339)
2025-07-18 [email protected] Refactor handling of frame waiting. (flutter/flutter#172277)
2025-07-18 [email protected] Roll pub packages (flutter/flutter#172332)
2025-07-17 [email protected] Refactor and forbid `base/exit.dart` outside of `lib/runner.dart` (flutter/flutter#171923)
2025-07-17 [email protected] Use UTC timezone for `stamp_command_test` to avoid local TZ flakes (flutter/flutter#172319)
2025-07-17 [email protected] [web] Add tests for unified platform view embedding behavior (flutter/flutter#172313)
2025-07-17 [email protected] Platform views shouldn't receive pointer events when not laid out (flutter/flutter#172043)
2025-07-17 [email protected] Fix Size.isEmpty description (flutter/flutter#172021)
2025-07-17 [email protected] feat: Add `maxCount` parameter to `Badge.count` constructor. (flutter/flutter#171054)
2025-07-17 [email protected] add `debugPaintTextLayoutBoxes` for debugging text layout (flutter/flutter#168876)
2025-07-17 [email protected] Roll Packages from 4a231ae to cb8fef6 (31 revisions) (flutter/flutter#172303)
2025-07-17 [email protected] Fix mutating Paint bug (flutter/flutter#171180)
2025-07-17 [email protected] No SystemContextMenu when readOnly is true (flutter/flutter#171242)
2025-07-17 [email protected] Add a getter to get the recorder used by painting context (flutter/flutter#170223)
2025-07-17 [email protected] [Impeller] Add missing SetPipeline call for the vertices uber pipeline in AtlasContents (flutter/flutter#172273)
2025-07-17 [email protected] Roll Dart SDK from 486f9c0663bc to 7fcc5f48c335 (1 revision) (flutter/flutter#172279)
2025-07-17 [email protected] Roll Skia from 3673a1f26a63 to 9587301e33bc (3 revisions) (flutter/flutter#172281)
2025-07-17 [email protected] Fix a race in FlutterEngineTest.CanLogToStdout (flutter/flutter#172025)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@9c626d9...440713c

2025-07-18 [email protected] Add OS version support section to plugin docs (flutter/flutter#172316)
2025-07-18 [email protected] Roll Dart SDK from 7fcc5f48c335 to fe2232bd5b9f (2 revisions) (flutter/flutter#172339)
2025-07-18 [email protected] Refactor handling of frame waiting. (flutter/flutter#172277)
2025-07-18 [email protected] Roll pub packages (flutter/flutter#172332)
2025-07-17 [email protected] Refactor and forbid `base/exit.dart` outside of `lib/runner.dart` (flutter/flutter#171923)
2025-07-17 [email protected] Use UTC timezone for `stamp_command_test` to avoid local TZ flakes (flutter/flutter#172319)
2025-07-17 [email protected] [web] Add tests for unified platform view embedding behavior (flutter/flutter#172313)
2025-07-17 [email protected] Platform views shouldn't receive pointer events when not laid out (flutter/flutter#172043)
2025-07-17 [email protected] Fix Size.isEmpty description (flutter/flutter#172021)
2025-07-17 [email protected] feat: Add `maxCount` parameter to `Badge.count` constructor. (flutter/flutter#171054)
2025-07-17 [email protected] add `debugPaintTextLayoutBoxes` for debugging text layout (flutter/flutter#168876)
2025-07-17 [email protected] Roll Packages from 5c14a6c to ab23d17 (31 revisions) (flutter/flutter#172303)
2025-07-17 [email protected] Fix mutating Paint bug (flutter/flutter#171180)
2025-07-17 [email protected] No SystemContextMenu when readOnly is true (flutter/flutter#171242)
2025-07-17 [email protected] Add a getter to get the recorder used by painting context (flutter/flutter#170223)
2025-07-17 [email protected] [Impeller] Add missing SetPipeline call for the vertices uber pipeline in AtlasContents (flutter/flutter#172273)
2025-07-17 [email protected] Roll Dart SDK from 486f9c0663bc to 7fcc5f48c335 (1 revision) (flutter/flutter#172279)
2025-07-17 [email protected] Roll Skia from 3673a1f26a63 to 9587301e33bc (3 revisions) (flutter/flutter#172281)
2025-07-17 [email protected] Fix a race in FlutterEngineTest.CanLogToStdout (flutter/flutter#172025)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

et stamp is causing tree failures due to flaky date-time

2 participants