[VPAT][A11y] Announce Autocomplete search results status by victorsanni · Pull Request #173480 · flutter/flutter

victorsanni · 2025-08-08T20:01:00Z

Status announcements 'Search results found' and 'no results found' were observed on a search view on the iOS sheets app.

Fixes [VPAT][A11y] autocomplete must announce status when search result is available
Fixes b/429094918

gemini-code-assist

Code Review

This pull request enhances the accessibility of the Autocomplete widget by announcing search result status changes, which is a great improvement for users relying on screen readers. It also includes a fix to prevent tooltips from appearing during route transitions. The changes are well-implemented and include corresponding tests. I have one minor suggestion to improve code readability in autocomplete.dart.

gemini-code-assist · 2025-08-08T20:02:03Z

      return;
    }
+    if (_options.isEmpty != options.isEmpty) {
+      _announceSemantics(_options.isEmpty);


While the logic here is correct, it's a bit confusing to read. The call to _announceSemantics uses the state of the old options list (_options.isEmpty) to determine the announcement for the new options list.

Inside this if block, _options.isEmpty is logically equivalent to !options.isEmpty, but using the latter makes the intent much clearer: the announcement should be based on whether the new options list has results. This improves readability and maintainability, which is a core principle of the Flutter style guide.¹

_announceSemantics(!options.isEmpty);

Style Guide References

Footnotes

Code should be optimized for readability, as it is read more often than it is written. (link) ↩

justinmc

LGTM with nits 👍

justinmc · 2025-08-08T20:23:27Z

+
+  /// The semantics label used for [RawAutocomplete] when the options list goes
+  /// from non-empty to empty.
+  String get searchResultsUnavailable => 'Search results not available';


Did you get these strings from somewhere official? I just want to verify that this is exactly what it should say.

Kinda, the strings are from the google bug description, but even in there it doesn't seem 'official'.

If we want official sentence, we need to ask material team

justinmc · 2025-08-08T20:25:42Z

+    if (_options.isEmpty != options.isEmpty) {
+      _announceSemantics(options.isNotEmpty);
+    }


Nit: Just wondering, would it be better to make this announcement at the bottom of this method when the options have already been shown/updated?

Somewhat related to Gemini's comment #173480 (comment).

This conditional has to happen before updating _options, because we only want to announce when the options view appears or disappears, not when it merely changes.

But the code after this block depends on _options getting updated. _updateHighlight and _updateOptionsViewVisibility.

chunhtai · 2025-08-13T18:43:29Z

+
+  /// The semantics label used for [RawAutocomplete] when the options list goes
+  /// from non-empty to empty.
+  String get searchResultsUnavailable => 'Search results not available';


If we want official sentence, we need to ask material team

chunhtai

LGTM

) Status announcements 'Search results found' and 'no results found' were observed on a search view on the iOS sheets app. Fixes [[VPAT][A11y] autocomplete must announce status when search result is available](flutter#173064) Fixes b/429094918

…tter/flutter#173480)

flutter/flutter@f4334d2...52af7a5 2025-08-15 [email protected] Roll Packages from 09533b7 to 5c52c55 (6 revisions) (flutter/flutter#173854) 2025-08-15 [email protected] Roll Skia from 46ec77ae3954 to 5654ac32ede0 (1 revision) (flutter/flutter#173848) 2025-08-15 [email protected] Roll Skia from 162f47d6b6bd to 46ec77ae3954 (2 revisions) (flutter/flutter#173833) 2025-08-15 [email protected] Roll Dart SDK from c7faab270f27 to cc008dc8e7aa (2 revisions) (flutter/flutter#173826) 2025-08-15 [email protected] Roll Skia from ad5d04000101 to 162f47d6b6bd (5 revisions) (flutter/flutter#173822) 2025-08-15 [email protected] Update the RBE configuration for the recent Clang update (flutter/flutter#173803) 2025-08-15 [email protected] Stop writing legacy `FLUTTER_ROOT/version` file (by default?) (flutter/flutter#172793) 2025-08-15 [email protected] Remove `luci_flags.parallel_download_builds` and friends (flutter/flutter#173799) 2025-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Predictive back route transitions by default (#165832)" (flutter/flutter#173809) 2025-08-14 [email protected] Roll Skia from dca5f05fee87 to ad5d04000101 (8 revisions) (flutter/flutter#173798) 2025-08-14 [email protected] [web] Cleanup usages of deprecated `routeUpdated` message (flutter/flutter#173782) 2025-08-14 [email protected] Make sure that DataTable, DataColumn, DataRow, and DataCell don't crash in 0x0 environment (flutter/flutter#173515) 2025-08-14 [email protected] Make sure that a TableRowInkWell doesn't crash in 0x0 environment (flutter/flutter#173627) 2025-08-14 [email protected] Make sure that a DatePickerDialog doesn't crash in 0x0 environment (flutter/flutter#173677) 2025-08-14 [email protected] Return result of setting OpenGL contexts back to Flutter (flutter/flutter#173757) 2025-08-14 [email protected] Read `bin/cache/flutter.version.json` instead of `version` for `flutter_gallery` (flutter/flutter#173797) 2025-08-14 [email protected] Predictive back route transitions by default (flutter/flutter#165832) 2025-08-14 [email protected] feat: add onLongPressUp callback to InkWell widget (flutter/flutter#173221) 2025-08-14 [email protected] Roll Dart SDK from 214a7f829913 to c7faab270f27 (1 revision) (flutter/flutter#173792) 2025-08-14 [email protected] Add error handling for `Element` lifecycle user callbacks (flutter/flutter#173148) 2025-08-14 [email protected] Roll Fuchsia Linux SDK from I1TfNmsqTp7t3rO8e... to zWRpLglb48zC1vZLv... (flutter/flutter#173784) 2025-08-14 [email protected] [Range slider] Tap on active range, the thumb closest to the mouse cursor should move to the cursor position. (flutter/flutter#173725) 2025-08-14 [email protected] Roll Packages from 6cb9113 to 09533b7 (4 revisions) (flutter/flutter#173789) 2025-08-14 [email protected] Implements the Android native stretch effect as a fragment shader (Impeller-only). (flutter/flutter#169293) 2025-08-14 [email protected] Sync `CHANGELOG.md` (3.35 -> `master`) (flutter/flutter#173790) 2025-08-14 [email protected] [VPAT][A11y] Announce Autocomplete search results status (flutter/flutter#173480) 2025-08-14 [email protected] Fix InputDecorator label padding (flutter/flutter#173344) 2025-08-14 [email protected] Fix default minimumSize in dropdownMenu when maximumSize is null (flutter/flutter#169438) 2025-08-14 [email protected] Thread sub-builders for every engine-uploading builder (flutter/flutter#173742) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Status announcements 'Search results found' and 'no results found' were observed on a search view on the iOS sheets app. Fixes [[VPAT][A11y] autocomplete must announce status when search result is available](flutter#173064) Fixes b/429094918

flutter/flutter@f4334d2...52af7a5 2025-08-15 [email protected] Roll Packages from 09533b7 to 5c52c55 (6 revisions) (flutter/flutter#173854) 2025-08-15 [email protected] Roll Skia from 46ec77ae3954 to 5654ac32ede0 (1 revision) (flutter/flutter#173848) 2025-08-15 [email protected] Roll Skia from 162f47d6b6bd to 46ec77ae3954 (2 revisions) (flutter/flutter#173833) 2025-08-15 [email protected] Roll Dart SDK from c7faab270f27 to cc008dc8e7aa (2 revisions) (flutter/flutter#173826) 2025-08-15 [email protected] Roll Skia from ad5d04000101 to 162f47d6b6bd (5 revisions) (flutter/flutter#173822) 2025-08-15 [email protected] Update the RBE configuration for the recent Clang update (flutter/flutter#173803) 2025-08-15 [email protected] Stop writing legacy `FLUTTER_ROOT/version` file (by default?) (flutter/flutter#172793) 2025-08-15 [email protected] Remove `luci_flags.parallel_download_builds` and friends (flutter/flutter#173799) 2025-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Predictive back route transitions by default (#165832)" (flutter/flutter#173809) 2025-08-14 [email protected] Roll Skia from dca5f05fee87 to ad5d04000101 (8 revisions) (flutter/flutter#173798) 2025-08-14 [email protected] [web] Cleanup usages of deprecated `routeUpdated` message (flutter/flutter#173782) 2025-08-14 [email protected] Make sure that DataTable, DataColumn, DataRow, and DataCell don't crash in 0x0 environment (flutter/flutter#173515) 2025-08-14 [email protected] Make sure that a TableRowInkWell doesn't crash in 0x0 environment (flutter/flutter#173627) 2025-08-14 [email protected] Make sure that a DatePickerDialog doesn't crash in 0x0 environment (flutter/flutter#173677) 2025-08-14 [email protected] Return result of setting OpenGL contexts back to Flutter (flutter/flutter#173757) 2025-08-14 [email protected] Read `bin/cache/flutter.version.json` instead of `version` for `flutter_gallery` (flutter/flutter#173797) 2025-08-14 [email protected] Predictive back route transitions by default (flutter/flutter#165832) 2025-08-14 [email protected] feat: add onLongPressUp callback to InkWell widget (flutter/flutter#173221) 2025-08-14 [email protected] Roll Dart SDK from 214a7f829913 to c7faab270f27 (1 revision) (flutter/flutter#173792) 2025-08-14 [email protected] Add error handling for `Element` lifecycle user callbacks (flutter/flutter#173148) 2025-08-14 [email protected] Roll Fuchsia Linux SDK from I1TfNmsqTp7t3rO8e... to zWRpLglb48zC1vZLv... (flutter/flutter#173784) 2025-08-14 [email protected] [Range slider] Tap on active range, the thumb closest to the mouse cursor should move to the cursor position. (flutter/flutter#173725) 2025-08-14 [email protected] Roll Packages from 6cb9113 to 09533b7 (4 revisions) (flutter/flutter#173789) 2025-08-14 [email protected] Implements the Android native stretch effect as a fragment shader (Impeller-only). (flutter/flutter#169293) 2025-08-14 [email protected] Sync `CHANGELOG.md` (3.35 -> `master`) (flutter/flutter#173790) 2025-08-14 [email protected] [VPAT][A11y] Announce Autocomplete search results status (flutter/flutter#173480) 2025-08-14 [email protected] Fix InputDecorator label padding (flutter/flutter#173344) 2025-08-14 [email protected] Fix default minimumSize in dropdownMenu when maximumSize is null (flutter/flutter#169438) 2025-08-14 [email protected] Thread sub-builders for every engine-uploading builder (flutter/flutter#173742) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Status announcements 'Search results found' and 'no results found' were observed on a search view on the iOS sheets app. Fixes [[VPAT][A11y] autocomplete must announce status when search result is available](flutter#173064) Fixes b/429094918

…tter/flutter#173480)

) Status announcements 'Search results found' and 'no results found' were observed on a search view on the iOS sheets app. Fixes [[VPAT][A11y] autocomplete must announce status when search result is available](flutter#173064) Fixes b/429094918

flutter/flutter@f4334d2...52af7a5 2025-08-15 [email protected] Roll Packages from 09533b7 to 5c52c55 (6 revisions) (flutter/flutter#173854) 2025-08-15 [email protected] Roll Skia from 46ec77ae3954 to 5654ac32ede0 (1 revision) (flutter/flutter#173848) 2025-08-15 [email protected] Roll Skia from 162f47d6b6bd to 46ec77ae3954 (2 revisions) (flutter/flutter#173833) 2025-08-15 [email protected] Roll Dart SDK from c7faab270f27 to cc008dc8e7aa (2 revisions) (flutter/flutter#173826) 2025-08-15 [email protected] Roll Skia from ad5d04000101 to 162f47d6b6bd (5 revisions) (flutter/flutter#173822) 2025-08-15 [email protected] Update the RBE configuration for the recent Clang update (flutter/flutter#173803) 2025-08-15 [email protected] Stop writing legacy `FLUTTER_ROOT/version` file (by default?) (flutter/flutter#172793) 2025-08-15 [email protected] Remove `luci_flags.parallel_download_builds` and friends (flutter/flutter#173799) 2025-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Predictive back route transitions by default (#165832)" (flutter/flutter#173809) 2025-08-14 [email protected] Roll Skia from dca5f05fee87 to ad5d04000101 (8 revisions) (flutter/flutter#173798) 2025-08-14 [email protected] [web] Cleanup usages of deprecated `routeUpdated` message (flutter/flutter#173782) 2025-08-14 [email protected] Make sure that DataTable, DataColumn, DataRow, and DataCell don't crash in 0x0 environment (flutter/flutter#173515) 2025-08-14 [email protected] Make sure that a TableRowInkWell doesn't crash in 0x0 environment (flutter/flutter#173627) 2025-08-14 [email protected] Make sure that a DatePickerDialog doesn't crash in 0x0 environment (flutter/flutter#173677) 2025-08-14 [email protected] Return result of setting OpenGL contexts back to Flutter (flutter/flutter#173757) 2025-08-14 [email protected] Read `bin/cache/flutter.version.json` instead of `version` for `flutter_gallery` (flutter/flutter#173797) 2025-08-14 [email protected] Predictive back route transitions by default (flutter/flutter#165832) 2025-08-14 [email protected] feat: add onLongPressUp callback to InkWell widget (flutter/flutter#173221) 2025-08-14 [email protected] Roll Dart SDK from 214a7f829913 to c7faab270f27 (1 revision) (flutter/flutter#173792) 2025-08-14 [email protected] Add error handling for `Element` lifecycle user callbacks (flutter/flutter#173148) 2025-08-14 [email protected] Roll Fuchsia Linux SDK from I1TfNmsqTp7t3rO8e... to zWRpLglb48zC1vZLv... (flutter/flutter#173784) 2025-08-14 [email protected] [Range slider] Tap on active range, the thumb closest to the mouse cursor should move to the cursor position. (flutter/flutter#173725) 2025-08-14 [email protected] Roll Packages from 6cb9113 to 09533b7 (4 revisions) (flutter/flutter#173789) 2025-08-14 [email protected] Implements the Android native stretch effect as a fragment shader (Impeller-only). (flutter/flutter#169293) 2025-08-14 [email protected] Sync `CHANGELOG.md` (3.35 -> `master`) (flutter/flutter#173790) 2025-08-14 [email protected] [VPAT][A11y] Announce Autocomplete search results status (flutter/flutter#173480) 2025-08-14 [email protected] Fix InputDecorator label padding (flutter/flutter#173344) 2025-08-14 [email protected] Fix default minimumSize in dropdownMenu when maximumSize is null (flutter/flutter#169438) 2025-08-14 [email protected] Thread sub-builders for every engine-uploading builder (flutter/flutter#173742) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

victorsanni added 9 commits July 23, 2025 17:05

Fix tooltip crash

0bf182d

Merge branch 'master' into modal-route-fix

f0406cc

Add test

5d820e3

Merge branch 'master' into modal-route-fix

326faec

More tweaks

464f0ad

Apply review suggestions

2288b42

Null check at the top of helper method

8c8b508

Autocomplete semantics announcement

62be945

Add localizations

8ddb516

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Aug 8, 2025

gemini-code-assist Bot reviewed Aug 8, 2025

View reviewed changes

Remove extraneous files

c7206a7

github-actions Bot removed the p: material_ui material_ui package in flutter/packages label Aug 8, 2025

victorsanni added 2 commits August 8, 2025 13:03

Slight tweak

7a4231d

Merge branch 'master' into autocomplete-semantics

8e80c75

victorsanni requested review from chunhtai and justinmc August 8, 2025 20:07

justinmc approved these changes Aug 8, 2025

View reviewed changes

victorsanni added 2 commits August 8, 2025 15:36

Generate localizations

5411170

Merge branch 'master' into autocomplete-semantics

b944940

github-actions Bot added the a: internationalization Supporting other languages or locales. (aka i18n) label Aug 8, 2025

victorsanni added 2 commits August 8, 2025 16:14

Remove trailing spaces

8535539

Merge branch 'master' into autocomplete-semantics

e97262f

victorsanni requested a review from QuncCccccc August 11, 2025 18:46

victorsanni changed the title ~~Announce Autocomplete search results status~~ [VPAT][A11y] Announce Autocomplete search results status Aug 11, 2025

chunhtai reviewed Aug 13, 2025

View reviewed changes

victorsanni added 3 commits August 13, 2025 20:18

Update semantic announcement status messages

6c0c6fa

Remove redundant annotations

ceac2c0

Add mediaquery.supportannounceof(context)

ac6716b

victorsanni requested a review from chunhtai August 14, 2025 03:39

Merge branch 'master' into autocomplete-semantics

9634e19

chunhtai approved these changes Aug 14, 2025

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2025

auto-submit Bot added this pull request to the merge queue Aug 14, 2025

Merged via the queue into flutter:master with commit e68da97 Aug 14, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e68da97 [VPAT][A11y] Announce Autocomplete search results status (flu…

256a8d8

…tter/flutter#173480)

engine-flutter-autoroll mentioned this pull request Aug 15, 2025

Roll Flutter from f4334d27934b to 3bf280c86fb9 (27 revisions) flutter/packages#9823

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e68da97 [VPAT][A11y] Announce Autocomplete search results status (flu…

3b0c702

…tter/flutter#173480)

engine-flutter-autoroll mentioned this pull request Aug 15, 2025

Roll Flutter from f4334d27934b to da5c047a13d7 (28 revisions) flutter/packages#9827

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e68da97 [VPAT][A11y] Announce Autocomplete search results status (flu…

0e32220

…tter/flutter#173480)

engine-flutter-autoroll mentioned this pull request Aug 15, 2025

Roll Flutter from f4334d27934b to 52af7a504025 (29 revisions) flutter/packages#9832

Merged

Piinks mentioned this pull request Aug 15, 2025

Flutter Notable Commits - 2025 #161460

Closed

victorsanni deleted the autocomplete-semantics branch August 18, 2025 20:49

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

e68da97 [VPAT][A11y] Announce Autocomplete search results status (flu…

c50c8b5

…tter/flutter#173480)

Navigation Menu

Repository navigation

[VPAT][A11y] Announce Autocomplete search results status - #173480

[VPAT][A11y] Announce Autocomplete search results status#173480
auto-submit[bot] merged 20 commits into
flutter:masterfrom
victorsanni:autocomplete-semantics

victorsanni commented Aug 8, 2025 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Aug 8, 2025

Uh oh!

justinmc left a comment

Uh oh!

justinmc Aug 8, 2025

Uh oh!

victorsanni Aug 8, 2025

Uh oh!

chunhtai Aug 13, 2025

Uh oh!

justinmc Aug 8, 2025

Uh oh!

justinmc Aug 8, 2025

Uh oh!

victorsanni Aug 8, 2025

Uh oh!

Uh oh!

chunhtai Aug 13, 2025

Uh oh!

chunhtai left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

victorsanni commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Aug 8, 2025

Choose a reason for hiding this comment

Style Guide References

Footnotes

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chunhtai Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

victorsanni commented Aug 8, 2025 •

edited

Loading