Repository navigation
Refactor Predicate.java to address linter issues - #175278
Closed
AbdeMohlbi wants to merge 14 commits into
Closed
AbdeMohlbi wants to merge 14 commits into
AbdeMohlbi wants to merge 14 commits into
Conversation
github-actions
Bot
added
platform-android
AbdeMohlbi
marked this pull request as ready for review
September 13, 2025 08:16
reidbaker
reviewed
Sep 15, 2025
reidbaker
left a comment
reidbaker
left a comment
Contributor
There was a problem hiding this comment.
What is interesting here is that the 24 is currently the min api. @AbdeMohlbi want to try removing this interface altogether since the comment indicates it is no longer needed?
AbdeMohlbi
marked this pull request as draft
September 15, 2025 18:28
Member
Author
|
yeah as it seems that one manifest file was suppresing all the linter issues and now they all appeared :/ |
Member
Author
|
yeah sorry i don't have the mental capacity to fix all the linter issues but still thank u @reidbaker |
6 of 9 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
![auto-submit[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Relands #175278 this PR bumps used minSdk version in the `engine` to `24` . ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] All existing and new tests are passing. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: StepSecurity Bot <[email protected]> Signed-off-by: jwlilly <[email protected]> Signed-off-by: huycozy <[email protected]> Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Matthew Kosarek <[email protected]> Co-authored-by: Abdelaziz Mahdy <[email protected]> Co-authored-by: Victoria Ashworth <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Reid Baker <[email protected]> Co-authored-by: Ben Konyi <[email protected]> Co-authored-by: Flop <[email protected]> Co-authored-by: Victor Sanni <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gaaclarke <[email protected]> Co-authored-by: Slava Egorov <[email protected]> Co-authored-by: Flutter GitHub Bot <[email protected]> Co-authored-by: Elijah Okoroh <[email protected]> Co-authored-by: Bruno Leroux <[email protected]> Co-authored-by: LongCatIsLooong <[email protected]> Co-authored-by: zhongliugo <[email protected]> Co-authored-by: auto-submit[bot] <98614782+auto-submit[bot]@users.noreply.github.com> Co-authored-by: auto-submit[bot] <[email protected]> Co-authored-by: Loïc Sharma <[email protected]> Co-authored-by: Felipe Peter <[email protected]> Co-authored-by: Daco Harkes <[email protected]> Co-authored-by: Ahmed Mohamed Sameh <[email protected]> Co-authored-by: Simon Binder <[email protected]> Co-authored-by: ANUJ KUMAR <[email protected]> Co-authored-by: anuj.kumar <[email protected]> Co-authored-by: Michael Goderbauer <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Pierre <[email protected]> Co-authored-by: StepSecurity Bot <[email protected]> Co-authored-by: Pierre-Louis <[email protected]> Co-authored-by: Zachary Anderson <[email protected]> Co-authored-by: bungeman <[email protected]> Co-authored-by: jesswrd <[email protected]> Co-authored-by: John Lilly <[email protected]> Co-authored-by: Camille Simon <[email protected]> Co-authored-by: b-luk <[email protected]> Co-authored-by: flutter-pub-roller-bot <[email protected]> Co-authored-by: Michel Feinstein <[email protected]> Co-authored-by: Matej Knopp <[email protected]> Co-authored-by: Tess Strickland <[email protected]> Co-authored-by: Huy <[email protected]> Co-authored-by: Kostia Sokolovskyi <[email protected]> Co-authored-by: LouiseHsu <[email protected]> Co-authored-by: Mouad Debbar <[email protected]> Co-authored-by: Tim Maffett <[email protected]> Co-authored-by: Aaron Clarke <[email protected]> Co-authored-by: Renzo Olivares <[email protected]> Co-authored-by: Renzo Olivares <[email protected]> Co-authored-by: Nebojša Cvetković <[email protected]> Co-authored-by: Tirth <[email protected]> Co-authored-by: Ivan Inozemtsev <[email protected]> Co-authored-by: Jason Simmons <[email protected]> Co-authored-by: Nicholas Shahan <[email protected]> Co-authored-by: Jon Ihlas <[email protected]> Co-authored-by: Robert Ancell <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]> Co-authored-by: Jackson Gardner <[email protected]> Co-authored-by: Jim Graham <[email protected]> Co-authored-by: DoLT <[email protected]> Co-authored-by: Kevin Moore <[email protected]> Co-authored-by: John "codefu" McDole <[email protected]> Co-authored-by: Dev TtangKong <[email protected]> Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Matt Boetger <[email protected]> Co-authored-by: Kaylee Lubick <[email protected]> Co-authored-by: Ramon Farizel <[email protected]> Co-authored-by: chunhtai <[email protected]> Co-authored-by: Lau Ching Jun <[email protected]> Co-authored-by: Rusino <[email protected]> Co-authored-by: Reid Baker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.