Skip to content

Ensure that VM service extension handlers are run on outer event loop. - #17812

Merged
tvolkert merged 2 commits into
flutter:masterfrom
tvolkert:vmservice
May 22, 2018
Merged

tvolkert merged 2 commits into
flutter:masterfrom
tvolkert:vmservice

Conversation

@tvolkert

Copy link
Copy Markdown
Contributor

Fixes #17597

@Hixie

Hixie commented May 22, 2018

Copy link
Copy Markdown
Contributor

...test? :-)

LGTM

@tvolkert
tvolkert merged commit 9471e4e into flutter:master May 22, 2018
@tvolkert
tvolkert deleted the vmservice branch May 22, 2018 18:55
tvolkert added a commit that referenced this pull request May 24, 2018
They've been mostly green since #17812
@Hixie

Hixie commented May 24, 2018

Copy link
Copy Markdown
Contributor

This may have affected hot reload benchmarks. See in particular hot_mode_dev_cycle_win__benchmark hotReloadMillisecondsToFrame.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed assert in ScrollPosition.setPixels()

3 participants