Skip to content

Replace semantic announcements in expansion tile for Android - #179917

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
hannah-hyj:expansion-tile-live-region
Jan 6, 2026
Merged

auto-submit[bot] merged 3 commits into
flutter:masterfrom
hannah-hyj:expansion-tile-live-region

Conversation

@hannah-hyj

@hannah-hyj hannah-hyj commented Dec 16, 2025 •

Copy link
Copy Markdown
Member

fixes: #177785

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@hannah-hyj
hannah-hyj requested a review from chunhtai December 16, 2025 00:24
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Dec 16, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the semantic announcements for ExpansionTile on Android by replacing SemanticsService.sendAnnouncement with a Semantics live region. This change aligns with modern accessibility practices. The accompanying test modifications correctly reflect this new behavior, including adding a new test for the Android-specific implementation. I've included a couple of suggestions to enhance code readability and maintainability by reducing code duplication in both the widget implementation and the new test.

Comment thread packages/flutter/lib/src/material/expansion_tile.dart
Comment thread packages/flutter/test/material/expansion_tile_test.dart

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj

Copy link
Copy Markdown
Member Author

fixing google3 tests for this one.

@hannah-hyj
hannah-hyj force-pushed the expansion-tile-live-region branch from 620169c to 9cb48f5 Compare January 5, 2026 22:33
@hannah-hyj hannah-hyj added autosubmit Merge PR when tree becomes green via auto submit App labels Jan 6, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Jan 6, 2026
Merged via the queue into flutter:master with commit a397a24 Jan 6, 2026
73 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ExpansionTile usage of Semantic Announcements

2 participants