Make sure that a Container doesn't crash in 0x0 environment by ahmedsameha1 · Pull Request #180350 · flutter/flutter

ahmedsameha1 · 2025-12-28T11:54:56Z

This is my attempt to handle #6537 for the Container widget.

gemini-code-assist

Code Review

This pull request adds a regression test to ensure that a Container widget with a zero-sized area does not crash, addressing a previously reported issue. While the added test is a good start, it doesn't fully cover the conditions that led to the original crash. Specifically, the original issue was related to a Container with a BoxDecoration that included a borderRadius and boxShadow. I've suggested an improvement to the test to make it more comprehensive and accurately reflect the scenario that needs to be covered.

gemini-code-assist · 2025-12-28T12:16:05Z

+  testWidgets('Container does not crash at zero area', (WidgetTester tester) async {
+    await tester.pumpWidget(
+      Directionality(
+        textDirection: TextDirection.ltr,
+        child: Center(
+          child: SizedBox.shrink(child: Container(child: const Text('X'))),
+        ),
+      ),
+    );
+    expect(tester.getSize(find.byType(Container)), Size.zero);
+  });


This test case is a good start for ensuring Container doesn't crash at zero size. However, the original issue (#6537) specifically mentions a crash when the Container has a BoxDecoration with borderRadius and boxShadow. To make this test more robust and ensure it covers the original bug, it would be better to include a similar decoration in the Container under test.

testWidgets('Container with decoration does not crash at zero area', (WidgetTester tester) async { await tester.pumpWidget( Directionality( textDirection: TextDirection.ltr, child: Center( child: SizedBox.shrink( child: Container( decoration: BoxDecoration( borderRadius: BorderRadius.circular(10.0), boxShadow: const <BoxShadow>[ BoxShadow(blurRadius: 5.0), ], ), child: const Text('X'), ), ), ), ), ); expect(tester.getSize(find.byType(Container)), Size.zero); });

justinmc

LGTM but heads up there's an analyzer failure.

auto-submit · 2025-12-31T01:33:28Z

autosubmit label was removed for flutter/flutter/180350, because - The status or check suite Linux analyzer_benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

dkwingsmt · 2026-01-05T23:55:49Z

   info • Unnecessary instance of 'Container' • packages/flutter/test/widgets/container_test.dart:788:41 • avoid_unnecessary_containers

Maybe add some decorations to suppress it.

…lutter/flutter#180350)

Roll Flutter from 01d37bc to 73769a2 (65 revisions) flutter/flutter@01d37bc...73769a2 2026-01-10 [email protected] Roll Dart SDK from 5e855c2bb3ef to 87fbfd5381b6 (1 revision) (flutter/flutter#180800) 2026-01-10 [email protected] Roll Skia from b2b109f0e980 to f39cc645b1dd (2 revisions) (flutter/flutter#180796) 2026-01-10 [email protected] Roll Dart SDK from b7963905e6a2 to 5e855c2bb3ef (2 revisions) (flutter/flutter#180794) 2026-01-10 [email protected] Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment (flutter/flutter#179824) 2026-01-10 [email protected] Roll Dart SDK from d25ad331b7ea to b7963905e6a2 (2 revisions) (flutter/flutter#180783) 2026-01-10 [email protected] Make sure that a Container doesn't crash in 0x0 environment (flutter/flutter#180350) 2026-01-10 [email protected] Make sure that an Expansible doesn't crash in 0x0 environment (flutter/flutter#180478) 2026-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enabled some disabled impeller fragment shader dart tests (#180759)" (flutter/flutter#180785) 2026-01-09 [email protected] Merge `widget_tester_leaks_free_test.dart` into `widget_tester_test.dart` (flutter/flutter#180600) 2026-01-09 [email protected] fix: there are no riscv fuchsia artifacts (flutter/flutter#180779) 2026-01-09 [email protected] Roll Skia from 7386219151e6 to b2b109f0e980 (1 revision) (flutter/flutter#180771) 2026-01-09 [email protected] Re-prioritize pipeline compile jobs and perform them eagerly instead of waiting. (flutter/flutter#180022) 2026-01-09 [email protected] Enabled some disabled impeller fragment shader dart tests (flutter/flutter#180759) 2026-01-09 [email protected] Roll Fuchsia Linux SDK from rxeg-6UB678HKJ4UQ... to 83Favz_zzMzdVuOHg... (flutter/flutter#180765) 2026-01-09 [email protected] [A11y ] Add `clearSemantics`in table (flutter/flutter#180665) 2026-01-09 [email protected] Update CODEOWNERS to remove chinmaygarde. (flutter/flutter#180703) 2026-01-09 [email protected] [ Tool ] Add support for linux riscv64 architecture (flutter/flutter#178711) 2026-01-09 [email protected] Roll Skia from e9b3264ade0c to 7386219151e6 (12 revisions) (flutter/flutter#180754) 2026-01-09 [email protected] Roll Dart SDK from fe2ba2c5dd50 to d25ad331b7ea (10 revisions) (flutter/flutter#180741) 2026-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unpin google_mobile_ads (#180573)" (flutter/flutter#180761) 2026-01-09 [email protected] Fix typo in dropdown_menu.dart (flutter/flutter#180172) 2026-01-09 [email protected] Roll Packages from 039a026 to 51fe1d9 (1 revision) (flutter/flutter#180742) 2026-01-09 [email protected] Unpin google_mobile_ads (flutter/flutter#180573) 2026-01-09 [email protected] Update flutter changelog for 3.38.6 (flutter/flutter#180708) 2026-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix iOS xattr removal to clear all extended attributes (#180355)" (flutter/flutter#180709) 2026-01-08 [email protected] Make sure that an EditableText doesn't crash in 0x0 environment (flutter/flutter#180457) 2026-01-08 [email protected] Implementation of tooltip windows for win32 (flutter/flutter#179147) 2026-01-08 [email protected] [web] Don't serve files outside of project (flutter/flutter#180699) 2026-01-08 [email protected] Roll Skia from 837be28dd218 to e9b3264ade0c (1 revision) (flutter/flutter#180702) 2026-01-08 [email protected] Add new motion accessibility features to iOS. (flutter/flutter#178102) 2026-01-08 [email protected] Fix iOS xattr removal to clear all extended attributes (flutter/flutter#180355) 2026-01-08 [email protected] [ Widget Preview ] Move widget_preview_scaffold tests to `dev/integration_tests/widget_preview_scaffold` (flutter/flutter#180658) 2026-01-08 [email protected] De-interleaves engine dart test output (flutter/flutter#180651) 2026-01-08 [email protected] [web] Fix SemanticsService.announce not working inside dialogs (flutter/flutter#179958) 2026-01-08 [email protected] Roll Skia from 42233226ac56 to 837be28dd218 (2 revisions) (flutter/flutter#180693) 2026-01-08 [email protected] Roll Dart SDK to 3.11.0-296.2.beta (flutter/flutter#180685) 2026-01-08 [email protected] Improve code quality in `AndroidTouchProcessorTest.java` (flutter/flutter#180583) 2026-01-08 [email protected] Revert "Reverts "[reland] Unify canvas creation and Surface code in S…kwasm and CanvasKit (#179473)" (#180152)" (flutter/flutter#180610) 2026-01-08 [email protected] Roll Skia from a0c407bce408 to 42233226ac56 (4 revisions) (flutter/flutter#180688) 2026-01-08 [email protected] [ Tool ] Fix flake in overall_experience_test.dart (flutter/flutter#180655) 2026-01-08 [email protected] Roll Packages from 9705815 to 039a026 (6 revisions) (flutter/flutter#180684) 2026-01-08 [email protected] flutter_tools: Auto-generate ExportOptions.plist for manual iOS code signing (flutter/flutter#177888) 2026-01-08 [email protected] Roll Skia from 58837e160874 to a0c407bce408 (2 revisions) (flutter/flutter#180679) 2026-01-08 [email protected] Roll Skia from 1e3266fdba86 to 58837e160874 (1 revision) (flutter/flutter#180677) 2026-01-08 [email protected] Roll Skia from 3c47ea10638f to 1e3266fdba86 (4 revisions) (flutter/flutter#180675) 2026-01-08 [email protected] Roll Fuchsia Linux SDK from dTvN_JVSCfGFRasvH... to rxeg-6UB678HKJ4UQ... (flutter/flutter#180673) ...

github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Dec 28, 2025

gemini-code-assist Bot reviewed Dec 28, 2025

View reviewed changes

justinmc approved these changes Dec 30, 2025

View reviewed changes

justinmc requested a review from victorsanni December 30, 2025 23:16

victorsanni approved these changes Dec 31, 2025

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 31, 2025

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 31, 2025

Make sure that a Container doesn't crash in 0x0 environment

ddb8e82

ahmedsameha1 force-pushed the handle#6537-Container branch from 931b6dd to ddb8e82 Compare January 6, 2026 06:50

ahmedsameha1 and others added 2 commits January 6, 2026 08:57

Merge branch 'master' into handle#6537-Container

339c2a2

Merge branch 'master' into handle#6537-Container

fda147c

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2026

auto-submit Bot added this pull request to the merge queue Jan 10, 2026

Merged via the queue into flutter:master with commit 5566fdd Jan 10, 2026
70 of 71 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2026

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 0b7596b3f269 (64 revisions) flutter/packages#10768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

5566fdd Make sure that a Container doesn't crash in 0x0 environment (f…

50cab22

…lutter/flutter#180350)

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

5566fdd Make sure that a Container doesn't crash in 0x0 environment (f…

b7b2029

…lutter/flutter#180350)

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10770

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

5566fdd Make sure that a Container doesn't crash in 0x0 environment (f…

fea5932

…lutter/flutter#180350)

Navigation Menu

Repository navigation

Make sure that a Container doesn't crash in 0x0 environment - #180350

Make sure that a Container doesn't crash in 0x0 environment#180350
auto-submit[bot] merged 3 commits into
flutter:masterfrom
ahmedsameha1:handle#6537-Container

ahmedsameha1 commented Dec 28, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Dec 28, 2025

Uh oh!

justinmc left a comment

Uh oh!

auto-submit Bot commented Dec 31, 2025

Uh oh!

dkwingsmt commented Jan 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ahmedsameha1 commented Dec 28, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Dec 31, 2025

Uh oh!

dkwingsmt commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dkwingsmt commented Jan 5, 2026 •

edited

Loading