Skip to content

Update date localization - #181685

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
QuncCccccc:update_date_localization
Feb 10, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
QuncCccccc:update_date_localization

Conversation

@QuncCccccc

Copy link
Copy Markdown
Contributor

This PR is to update date localization. The update introduced NBSP to connect time and its period(am or pm), so some invisible breakages are expected.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) labels Jan 29, 2026
@QuncCccccc
QuncCccccc force-pushed the update_date_localization branch from 45d08d3 to 3babcc2 Compare February 4, 2026 21:13
@github-actions github-actions Bot added the p: material_ui material_ui package in flutter/packages label Feb 4, 2026
@QuncCccccc
QuncCccccc marked this pull request as ready for review February 4, 2026 21:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates date localization data and tests for several locales, including Russian, en_GB, and Arabic. The changes involve using a narrow no-break space for Russian, adjusting the en_GB date format, and updating a test expectation for the Arabic year format. While most changes improve localization, I've identified an inconsistency in the numeral systems for the Arabic locale test, where the year is in Western numerals but the days are in Eastern Arabic numerals. I've provided a comment with a suggestion to align them for a better user experience.

Comment thread packages/flutter_localizations/test/material/date_picker_test.dart
@QuncCccccc
QuncCccccc requested a review from Piinks February 5, 2026 22:27
@QuncCccccc

QuncCccccc commented Feb 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Created a g3fix: cl/831625146. The other failures should just be scubas and expected.

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! 🥳

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Feb 10, 2026
Merged via the queue into flutter:master with commit 1c1ba3a Feb 10, 2026
72 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2026
flar added a commit that referenced this pull request Feb 10, 2026
@flar

flar commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Reason for revert: breaks l10n tests in the tree

@flar flar added the revert Autorevert PR (with "Reason for revert:" comment) label Feb 10, 2026
auto-submit Bot pushed a commit that referenced this pull request Feb 10, 2026
@auto-submit auto-submit Bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Feb 10, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Feb 10, 2026
<!-- start_original_pr_link -->
Reverts: #181685
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: flar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breaks l10n tests in the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: QuncCccccc
<!-- end_original_pr_author -->

Fixes: #182181

<!-- start_reviewers -->
Reviewed By: {Piinks}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This PR is to update date localization. The update introduced NBSP to
connect time and its period(am or pm), so some invisible breakages are
expected.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
QuncCccccc added a commit to QuncCccccc/flutter that referenced this pull request Feb 11, 2026
@QuncCccccc QuncCccccc mentioned this pull request Feb 11, 2026
9 tasks done
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
This PR is to update date localization. The update introduced NBSP to
connect time and its period(am or pm), so some invisible breakages are
expected.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
<!-- start_original_pr_link -->
Reverts: flutter#181685
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: flar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breaks l10n tests in the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: QuncCccccc
<!-- end_original_pr_author -->

Fixes: flutter#182181

<!-- start_reviewers -->
Reviewed By: {Piinks}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This PR is to update date localization. The update introduced NBSP to
connect time and its period(am or pm), so some invisible breakages are
expected.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
This PR is a reland of flutter#181685.
The update introduced NBSP to connect time and its period(am or pm), so
some invisible breakages are expected.

Fix is added in the second
[commit](flutter@06be40e).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
This PR is to update date localization. The update introduced NBSP to
connect time and its period(am or pm), so some invisible breakages are
expected.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
<!-- start_original_pr_link -->
Reverts: flutter#181685
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: flar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breaks l10n tests in the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: QuncCccccc
<!-- end_original_pr_author -->

Fixes: flutter#182181

<!-- start_reviewers -->
Reviewed By: {Piinks}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This PR is to update date localization. The update introduced NBSP to
connect time and its period(am or pm), so some invisible breakages are
expected.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
This PR is a reland of flutter#181685.
The update introduced NBSP to connect time and its period(am or pm), so
some invisible breakages are expected.

Fix is added in the second
[commit](flutter@06be40e).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
justinmc pushed a commit to justinmc/packages that referenced this pull request Jul 7, 2026
<!-- start_original_pr_link -->
Reverts: flutter/flutter#181685
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: flar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breaks l10n tests in the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: QuncCccccc
<!-- end_original_pr_author -->

Fixes: flutter/flutter#182181

<!-- start_reviewers -->
Reviewed By: {Piinks}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This PR is to update date localization. The update introduced NBSP to
connect time and its period(am or pm), so some invisible breakages are
expected.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
justinmc pushed a commit to justinmc/packages that referenced this pull request Jul 7, 2026
This PR is a reland of flutter/flutter#181685.
The update introduced NBSP to connect time and its period(am or pm), so
some invisible breakages are expected.

Fix is added in the second
[commit](flutter/flutter@06be40e).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Zubii12 pushed a commit to Zubii12/packages that referenced this pull request Jul 23, 2026
<!-- start_original_pr_link -->
Reverts: flutter/flutter#181685
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: flar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breaks l10n tests in the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: QuncCccccc
<!-- end_original_pr_author -->

Fixes: flutter/flutter#182181

<!-- start_reviewers -->
Reviewed By: {Piinks}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This PR is to update date localization. The update introduced NBSP to
connect time and its period(am or pm), so some invisible breakages are
expected.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
Zubii12 pushed a commit to Zubii12/packages that referenced this pull request Jul 23, 2026
This PR is a reland of flutter/flutter#181685.
The update introduced NBSP to connect time and its period(am or pm), so
some invisible breakages are expected.

Fix is added in the second
[commit](flutter/flutter@06be40e).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Nakiha pushed a commit to Nakiha/VoidPlayer-Flutter that referenced this pull request Sep 28, 2026
<!-- start_original_pr_link -->
Reverts: flutter/flutter#181685
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: flar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breaks l10n tests in the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: QuncCccccc
<!-- end_original_pr_author -->

Fixes: flutter/flutter#182181

<!-- start_reviewers -->
Reviewed By: {Piinks}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This PR is to update date localization. The update introduced NBSP to
connect time and its period(am or pm), so some invisible breakages are
expected.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
Nakiha pushed a commit to Nakiha/VoidPlayer-Flutter that referenced this pull request Sep 28, 2026
This PR is a reland of flutter/flutter#181685.
The update introduced NBSP to connect time and its period(am or pm), so
some invisible breakages are expected.

Fix is added in the second
[commit](flutter/flutter@06be40e).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants