Skip to content

Roll engine to a83b37d35acd8afd82be3f567a4b7231d5bdb928 - #18206

Merged
aam merged 3 commits into
flutter:masterfrom
aam:roll-engine-20180605
Jun 5, 2018
Merged

Roll engine to a83b37d35acd8afd82be3f567a4b7231d5bdb928#18206
aam merged 3 commits into
flutter:masterfrom
aam:roll-engine-20180605

Conversation

@aam

@aam aam commented Jun 5, 2018

Copy link
Copy Markdown
Member

Changes since last roll:

a83b37d35 Roll dart to a5e41681e55d1e74684bfff530218db556d77ee8 (#5467)
e45971083 Roll src/third_party/skia 9856c3d..4295859 (1 commits) (#5466)
d913985ec Roll src/third_party/skia 4588ff3..9856c3d (1 commits) (#5465)
2a4d926ab Update FlutterPluginRegistrxxx docs for iOS (#5415)
8ecdc3098 Roll src/third_party/skia ddd92dc..4588ff3 (1 commits) (#5464)
0b60f450c Roll src/third_party/skia 5034384..ddd92dc (3 commits) (#5463)
014a53f58 Roll src/third_party/skia 69d0e51..5034384 (2 commits) (#5462)
366d0e3ef Fix Dart project configuration for headless Dart runners. (#5461)
3d87b2717 libtxt: fix bug in calculating line end positions excluding whitespace (#5459)
44863aa4f Remove uses of ReleaseOwnership from vulkan backend (#5458)
f2992a1f5 Roll src/third_party/skia 7c93472..69d0e51 (3 commits) (#5460)
8c84737ea Update GrVkBackendContext to no longer own the VkInstance and VkDevice (#5457)
975d4ead6 libtxt: support per-locale fallback font collections (#5434)
ac7d442a6 Roll src/third_party/skia 728b7f3..7c93472 (6 commits) (#5455)
aa5c11d3f Roll Dart SDK to 1fe279d859 (#5454)
5ca93f31f Roll src/third_party/skia fd6a52c..728b7f3 (1 commits) (#5453)
5babb905e Roll src/third_party/skia a09981c..fd6a52c (1 commits) (#5452)
d3d40617f Roll src/third_party/skia a694870..a09981c (2 commits) (#5451)
eb11142e5 Roll src/third_party/skia 257c1fb..a694870 (2 commits) (#5450)
16f4da984 Parse --verbose-logging flag from intent and pass to the engine as args. (#5447)
78f46bd42 Log an error and cancel DartVM init if the VM/isolate snapshots are invalid (#5449)
50f623ab6 Roll src/third_party/skia 2ab87fc..257c1fb (6 commits) (#5448)
b599b597e Update CONTRIBUTING.md (#5444)
f81ed8990 Roll src/third_party/skia 7abeb28..2ab87fc (12 commits) (#5445)
c0ec8d9f0 Restore archive support removed in #5305. Codepush bundles use zip. (#5441)
0470f1c8c Remove --limit-ints-to-64-bits Dart VM option (#5442)
d7e3f2d6e Fix lint errors to prepare for building Android files in Google (#5440)
bc7949980 Roll src/third_party/skia 22f673d..7abeb28 (9 commits) (#5439)
9be67586b Roll src/third_party/skia c4952be..22f673d (4 commits) (#5438)
7b6acfd14 Roll src/third_party/skia db33ee1..c4952be (1 commits) (#5437)
1b30d4604 Roll src/third_party/skia e70c5fb..db33ee1 (1 commits) (#5436)

@aam
aam requested review from a-siva and mkustermann June 5, 2018 16:57
alexmarkov
alexmarkov approved these changes Jun 5, 2018
View reviewed changes

@alexmarkov alexmarkov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aam

aam commented Jun 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Since appveyor timed out, but cirrus completed, I will take that as a sufficient confirmation of windows coverage to go ahead with the merge.

@aam
aam merged commit 57187b0 into flutter:master Jun 5, 2018
@aam
aam deleted the roll-engine-20180605 branch June 5, 2018 18:04
@Hixie

Hixie commented Jun 5, 2018

Copy link
Copy Markdown
Contributor

How did this pass cirrus and travis and so on but fail so spectacularly on devicelab?

@aam

aam commented Jun 5, 2018

Copy link
Copy Markdown
Member Author

This was submitted via 'Rebase and merge'. So what failed was one(first) commit out of three, which had linux engine build failure. Cirrus, Travis, AppVeyor check only the last commit.

@mkustermann

mkustermann commented Jun 6, 2018

Copy link
Copy Markdown
Member

In the engine -> flutter roll I prepared (#18166) I was going to use two revisions before the the Dart roll (because the revision immediately before the Dart roll had a broken build, the buildbot was purple)

@aam

aam commented Jun 6, 2018

Copy link
Copy Markdown
Member Author

Another way to roll to the previously failed engine build is to force that build again.

@Hixie

Hixie commented Jun 8, 2018

Copy link
Copy Markdown
Contributor

@aam ah, that makes sense. Thanks for the explanation.

a-siva added a commit to a-siva/flutter that referenced this pull request May 8, 2020
@a-siva
Manual roll of engine 7e205b3...3953c3c
362a56d 
7e205b3 Roll src/fuchsia/sdk/mac from 1MVsE... to 4MCVP... (flutter#18217)
9193d8f Roll src/third_party/skia 0dc207f836da..a14084ba1b41 (3 commits) (flutter#18219)
403931f Add FlValue (flutter#18185)
46a6d96 [SkParagraph] Copy text height behavior to the Skia paragraph style (flutter#18178)
e7ee47d [web] Implement matrix parameter for linear gradient (flutter#18208)
28d9985 Reland again "Remove layer integral offset snapping flutter#17112" (flutter#18160)
5e361f5 Roll src/third_party/skia c66cd987f7c0..0dc207f836da (5 commits) (flutter#18212)
716dbf0 Refactor GLFW embedding to support headless mode (flutter#18205)
23cca32 Manual Roll of Dart 39e0e75fcf...ce62ad2e8b (flutter#18211)
15f72b8 Support EventChannel C++ plugin API for Linux/Windows (flutter#17015)
e5a7ca5 Handle leak of message handle when no engine present (flutter#18157)
d3bde19 add docs to platformviewios (and some drive-by changes) (flutter#17593)
b582d77 Roll src/third_party/skia 0066adefa97d..c66cd987f7c0 (4 commits) (flutter#18206)
5e7d6d0 Roll src/third_party/skia edea19858ccc..0066adefa97d (3 commits) (flutter#18203)
88b9d42 Remove the global engine entry timestamp (flutter#18182)
0dffdd5 Roll src/third_party/dart e86e4d61834a..ce62ad2e8b40 (13 commits) (flutter#18201)
56fe6d2 Roll src/third_party/skia 2871ab0727bf..edea19858ccc (3 commits) (flutter#18198)
bcdf991 Fixed ChildSceneLayer elevation issue on Fuchsia. (flutter#18144)
ede658e [profiling] CPU Profiling support for iOS (flutter#18087)
d043923 Roll src/third_party/skia e3d1de7c5281..2871ab0727bf (1 commits) (flutter#18197)
807f191 Roll src/third_party/dart 733153eb517c..e86e4d61834a (6 commits) (flutter#18195)
fe3f8df Roll src/third_party/skia 3b2db26c59d6..e3d1de7c5281 (4 commits) (flutter#18192)
34b0629 Roll fuchsia/sdk/core/mac-amd64 from jMJqf... to 1MVsE... (flutter#18194)
e9b2afe Roll fuchsia/sdk/core/linux-amd64 from RpHTv... to MhpFP... (flutter#18191)
35fa006 Roll src/third_party/skia 88d04cb51acf..3b2db26c59d6 (1 commits) (flutter#18190)
e54bb9e Roll src/third_party/dart 4da5b40fb6dc..733153eb517c (23 commits) (flutter#18188)
@a-siva a-siva mentioned this pull request May 8, 2020
Closed
a-siva added a commit to a-siva/flutter that referenced this pull request May 8, 2020
@a-siva
Manual roll of engine 7e205b3...3953c3c
ec94772 
7e205b3 Roll src/fuchsia/sdk/mac from 1MVsE... to 4MCVP... (flutter#18217)
9193d8f Roll src/third_party/skia 0dc207f836da..a14084ba1b41 (3 commits) (flutter#18219)
403931f Add FlValue (flutter#18185)
46a6d96 [SkParagraph] Copy text height behavior to the Skia paragraph style (flutter#18178)
e7ee47d [web] Implement matrix parameter for linear gradient (flutter#18208)
28d9985 Reland again "Remove layer integral offset snapping flutter#17112" (flutter#18160)
5e361f5 Roll src/third_party/skia c66cd987f7c0..0dc207f836da (5 commits) (flutter#18212)
716dbf0 Refactor GLFW embedding to support headless mode (flutter#18205)
23cca32 Manual Roll of Dart 39e0e75fcf...ce62ad2e8b (flutter#18211)
15f72b8 Support EventChannel C++ plugin API for Linux/Windows (flutter#17015)
e5a7ca5 Handle leak of message handle when no engine present (flutter#18157)
d3bde19 add docs to platformviewios (and some drive-by changes) (flutter#17593)
b582d77 Roll src/third_party/skia 0066adefa97d..c66cd987f7c0 (4 commits) (flutter#18206)
5e7d6d0 Roll src/third_party/skia edea19858ccc..0066adefa97d (3 commits) (flutter#18203)
88b9d42 Remove the global engine entry timestamp (flutter#18182)
0dffdd5 Roll src/third_party/dart e86e4d61834a..ce62ad2e8b40 (13 commits) (flutter#18201)
56fe6d2 Roll src/third_party/skia 2871ab0727bf..edea19858ccc (3 commits) (flutter#18198)
bcdf991 Fixed ChildSceneLayer elevation issue on Fuchsia. (flutter#18144)
ede658e [profiling] CPU Profiling support for iOS (flutter#18087)
d043923 Roll src/third_party/skia e3d1de7c5281..2871ab0727bf (1 commits) (flutter#18197)
807f191 Roll src/third_party/dart 733153eb517c..e86e4d61834a (6 commits) (flutter#18195)
fe3f8df Roll src/third_party/skia 3b2db26c59d6..e3d1de7c5281 (4 commits) (flutter#18192)
34b0629 Roll fuchsia/sdk/core/mac-amd64 from jMJqf... to 1MVsE... (flutter#18194)
e9b2afe Roll fuchsia/sdk/core/linux-amd64 from RpHTv... to MhpFP... (flutter#18191)
35fa006 Roll src/third_party/skia 88d04cb51acf..3b2db26c59d6 (1 commits) (flutter#18190)
e54bb9e Roll src/third_party/dart 4da5b40fb6dc..733153eb517c (23 commits) (flutter#18188)
@a-siva a-siva mentioned this pull request May 8, 2020
Merged
a-siva added a commit that referenced this pull request May 8, 2020
@a-siva
Manual roll of engine 7e205b3...3953c3c (#56677)
7eff0a8 
7e205b3 Roll src/fuchsia/sdk/mac from 1MVsE... to 4MCVP... (#18217)
9193d8f Roll src/third_party/skia 0dc207f836da..a14084ba1b41 (3 commits) (#18219)
403931f Add FlValue (#18185)
46a6d96 [SkParagraph] Copy text height behavior to the Skia paragraph style (#18178)
e7ee47d [web] Implement matrix parameter for linear gradient (#18208)
28d9985 Reland again "Remove layer integral offset snapping #17112" (#18160)
5e361f5 Roll src/third_party/skia c66cd987f7c0..0dc207f836da (5 commits) (#18212)
716dbf0 Refactor GLFW embedding to support headless mode (#18205)
23cca32 Manual Roll of Dart 39e0e75fcf...ce62ad2e8b (#18211)
15f72b8 Support EventChannel C++ plugin API for Linux/Windows (#17015)
e5a7ca5 Handle leak of message handle when no engine present (#18157)
d3bde19 add docs to platformviewios (and some drive-by changes) (#17593)
b582d77 Roll src/third_party/skia 0066adefa97d..c66cd987f7c0 (4 commits) (#18206)
5e7d6d0 Roll src/third_party/skia edea19858ccc..0066adefa97d (3 commits) (#18203)
88b9d42 Remove the global engine entry timestamp (#18182)
0dffdd5 Roll src/third_party/dart e86e4d61834a..ce62ad2e8b40 (13 commits) (#18201)
56fe6d2 Roll src/third_party/skia 2871ab0727bf..edea19858ccc (3 commits) (#18198)
bcdf991 Fixed ChildSceneLayer elevation issue on Fuchsia. (#18144)
ede658e [profiling] CPU Profiling support for iOS (#18087)
d043923 Roll src/third_party/skia e3d1de7c5281..2871ab0727bf (1 commits) (#18197)
807f191 Roll src/third_party/dart 733153eb517c..e86e4d61834a (6 commits) (#18195)
fe3f8df Roll src/third_party/skia 3b2db26c59d6..e3d1de7c5281 (4 commits) (#18192)
34b0629 Roll fuchsia/sdk/core/mac-amd64 from jMJqf... to 1MVsE... (#18194)
e9b2afe Roll fuchsia/sdk/core/linux-amd64 from RpHTv... to MhpFP... (#18191)
35fa006 Roll src/third_party/skia 88d04cb51acf..3b2db26c59d6 (1 commits) (#18190)
e54bb9e Roll src/third_party/dart 4da5b40fb6dc..733153eb517c (23 commits) (#18188)
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexmarkov alexmarkov alexmarkov approved these changes
@mkustermann mkustermann Awaiting requested review from mkustermann
@a-siva a-siva Awaiting requested review from a-siva

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aam @Hixie @mkustermann @alexmarkov @googlebot