Repository navigation
Add scrollPadding property to DropdownMenuFormField - #184059
Hamidrzash wants to merge 4 commits into
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the scrollPadding property to DropdownMenuFormField, forwarding it to the underlying DropdownMenu widget. This change aligns the form field variant with the base widget. A corresponding test has been added to verify that the property is passed correctly, checking both the default and a custom value.
dkwingsmt
added
autosubmit
|
Hi @dkwingsmt the PR seems to be stuck on google testing...anything i should do? |
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/184059, because - The status or check suite Windows build_tests_3_9 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Thanks for your contribution! This PR has reached completion, however we're not able to merge this PR for the moment due to the Material/Cupertino code freeze (#184093). As soon as the decoupling is complete, we will post a way to port this PR to the new packages to land. In the meantime, I'll convert this PR to a draft and apply a label so that we can quickly find it when the freeze is lifted. |
dkwingsmt
added
waiting for code freeze
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Piinks
added
the
Decoupling: Not ready to port yet
|
I've marked this PR as not ready to port to flutter/packages yet. |
|
This PR is now ready to port over to flutter/packages! See instructions and guidance in #188444 Thank you! |
Piinks
added
Decoupling: Port to flutter/packages
|
Ported to flutter/packages: flutter/packages#12735 Closing this in favor of the new PR. |
…2735) Port of flutter/flutter#184059 to flutter/packages, per the instructions in flutter/flutter#188444. This change adds the `scrollPadding` property to `DropdownMenuFormField` and forwards it to the underlying `DropdownMenu`, bringing the form field variant into parity with `DropdownMenu`. ## Related Issues The original issue has been closed, but the following comment explains the remaining gap that this PR addresses: flutter/flutter#182890 (comment) > The merged PR [#183109](flutter/flutter#183109) covers `DropdownMenu`, but `DropdownMenuFormField` still doesn't expose `scrollPadding`. I'm opening a follow-up PR to address that remaining gap. [#184059](flutter/flutter#184059) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
4 participants
Follow-up to #183109, which added
scrollPaddingtoDropdownMenu.DropdownMenuFormFieldwrapsDropdownMenubut did not forward thescrollPaddingparameter. This PR adds it for consistency.Related Issues
Completes #182890
Pre-launch Checklist
///).