Repository navigation
[Impeller] Do not log an error when wrapping an empty texture as a TextureGLES - #184377
Merged
Merged
Conversation
…xtureGLES Wrapping an empty texture must produce a texture where IsValid returns false but should not write to the validation log. Fixes flutter#179572
github-actions
Bot
added
engine
7 of 10 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a unit test for empty textures in the GLES backend and removes a validation log for invalid texture descriptors. Feedback suggests that the validation log should only be suppressed when the texture size is empty to avoid hiding other legitimate configuration errors.
Comment on lines
144
to
146
| if (!GetTextureDescriptor().IsValid()) { | ||
| VALIDATION_LOG << "Invalid texture descriptor."; | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Removing the validation log entirely might hide other legitimate configuration errors in the TextureDescriptor (e.g., invalid mip counts or sample counts). To preserve useful debugging information for other types of invalid configurations while silencing it for empty textures, consider only skipping the log when the descriptor is invalid specifically due to being empty.
Suggested change
| if (!GetTextureDescriptor().IsValid()) { | |
| VALIDATION_LOG << "Invalid texture descriptor."; | |
| return; | |
| } | |
| if (!GetTextureDescriptor().IsValid()) { | |
| if (!GetTextureDescriptor().size.IsEmpty()) { | |
| VALIDATION_LOG << "Invalid texture descriptor."; | |
| } | |
| return; | |
| } |
References
- Error messages should be useful: Every error message is an opportunity to make someone love our product. (link)
jason-simmons
added
CICD
flutter-dashboard
Bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2026
…re as a TextureGLES (flutter/flutter#184377)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2026
…re as a TextureGLES (flutter/flutter#184377)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2026
…re as a TextureGLES (flutter/flutter#184377)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2026
…re as a TextureGLES (flutter/flutter#184377)
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 2, 2026
Roll Flutter from fb03253e32ce to 3d69471c0bf9 (69 revisions) flutter/flutter@fb03253...3d69471 2026-04-01 [email protected] Roll Dart SDK from 1308a3076402 to 043a2bfd56ff (1 revision) (flutter/flutter#184453) 2026-04-01 [email protected] Roll Skia from a657b5446209 to c2363c39c283 (2 revisions) (flutter/flutter#184448) 2026-04-01 [email protected] Fix layout overflowed in small screen in SensitiveContent's example (flutter/flutter#184179) 2026-04-01 [email protected] Roll Skia from e0b25041a5d5 to a657b5446209 (1 revision) (flutter/flutter#184445) 2026-04-01 [email protected] Roll Dart SDK from 75a089eb6bf9 to 1308a3076402 (3 revisions) (flutter/flutter#184444) 2026-04-01 [email protected] [AGP 9] Bumping KGP error minimum to 2.0.0 (flutter/flutter#184385) 2026-04-01 [email protected] [ Tool ] Migrate `flutter analyze` to use LSP (flutter/flutter#183785) 2026-04-01 [email protected] Adds uber sdf shader gradients with blend (flutter/flutter#184090) 2026-04-01 [email protected] Add bottom safe area padding to licenses package license page (flutter/flutter#182425) 2026-04-01 [email protected] Handle#6537 third grouped tests (flutter/flutter#183059) 2026-04-01 [email protected] Roll Skia from f37239a7a689 to e0b25041a5d5 (9 revisions) (flutter/flutter#184436) 2026-03-31 [email protected] [Impeller] Do not log an error when wrapping an empty texture as a TextureGLES (flutter/flutter#184377) 2026-03-31 [email protected] Remove the default_git_folder GN argument (flutter/flutter#184152) 2026-03-31 [email protected] Remove the cupertino_icons dependency from the spell_check integration test (flutter/flutter#184398) 2026-03-31 [email protected] Roll Fuchsia Linux SDK from pM94cWC9cSgao0CG0... to fV-JIWUt4FQGeDtEe... (flutter/flutter#184383) 2026-03-31 [email protected] Roll Dart SDK from eaeccf98848d to 75a089eb6bf9 (1 revision) (flutter/flutter#184379) 2026-03-31 [email protected] [web] Fix autofill in iOS 26 Safari (flutter/flutter#182024) 2026-03-31 [email protected] Roll Fuchsia GN SDK from SEfYx3xgueX3aFAY3... to JLBh4Z9PKsjIJcqDU... (flutter/flutter#184368) 2026-03-31 [email protected] [Windows] Restore and enable IAccessibleEx implementation (flutter/flutter#175406) 2026-03-31 [email protected] Revert "Even more awaits (#184042)" (flutter/flutter#184429) 2026-03-31 [email protected] Roll Skia from dfd8f8002800 to f37239a7a689 (2 revisions) (flutter/flutter#184374) 2026-03-31 [email protected] Remove workaround for fake impeller images in iOS simulator. (flutter/flutter#184264) 2026-03-31 [email protected] Even more awaits (flutter/flutter#184042) 2026-03-31 [email protected] Roll Packages from 582f0e7 to b04f3e5 (6 revisions) (flutter/flutter#184393) 2026-03-30 [email protected] Fixes a flake in reload shaders tests (flutter/flutter#184268) 2026-03-30 [email protected] Remove an obsolete script for setting up remote GDB sessions on Android devices (flutter/flutter#184357) 2026-03-30 [email protected] Roll Skia from 8dcde79fef2a to dfd8f8002800 (10 revisions) (flutter/flutter#184363) 2026-03-30 [email protected] Roll Dart SDK from 0aaccc3c8004 to eaeccf98848d (2 revisions) (flutter/flutter#184362) 2026-03-30 [email protected] [ Tool ] Remove `flutter running-apps` command (flutter/flutter#183742) 2026-03-30 [email protected] Roll pub packages (flutter/flutter#184045) 2026-03-30 [email protected] Rick roll triagers on/near April 1st (flutter/flutter#184355) 2026-03-30 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 5.5.0 to 6.0.0 in the all-github-actions group (flutter/flutter#184364) 2026-03-30 [email protected] fix(web): call ui.Picture.onDispose for the original picture only (flutter/flutter#184348) 2026-03-30 [email protected] Roll Skia from e001e6901e3b to 8dcde79fef2a (7 revisions) (flutter/flutter#184356) 2026-03-30 [email protected] [web] Make it safe to call dispose multiple times on a CkSurface (flutter/flutter#184270) 2026-03-30 [email protected] Roll HarfBuzz to 13.2.1 (flutter/flutter#184210) 2026-03-30 [email protected] web_ui: Remove unused parameters in a few places (flutter/flutter#183156) 2026-03-30 [email protected] Update TabBar documentation to clarify indicatorWeight behavior (flutter/flutter#184104) 2026-03-30 [email protected] Add title evaluation (flutter/flutter#184084) 2026-03-30 [email protected] fixes crash when invisible semantics nodes dropped from semantics tree (flutter/flutter#184226) 2026-03-30 [email protected] Roll Skia from cdaae3e3fdef to e001e6901e3b (4 revisions) (flutter/flutter#184345) 2026-03-30 [email protected] Roll Packages from 7ae082a to 582f0e7 (8 revisions) (flutter/flutter#184341) 2026-03-30 [email protected] Add alwaysSizeToContent argument to Overlay. (flutter/flutter#182009) 2026-03-30 [email protected] Roll Dart SDK from 598088a8a67f to 0aaccc3c8004 (1 revision) (flutter/flutter#184331) 2026-03-30 [email protected] Roll Skia from 6d7ade938643 to cdaae3e3fdef (2 revisions) (flutter/flutter#184329) 2026-03-30 [email protected] Roll Fuchsia Linux SDK from EnoD6zNQebz4EYuLk... to pM94cWC9cSgao0CG0... (flutter/flutter#184323) ...
ahmedsameha1
pushed a commit
to ahmedsameha1/flutter
that referenced
this pull request
Apr 14, 2026
…xtureGLES (flutter#184377) Wrapping an empty texture must produce a texture where IsValid returns false but should not write to the validation log. Fixes flutter#179572
mbcorona
pushed a commit
to mbcorona/flutter
that referenced
this pull request
Apr 15, 2026
…xtureGLES (flutter#184377) Wrapping an empty texture must produce a texture where IsValid returns false but should not write to the validation log. Fixes flutter#179572
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11408) Roll Flutter from fb03253e32ce to 3d69471c0bf9 (69 revisions) flutter/flutter@fb03253...3d69471 2026-04-01 [email protected] Roll Dart SDK from 1308a3076402 to 043a2bfd56ff (1 revision) (flutter/flutter#184453) 2026-04-01 [email protected] Roll Skia from a657b5446209 to c2363c39c283 (2 revisions) (flutter/flutter#184448) 2026-04-01 [email protected] Fix layout overflowed in small screen in SensitiveContent's example (flutter/flutter#184179) 2026-04-01 [email protected] Roll Skia from e0b25041a5d5 to a657b5446209 (1 revision) (flutter/flutter#184445) 2026-04-01 [email protected] Roll Dart SDK from 75a089eb6bf9 to 1308a3076402 (3 revisions) (flutter/flutter#184444) 2026-04-01 [email protected] [AGP 9] Bumping KGP error minimum to 2.0.0 (flutter/flutter#184385) 2026-04-01 [email protected] [ Tool ] Migrate `flutter analyze` to use LSP (flutter/flutter#183785) 2026-04-01 [email protected] Adds uber sdf shader gradients with blend (flutter/flutter#184090) 2026-04-01 [email protected] Add bottom safe area padding to licenses package license page (flutter/flutter#182425) 2026-04-01 [email protected] Handle#6537 third grouped tests (flutter/flutter#183059) 2026-04-01 [email protected] Roll Skia from f37239a7a689 to e0b25041a5d5 (9 revisions) (flutter/flutter#184436) 2026-03-31 [email protected] [Impeller] Do not log an error when wrapping an empty texture as a TextureGLES (flutter/flutter#184377) 2026-03-31 [email protected] Remove the default_git_folder GN argument (flutter/flutter#184152) 2026-03-31 [email protected] Remove the cupertino_icons dependency from the spell_check integration test (flutter/flutter#184398) 2026-03-31 [email protected] Roll Fuchsia Linux SDK from pM94cWC9cSgao0CG0... to fV-JIWUt4FQGeDtEe... (flutter/flutter#184383) 2026-03-31 [email protected] Roll Dart SDK from eaeccf98848d to 75a089eb6bf9 (1 revision) (flutter/flutter#184379) 2026-03-31 [email protected] [web] Fix autofill in iOS 26 Safari (flutter/flutter#182024) 2026-03-31 [email protected] Roll Fuchsia GN SDK from SEfYx3xgueX3aFAY3... to JLBh4Z9PKsjIJcqDU... (flutter/flutter#184368) 2026-03-31 [email protected] [Windows] Restore and enable IAccessibleEx implementation (flutter/flutter#175406) 2026-03-31 [email protected] Revert "Even more awaits (#184042)" (flutter/flutter#184429) 2026-03-31 [email protected] Roll Skia from dfd8f8002800 to f37239a7a689 (2 revisions) (flutter/flutter#184374) 2026-03-31 [email protected] Remove workaround for fake impeller images in iOS simulator. (flutter/flutter#184264) 2026-03-31 [email protected] Even more awaits (flutter/flutter#184042) 2026-03-31 [email protected] Roll Packages from 582f0e7 to b04f3e5 (6 revisions) (flutter/flutter#184393) 2026-03-30 [email protected] Fixes a flake in reload shaders tests (flutter/flutter#184268) 2026-03-30 [email protected] Remove an obsolete script for setting up remote GDB sessions on Android devices (flutter/flutter#184357) 2026-03-30 [email protected] Roll Skia from 8dcde79fef2a to dfd8f8002800 (10 revisions) (flutter/flutter#184363) 2026-03-30 [email protected] Roll Dart SDK from 0aaccc3c8004 to eaeccf98848d (2 revisions) (flutter/flutter#184362) 2026-03-30 [email protected] [ Tool ] Remove `flutter running-apps` command (flutter/flutter#183742) 2026-03-30 [email protected] Roll pub packages (flutter/flutter#184045) 2026-03-30 [email protected] Rick roll triagers on/near April 1st (flutter/flutter#184355) 2026-03-30 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 5.5.0 to 6.0.0 in the all-github-actions group (flutter/flutter#184364) 2026-03-30 [email protected] fix(web): call ui.Picture.onDispose for the original picture only (flutter/flutter#184348) 2026-03-30 [email protected] Roll Skia from e001e6901e3b to 8dcde79fef2a (7 revisions) (flutter/flutter#184356) 2026-03-30 [email protected] [web] Make it safe to call dispose multiple times on a CkSurface (flutter/flutter#184270) 2026-03-30 [email protected] Roll HarfBuzz to 13.2.1 (flutter/flutter#184210) 2026-03-30 [email protected] web_ui: Remove unused parameters in a few places (flutter/flutter#183156) 2026-03-30 [email protected] Update TabBar documentation to clarify indicatorWeight behavior (flutter/flutter#184104) 2026-03-30 [email protected] Add title evaluation (flutter/flutter#184084) 2026-03-30 [email protected] fixes crash when invisible semantics nodes dropped from semantics tree (flutter/flutter#184226) 2026-03-30 [email protected] Roll Skia from cdaae3e3fdef to e001e6901e3b (4 revisions) (flutter/flutter#184345) 2026-03-30 [email protected] Roll Packages from 7ae082a to 582f0e7 (8 revisions) (flutter/flutter#184341) 2026-03-30 [email protected] Add alwaysSizeToContent argument to Overlay. (flutter/flutter#182009) 2026-03-30 [email protected] Roll Dart SDK from 598088a8a67f to 0aaccc3c8004 (1 revision) (flutter/flutter#184331) 2026-03-30 [email protected] Roll Skia from 6d7ade938643 to cdaae3e3fdef (2 revisions) (flutter/flutter#184329) 2026-03-30 [email protected] Roll Fuchsia Linux SDK from EnoD6zNQebz4EYuLk... to pM94cWC9cSgao0CG0... (flutter/flutter#184323) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping an empty texture must produce a texture where IsValid returns false but should not write to the validation log.
Fixes #179572