Skip to content

Revert "Unpin sdk package dependencies" - #185186

Merged
loic-sharma merged 1 commit into
flutter:masterfrom
flutteractionsbot:revert-184821-1776386461
Apr 17, 2026
Merged

loic-sharma merged 1 commit into
flutter:masterfrom
flutteractionsbot:revert-184821-1776386461

Conversation

@flutteractionsbot

Copy link
Copy Markdown
Contributor

Reverts: Unpin sdk package dependencies

Initiated by: @loic-sharma

Reason for reverting: this appears to have broken the tree.

Original PR Author: @sigurdm

Reviewed By: @stuartmorgan-g

The original PR description is provided below:

Fixes #158050
Design: https://flutter.dev/go/unpin-flutter-sdk-dependencies

test_api and matcher are not unpinned, as they are still depended upon with src-imports making unpinning unsound.

material_color_utilities is also not unpinned yet, see the design doc for discussion.

@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) labels Apr 17, 2026
@loic-sharma loic-sharma added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Apr 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request unpins several dependencies across multiple pubspec.yaml files, including packages/flutter/pubspec.yaml, packages/flutter_localizations/pubspec.yaml, packages/flutter_test/pubspec.yaml, and the root pubspec.yaml. It replaces version ranges with fixed versions for packages such as characters, collection, meta, vector_math, intl, path, fake_async, clock, stack_trace, leak_tracker_flutter_testing, and stream_channel. Additionally, it removes outdated comments and updates the pubspec checksums. I have no feedback to provide.

@loic-sharma loic-sharma added the CICD Run CI/CD label Apr 17, 2026
@flutter-dashboard

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@loic-sharma
loic-sharma enabled auto-merge April 17, 2026 00:48
@cbracken
cbracken self-requested a review April 17, 2026 02:35

@cbracken cbracken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@loic-sharma
loic-sharma added this pull request to the merge queue Apr 17, 2026
Merged via the queue into flutter:master with commit 52ac7e6 Apr 17, 2026
86 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 17, 2026
flutter/flutter@31f1802...8e8a194

2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203)
2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199)
2026-04-17 [email protected] [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151)
2026-04-17 [email protected] Remove unused `FlutterRunArguments.java` file  (flutter/flutter#184160)
2026-04-17 [email protected] Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192)
2026-04-17 [email protected] [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913)
2026-04-17 [email protected] `AnimationStyle` methods (flutter/flutter#182333)
2026-04-17 [email protected] Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332)
2026-04-17 [email protected] Revert "Unpin sdk package dependencies" (flutter/flutter#185186)
2026-04-16 [email protected] Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995)
2026-04-16 [email protected] Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173)
2026-04-16 [email protected] Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033)
2026-04-16 [email protected] [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112)
2026-04-16 [email protected] Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159)
2026-04-16 [email protected] [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051)
2026-04-16 [email protected] [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991)
2026-04-16 [email protected] Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143)
2026-04-16 [email protected] Unpin sdk package dependencies (flutter/flutter#184821)
2026-04-16 [email protected] Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643)
2026-04-16 [email protected] Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141)
2026-04-16 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185166)
2026-04-16 [email protected] Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
sigurdm added a commit to sigurdm/flutter that referenced this pull request Apr 20, 2026
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…r#11523)

flutter/flutter@31f1802...8e8a194

2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203)
2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199)
2026-04-17 [email protected] [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151)
2026-04-17 [email protected] Remove unused `FlutterRunArguments.java` file  (flutter/flutter#184160)
2026-04-17 [email protected] Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192)
2026-04-17 [email protected] [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913)
2026-04-17 [email protected] `AnimationStyle` methods (flutter/flutter#182333)
2026-04-17 [email protected] Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332)
2026-04-17 [email protected] Revert "Unpin sdk package dependencies" (flutter/flutter#185186)
2026-04-16 [email protected] Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995)
2026-04-16 [email protected] Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173)
2026-04-16 [email protected] Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033)
2026-04-16 [email protected] [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112)
2026-04-16 [email protected] Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159)
2026-04-16 [email protected] [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051)
2026-04-16 [email protected] [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991)
2026-04-16 [email protected] Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143)
2026-04-16 [email protected] Unpin sdk package dependencies (flutter/flutter#184821)
2026-04-16 [email protected] Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643)
2026-04-16 [email protected] Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141)
2026-04-16 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185166)
2026-04-16 [email protected] Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@flutteractionsbot
flutteractionsbot deleted the revert-184821-1776386461 branch July 20, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests CICD Run CI/CD emergency Jump the queue; land PR in front of all others; only use for emergencies framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop pinning dependencies

3 participants