Skip to content

Reverts "[Windows] Propagate the enabled accessibility state (#184501)" - #186492

Merged
cbracken merged 1 commit into
masterfrom
revert_c6f7839321b36347d9972554e8185133c364595c
May 14, 2026
Merged

cbracken merged 1 commit into
masterfrom
revert_c6f7839321b36347d9972554e8185133c364595c

Conversation

@auto-submit

@auto-submit auto-submit Bot commented May 14, 2026 •

Copy link
Copy Markdown
Contributor

Reverts: #184501

Initiated by: cbracken

Reason for revert: breaks FlutterPlatformNodeDelegateMac.SelectableTextHasCorrectSemantics on macOS profile and release builds with segfault. Debug builds pass.

[ RUN      ] FlutterPlatformNodeDelegateMac.SelectableTextHasCorrectSemantics
embedder.cc (3203): 'FlutterEngineUpdateSemanticsEnabled' returned 'kInvalidArguments'. Invalid engine handle.
[ERROR:flutter/fml/backtrace.cc(108)] Caught signal SIGSEGV during program execution.
Frame 0: 0x101af1af4 testing::TestInfo::Run()
Frame 1: 0x101af28d0 testing::TestSuite::Run()
Frame 2: 0x101b02cfc testing::internal::UnitTestImpl::RunAllTests()
Frame 3: 0x101b025a0 testing::UnitTest::Run()
Frame 4: 0x100f2ffb0 main
Frame 5: 0x18f8eab98 start

Original PR Author: loic-peron-inetum-public

Reviewed By: {hannah-hyj, mattkae}

This change reverts the following previous change:
This PR propagates the enabled/diabled/read-only state of Flutter widgets to the Windows Accessiblity tree.

see #184559

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@auto-submit auto-submit Bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label May 14, 2026
@auto-submit
auto-submit Bot requested a review from a team as a code owner May 14, 2026 03:07
@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-windows Building on or for Windows specifically a: desktop Running on desktop team-windows Owned by the Windows platform team labels May 14, 2026
@auto-submit

auto-submit Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

auto label is removed for flutter/flutter/186492, Failed to enqueue flutter/flutter/186492 with HTTP 400: Pull request Required status check "Merge Queue Guard" is expected..

@auto-submit auto-submit Bot removed the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label May 14, 2026
@cbracken cbracken added emergency Jump the queue; land PR in front of all others; only use for emergencies CICD Run CI/CD labels May 14, 2026
@flutter-dashboard

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2026
@cbracken
cbracken added this pull request to the merge queue May 14, 2026
Merged via the queue into master with commit 0541913 May 14, 2026
36 of 53 checks passed
@cbracken
cbracken deleted the revert_c6f7839321b36347d9972554e8185133c364595c branch May 14, 2026 05:17
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 15, 2026
…11713)

Manual roll requested by [email protected]

flutter/flutter@23f6f58...0541913

2026-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Windows] Propagate the enabled accessibility state (#184501)" (flutter/flutter#186492)
2026-05-13 [email protected] [dev] Use super parameters in missed spots (flutter/flutter#186193)
2026-05-13 [email protected] [Windows] Propagate the enabled accessibility state (flutter/flutter#184501)
2026-05-13 [email protected] [flutter_tool] filter out MotionEvent-JNI warning spam from logcat (#174783) (flutter/flutter#186079)
2026-05-13 [email protected] Roll Packages from 93cbed6 to 2ec2236 (1 revision) (flutter/flutter#186464)
2026-05-13 [email protected] [web] Fix untriaged issues link label (flutter/flutter#186465)
2026-05-13 [email protected] [Impeller] Namespace user-supplied shaders to prevent entrypoint collisions (flutter/flutter#186332)
2026-05-13 [email protected] [flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task (flutter/flutter#184731)
2026-05-13 [email protected] Update the Flutter Gallery web app template files to support running with Wasm (flutter/flutter#186268)
2026-05-13 [email protected] [web] Use heap allocation for buffers that would consume too much space on the Wasm stack (flutter/flutter#186228)
2026-05-13 [email protected] Roll Skia from 56ca5896c0d9 to 27f7bba22600 (3 revisions) (flutter/flutter#186444)
2026-05-13 [email protected] Roll Fuchsia Linux SDK from z7ICmPtn4hspu02zk... to y6uQHA5xUN83IF395... (flutter/flutter#186442)
2026-05-13 [email protected] Roll Skia from 6385958d2feb to 56ca5896c0d9 (1 revision) (flutter/flutter#186441)
2026-05-13 [email protected] Roll Dart SDK from 9576691c37d8 to 8e30b88e4d5a (1 revision) (flutter/flutter#186429)
2026-05-13 [email protected] Roll Skia from 77a21bc723dc to 6385958d2feb (9 revisions) (flutter/flutter#186428)
2026-05-13 [email protected] Docs/improving docs for semantics UI lib (flutter/flutter#186125)
2026-05-12 [email protected] [Tool] Support glob patterns when parsing workspaces in FlutterProject (flutter/flutter#185715)
2026-05-12 [email protected] docs: fix overriden -> overridden in MediaQueryData dartdoc (flutter/flutter#186323)
2026-05-12 [email protected] [Test cross imports] No material in `test/foundation`, `test/gestures`, `test/semantics`, `test/services` (flutter/flutter#186144)
2026-05-12 [email protected] docs: fix "tha" -> "that" typo in widget_inspector_test comment (flutter/flutter#186322)
2026-05-12 [email protected] docs: Fix doubled-word typos in framework dartdoc (flutter/flutter#186319)
2026-05-12 [email protected] Roll pub packages (flutter/flutter#186418)
2026-05-12 [email protected] Bumped required mediatek vender sdk version. (flutter/flutter#186405)
2026-05-12 [email protected] Make DeepLinkJsonFromManifestTask Gradle task build cacheable (flutter/flutter#185903)
2026-05-12 [email protected] Harden dev tooling scripts against command injection and log leaks (flutter/flutter#186076)
2026-05-12 [email protected] Roll pub packages (flutter/flutter#186274)
2026-05-12 [email protected] [Flutter GPU] Allow allocating multi-mip textures and overwriting specific (mip, slice) levels (flutter/flutter#185890)
2026-05-12 [email protected] [web] Fix MenuAnchor dismiss when semantics enabled (flutter/flutter#183093)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…lutter#11713)

Manual roll requested by [email protected]

flutter/flutter@23f6f58...0541913

2026-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Windows] Propagate the enabled accessibility state (#184501)" (flutter/flutter#186492)
2026-05-13 [email protected] [dev] Use super parameters in missed spots (flutter/flutter#186193)
2026-05-13 [email protected] [Windows] Propagate the enabled accessibility state (flutter/flutter#184501)
2026-05-13 [email protected] [flutter_tool] filter out MotionEvent-JNI warning spam from logcat (#174783) (flutter/flutter#186079)
2026-05-13 [email protected] Roll Packages from 93cbed6 to 2ec2236 (1 revision) (flutter/flutter#186464)
2026-05-13 [email protected] [web] Fix untriaged issues link label (flutter/flutter#186465)
2026-05-13 [email protected] [Impeller] Namespace user-supplied shaders to prevent entrypoint collisions (flutter/flutter#186332)
2026-05-13 [email protected] [flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task (flutter/flutter#184731)
2026-05-13 [email protected] Update the Flutter Gallery web app template files to support running with Wasm (flutter/flutter#186268)
2026-05-13 [email protected] [web] Use heap allocation for buffers that would consume too much space on the Wasm stack (flutter/flutter#186228)
2026-05-13 [email protected] Roll Skia from 56ca5896c0d9 to 27f7bba22600 (3 revisions) (flutter/flutter#186444)
2026-05-13 [email protected] Roll Fuchsia Linux SDK from z7ICmPtn4hspu02zk... to y6uQHA5xUN83IF395... (flutter/flutter#186442)
2026-05-13 [email protected] Roll Skia from 6385958d2feb to 56ca5896c0d9 (1 revision) (flutter/flutter#186441)
2026-05-13 [email protected] Roll Dart SDK from 9576691c37d8 to 8e30b88e4d5a (1 revision) (flutter/flutter#186429)
2026-05-13 [email protected] Roll Skia from 77a21bc723dc to 6385958d2feb (9 revisions) (flutter/flutter#186428)
2026-05-13 [email protected] Docs/improving docs for semantics UI lib (flutter/flutter#186125)
2026-05-12 [email protected] [Tool] Support glob patterns when parsing workspaces in FlutterProject (flutter/flutter#185715)
2026-05-12 [email protected] docs: fix overriden -> overridden in MediaQueryData dartdoc (flutter/flutter#186323)
2026-05-12 [email protected] [Test cross imports] No material in `test/foundation`, `test/gestures`, `test/semantics`, `test/services` (flutter/flutter#186144)
2026-05-12 [email protected] docs: fix "tha" -> "that" typo in widget_inspector_test comment (flutter/flutter#186322)
2026-05-12 [email protected] docs: Fix doubled-word typos in framework dartdoc (flutter/flutter#186319)
2026-05-12 [email protected] Roll pub packages (flutter/flutter#186418)
2026-05-12 [email protected] Bumped required mediatek vender sdk version. (flutter/flutter#186405)
2026-05-12 [email protected] Make DeepLinkJsonFromManifestTask Gradle task build cacheable (flutter/flutter#185903)
2026-05-12 [email protected] Harden dev tooling scripts against command injection and log leaks (flutter/flutter#186076)
2026-05-12 [email protected] Roll pub packages (flutter/flutter#186274)
2026-05-12 [email protected] [Flutter GPU] Allow allocating multi-mip textures and overwriting specific (mip, slice) levels (flutter/flutter#185890)
2026-05-12 [email protected] [web] Fix MenuAnchor dismiss when semantics enabled (flutter/flutter#183093)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
cbracken added a commit to cbracken/flutter that referenced this pull request Aug 4, 2026
Relands flutter#184501, which was reverted in flutter#186492 because mapping read-only
text fields to Role::kTextField caused the macOS embedder to instantiate a
FlutterTextPlatformNode for them, producing detached accessibility elements
and test crashes.

That macOS issue is now fixed by the earlier commits in this stack (the
static-text platform-node handling and the AX restriction mapping), so the
remaining pieces of flutter#184501 can safely reland:

  * common: read-only text fields now map to Role::kTextField.
  * windows: ENABLED_CHANGED / READONLY_CHANGED are dispatched as MSAA
    kStateChanged events, and AXPlatformNodeWin raises the corresponding
    UIA_IsEnabledPropertyId change.

The disabled/read-only restriction mapping and its bridge tests landed in
the preceding stack commit and are intentionally not duplicated here.
cbracken added a commit to cbracken/flutter that referenced this pull request Aug 4, 2026
Relands flutter#184501, which was reverted in flutter#186492 because mapping read-only
text fields to Role::kTextField caused the macOS embedder to instantiate
a FlutterTextPlatformNode for them, producing detached accessibility
elements and test crashes.

The underlying macOS issue is now fixed by flutter#190330 and flutter#190353. This
relands the remaining bits of flutter#184501. In the common bits of the bridge,
read-only text fields now map to `Role::kTextField`. In the Windows
implementation `ENABLED_CHANGED` and `READONLY_CHANGED` are dispatched
as MSAA `kStateChanged` events and `AXPlatformNodeWin` now raises the
corresponding `UIA_IsEnabledPropertyId` change.

Issue: flutter#184559
cbracken added a commit to cbracken/flutter that referenced this pull request Aug 4, 2026
Relands flutter#184501, which was reverted in flutter#186492 because mapping read-only
text fields to Role::kTextField caused the macOS embedder to instantiate
a FlutterTextPlatformNode for them, producing detached accessibility
elements and test crashes.

The underlying macOS issue is now fixed by flutter#190330 and flutter#190353. This
relands the remaining bits of flutter#184501. In the common bits of the bridge,
read-only text fields now map to `Role::kTextField`. In the Windows
implementation `ENABLED_CHANGED` and `READONLY_CHANGED` are dispatched
as MSAA `kStateChanged` events and `AXPlatformNodeWin` now raises the
corresponding `UIA_IsEnabledPropertyId` change.

Issue: flutter#184559
pull Bot pushed a commit to AbhiShake1/flutter that referenced this pull request Aug 5, 2026
Relands flutter#184501, which was reverted in flutter#186492 because mapping read-only
text fields to Role::kTextField caused the macOS embedder to instantiate
a FlutterTextPlatformNode for them, producing detached accessibility
elements and test crashes.

The underlying macOS issue is now fixed by flutter#190330 and flutter#190353. This
relands the remaining bits of flutter#184501. In the common bits of the bridge,
read-only text fields now map to `Role::kTextField`. In the Windows
implementation `ENABLED_CHANGED` and `READONLY_CHANGED` are dispatched
as MSAA `kStateChanged` events and `AXPlatformNodeWin` now raises the
corresponding `UIA_IsEnabledPropertyId` change.

Fixes: flutter#184559


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: desktop Running on desktop CICD Run CI/CD emergency Jump the queue; land PR in front of all others; only use for emergencies engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically team-windows Owned by the Windows platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants