Skip to content

Remove routes_transition_test from widgets - #186620

Draft
Wreos wants to merge 5 commits into
flutter:masterfrom
Wreos:move-routes-transition-test
Draft

Remove routes_transition_test from widgets#186620
Wreos wants to merge 5 commits into
flutter:masterfrom
Wreos:move-routes-transition-test

Conversation

@Wreos

@Wreos Wreos commented May 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Removes routes_transition_test.dart from flutter/flutter. The test will be added to material_ui in flutter/packages in this pr

Part of #177414.
Related to #188444.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@Wreos Wreos mentioned this pull request May 16, 2026
Closed
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages f: routes Navigator, Router, and related APIs. labels May 16, 2026
@google-cla

google-cla Bot commented May 16, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Wreos
Wreos marked this pull request as ready for review May 16, 2026 11:06
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 16, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the test file packages/flutter/test/material/routes_transition_test.dart. No review comments were provided, and I have no feedback to provide.

@Piinks Piinks added Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. Decoupling: Split PR The PR will need to be split to separate Material & Cupertino changes labels Jun 24, 2026
@Piinks

Piinks commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

I've marked this PR as not ready to port to flutter/packages yet.
We'll provide instructions to move this change over to material_ui/cupertino_ui once ready to receive PRs. Thank you!

The changes not in the material or cupertino libraries will remain here, so this will in the future require splitting into 2 PRs. One that removes the tests from widgets, and another that add the tests in material_ui in flutter/packages.

@Wreos

Wreos commented Jun 27, 2026

Copy link
Copy Markdown
Author

I've marked this PR as not ready to port to flutter/packages yet. We'll provide instructions to move this change over to material_ui/cupertino_ui once ready to receive PRs. Thank you!

The changes not in the material or cupertino libraries will remain here, so this will in the future require splitting into 2 PRs. One that removes the tests from widgets, and another that add the tests in material_ui in flutter/packages.

Hello, @Piinks :) Big thanks for the feedback.

@Piinks
Piinks requested review from QuncCccccc and elliette July 15, 2026 21:13
elliette
elliette previously approved these changes Jul 17, 2026
View reviewed changes

@elliette elliette left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM! As mentioned above, this PR will need to be ported over to the new packages repo. We will provide more details when that repo is ready to accept contributions.

@QuncCccccc QuncCccccc added the CICD Run CI/CD label Jul 17, 2026
QuncCccccc
QuncCccccc previously approved these changes Jul 17, 2026
View reviewed changes

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution:)

@Wreos @QuncCccccc
Move routes_transition_test to material
a8b56aa 
The routes_transition_test suite exercises MaterialApp,
MaterialPageRoute, Scaffold, TextButton, and Material page
transition builders throughout the file.

Move the test from packages/flutter/test/widgets to
packages/flutter/test/material so the widgets test directory no
longer carries a material-specific test.

Part of flutter#177414
@QuncCccccc
QuncCccccc force-pushed the move-routes-transition-test branch from 89a7c2d to a8b56aa Compare July 17, 2026 22:05
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Jul 17, 2026
@QuncCccccc QuncCccccc added the CICD Run CI/CD label Jul 17, 2026
@dkwingsmt
dkwingsmt marked this pull request as draft July 22, 2026 18:16
@dkwingsmt dkwingsmt added the waiting for code freeze This PR is waiting for a code freeze to resolve. label Jul 22, 2026
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

This pull request contains changes to Material or Cupertino, which are currently frozen in this repository.

Changes should be made in material_ui and/or cupertino_ui in the flutter/packages repository.

Please refer to #188444 for instructions.

@Wreos
Wreos dismissed stale reviews from elliette and QuncCccccc via 1886b4d August 26, 2026 09:33
@github-actions github-actions Bot removed the p: material_ui material_ui package in flutter/packages label Aug 26, 2026
@Wreos Wreos changed the title Move routes_transition_test to material Remove routes_transition_test from widgets Aug 26, 2026
@Wreos Wreos mentioned this pull request Aug 26, 2026
Merged
11 tasks done
@Wreos

Wreos commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

@Piinks I checked #188444, and it looks like I can start helping with the migration. 🙂
I updated this PR so that it only removes the test from flutter/flutter.

Once it is merged and reaches the Flutter stable channel, could you help review this PR that adds the test to material_ui? Is that the correct process? :)

@Piinks

Piinks commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This change in the widgets/ library does not affect material_ui, so the material_ui change does not need to wait for this to roll to stable.

@Piinks Piinks removed Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. Decoupling: Split PR The PR will need to be split to separate Material & Cupertino changes waiting for code freeze This PR is waiting for a code freeze to resolve. labels Aug 26, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Sep 1, 2026
@Wreos
[material_ui] Port routes_transition_test to material_ui (#12634)
3f00bb1 
Ports routes_transition_test.dart from flutter/flutter to material_ui. 
The original test is removed separately in flutter/flutter#186620 and added here to preserve its Material navigation transition coverage.

Part of [flutter/flutter#177414.](flutter/flutter#188444)
Related to [flutter/flutter#188444.](flutter/flutter#186620)

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@Wreos @victorsanni
[material_ui] Port routes_transition_test to material_ui (flutter#12634)
34be70c 
Ports routes_transition_test.dart from flutter/flutter to material_ui. 
The original test is removed separately in flutter/flutter#186620 and added here to preserve its Material navigation transition coverage.

Part of [flutter/flutter#177414.](flutter/flutter#188444)
Related to [flutter/flutter#188444.](flutter/flutter#186620)

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@Wreos @victorsanni
[material_ui] Port routes_transition_test to material_ui (flutter#12634)
ea9073f 
Ports routes_transition_test.dart from flutter/flutter to material_ui. 
The original test is removed separately in flutter/flutter#186620 and added here to preserve its Material navigation transition coverage.

Part of [flutter/flutter#177414.](flutter/flutter#188444)
Related to [flutter/flutter#188444.](flutter/flutter#186620)

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliette elliette elliette left review comments
@QuncCccccc QuncCccccc QuncCccccc left review comments
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

Test cross-imports Review Queue
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Wreos @Piinks @elliette @QuncCccccc @dkwingsmt @alpesh76