Repository navigation
Clarify precache enabled platforms help - #186878
Merged
auto-submit[bot] merged 1 commit intoMay 26, 2026
Merged
Conversation
github-actions
Bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the PrecacheCommand description to clarify how platform artifacts are selected based on host and Flutter configuration and adds a unit test to verify this description. Feedback indicates that the flutter config command does not support a --list flag, so the description and test expectations should be updated to remove the incorrect flag.
Contributor
Author
|
Thanks for the check. I verified this against the current tool source and tests: |
chingjun
approved these changes
May 26, 2026
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/186878, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
bkonyi
approved these changes
May 26, 2026
flutter-dashboard
Bot
removed
the
autosubmit
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 27, 2026
flutter/flutter@f3a4b98...c8f2f16 2026-05-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Flutter GPU] Add explicit draw counts (#186639)" (flutter/flutter#187170) 2026-05-27 [email protected] Roll Dart SDK from 7dcea971af6b to f3db7b7d9801 (2 revisions) (flutter/flutter#187144) 2026-05-27 [email protected] [Flutter GPU] Add explicit draw counts (flutter/flutter#186639) 2026-05-27 [email protected] Roll Skia from f9db7748563e to fa944af10f91 (1 revision) (flutter/flutter#187139) 2026-05-27 [email protected] [Flutter GPU] Flutter GPU ShaderLibrary in-place reload for shader hot reload (flutter/flutter#186793) 2026-05-27 [email protected] Roll Skia from a692cbf38952 to f9db7748563e (8 revisions) (flutter/flutter#187135) 2026-05-27 [email protected] Use local semantics tester in Material button tests (flutter/flutter#186667) 2026-05-27 [email protected] Filter out `a: text input` from `team-framework` PR triage (flutter/flutter#187129) 2026-05-27 [email protected] [Engine] Fix silent buffer mismatch bug in FML Win32 CommandLineFromPlatform (flutter/flutter#187120) 2026-05-27 [email protected] examples: Remove unused parameters (flutter/flutter#185819) 2026-05-27 [email protected] Remove another `String.valueOf` (flutter/flutter#186628) 2026-05-27 [email protected] Print trace when skipping flavor-specific and platform-specific assets (flutter/flutter#187045) 2026-05-26 [email protected] Fix `InteractiveViewer` memory leak from undisposed `CurvedAnimation`s (flutter/flutter#185826) 2026-05-26 [email protected] Fix AccessibilityBridge startup crash on vendor-modified Android (flutter/flutter#184630) 2026-05-26 [email protected] Update data driven fixes docs (flutter/flutter#186217) 2026-05-26 [email protected] Add more 0x0 size tests part10 (flutter/flutter#186201) 2026-05-26 [email protected] Disable spell check for obscured text (flutter/flutter#186329) 2026-05-26 [email protected] [iOS] Migrate VSyncClient and DisplayLinkManager to Swift (flutter/flutter#187001) 2026-05-26 [email protected] [flutter_tools, devicelab] Add safety filesystem guard to tests (flutter/flutter#186748) 2026-05-26 [email protected] Roll Fuchsia Linux SDK from Itd2Jq_ZIABH2rW7B... to k9EizfEGJO4WwQN9-... (flutter/flutter#187115) 2026-05-26 [email protected] Roll Dart SDK from 00e625453c43 to 7dcea971af6b (1 revision) (flutter/flutter#187117) 2026-05-26 [email protected] Remove use of deprecated copy_trees. (flutter/flutter#187091) 2026-05-26 [email protected] Use resolved implementation plugins with SwiftPM (flutter/flutter#187097) 2026-05-26 [email protected] Roll Skia from 27a819894f7c to a692cbf38952 (3 revisions) (flutter/flutter#187109) 2026-05-26 [email protected] Roll Packages from 69cf959 to fc795e5 (4 revisions) (flutter/flutter#187114) 2026-05-26 [email protected] Handle simctl process exceptions during discovery (flutter/flutter#186501) 2026-05-26 [email protected] Clarify precache enabled platforms help (flutter/flutter#186878) 2026-05-26 [email protected] [tool] Refactor artifacts.dart to use enhanced enums and reduce duplication (flutter/flutter#187063) 2026-05-26 [email protected] Build script updates for syncing engine sources and building artifacts on linux-arm64 (flutter/flutter#186917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11795) flutter/flutter@f3a4b98...c8f2f16 2026-05-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Flutter GPU] Add explicit draw counts (#186639)" (flutter/flutter#187170) 2026-05-27 [email protected] Roll Dart SDK from 7dcea971af6b to f3db7b7d9801 (2 revisions) (flutter/flutter#187144) 2026-05-27 [email protected] [Flutter GPU] Add explicit draw counts (flutter/flutter#186639) 2026-05-27 [email protected] Roll Skia from f9db7748563e to fa944af10f91 (1 revision) (flutter/flutter#187139) 2026-05-27 [email protected] [Flutter GPU] Flutter GPU ShaderLibrary in-place reload for shader hot reload (flutter/flutter#186793) 2026-05-27 [email protected] Roll Skia from a692cbf38952 to f9db7748563e (8 revisions) (flutter/flutter#187135) 2026-05-27 [email protected] Use local semantics tester in Material button tests (flutter/flutter#186667) 2026-05-27 [email protected] Filter out `a: text input` from `team-framework` PR triage (flutter/flutter#187129) 2026-05-27 [email protected] [Engine] Fix silent buffer mismatch bug in FML Win32 CommandLineFromPlatform (flutter/flutter#187120) 2026-05-27 [email protected] examples: Remove unused parameters (flutter/flutter#185819) 2026-05-27 [email protected] Remove another `String.valueOf` (flutter/flutter#186628) 2026-05-27 [email protected] Print trace when skipping flavor-specific and platform-specific assets (flutter/flutter#187045) 2026-05-26 [email protected] Fix `InteractiveViewer` memory leak from undisposed `CurvedAnimation`s (flutter/flutter#185826) 2026-05-26 [email protected] Fix AccessibilityBridge startup crash on vendor-modified Android (flutter/flutter#184630) 2026-05-26 [email protected] Update data driven fixes docs (flutter/flutter#186217) 2026-05-26 [email protected] Add more 0x0 size tests part10 (flutter/flutter#186201) 2026-05-26 [email protected] Disable spell check for obscured text (flutter/flutter#186329) 2026-05-26 [email protected] [iOS] Migrate VSyncClient and DisplayLinkManager to Swift (flutter/flutter#187001) 2026-05-26 [email protected] [flutter_tools, devicelab] Add safety filesystem guard to tests (flutter/flutter#186748) 2026-05-26 [email protected] Roll Fuchsia Linux SDK from Itd2Jq_ZIABH2rW7B... to k9EizfEGJO4WwQN9-... (flutter/flutter#187115) 2026-05-26 [email protected] Roll Dart SDK from 00e625453c43 to 7dcea971af6b (1 revision) (flutter/flutter#187117) 2026-05-26 [email protected] Remove use of deprecated copy_trees. (flutter/flutter#187091) 2026-05-26 [email protected] Use resolved implementation plugins with SwiftPM (flutter/flutter#187097) 2026-05-26 [email protected] Roll Skia from 27a819894f7c to a692cbf38952 (3 revisions) (flutter/flutter#187109) 2026-05-26 [email protected] Roll Packages from 69cf959 to fc795e5 (4 revisions) (flutter/flutter#187114) 2026-05-26 [email protected] Handle simctl process exceptions during discovery (flutter/flutter#186501) 2026-05-26 [email protected] Clarify precache enabled platforms help (flutter/flutter#186878) 2026-05-26 [email protected] [tool] Refactor artifacts.dart to use enhanced enums and reduce duplication (flutter/flutter#187063) 2026-05-26 [email protected] Build script updates for syncing engine sources and building artifacts on linux-arm64 (flutter/flutter#186917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
Fixes flutter#144656 This clarifies `flutter precache --help` so "currently enabled platforms" is tied to the current host and Flutter configuration, and points users at `flutter config --list` for explicit platform settings. Verification: - `./bin/flutter test packages/flutter_tools/test/commands.shard/hermetic/precache_test.dart` - `./bin/flutter test packages/flutter_tools/test/general.shard/args_test.dart` - `./bin/flutter analyze packages/flutter_tools/lib/src/commands/precache.dart packages/flutter_tools/test/commands.shard/hermetic/precache_test.dart` - `git diff --check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144656
This clarifies
flutter precache --helpso "currently enabled platforms" is tied to the current host and Flutter configuration, and points users atflutter config --listfor explicit platform settings.Verification:
./bin/flutter test packages/flutter_tools/test/commands.shard/hermetic/precache_test.dart./bin/flutter test packages/flutter_tools/test/general.shard/args_test.dart./bin/flutter analyze packages/flutter_tools/lib/src/commands/precache.dart packages/flutter_tools/test/commands.shard/hermetic/precache_test.dartgit diff --check