Repository navigation
Conversation
This is being done so that users will be encouraged to migrate to material_ui.
github-actions
Bot
added
framework
|
I tested the new The Material library replacement transform currently uses I opened a small stacked PR against this branch: justinmc#149 That changes the keys to The remaining gap I found is export directives: |
Fix Material library replacement fix-data keys
|
I've merged justinmc#149, thanks! |
Based on flutter#186915 This adds fix data for the migration to the new design packages, material_ui and cupertino_ui. I cannot adds tests for it currently, because there is no analyzer trigger without the deprecation. The Dart team is working to add the ability to manually trigger the fix in https://dart-review.googlesource.com/c/sdk/+/522020 Once these changes land, we can test it out. Both the Dart change and this one should be cherry picked to the latest release that was cut yesterday. Part of flutter#172935 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
Flyby for when this is returned to: we have to deprecate what we decoupled in flutter_localizations as well |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request deprecates the material library in favor of the material_ui package and updates the corresponding test expectations. Feedback was provided to update the deprecation version format from v3.47 to v3.47.0 to comply with Flutter's deprecation policy and avoid automated test failures.
| @Deprecated( | ||
| 'Use the `material_ui` package instead. ' | ||
| 'This feature was deprecated after v3.47.', | ||
| ) |
There was a problem hiding this comment.
Flutter's deprecation policy and automated tests require the deprecation version to follow the vMajor.Minor.Patch format (three numbers separated by dots). Please update v3.47 to v3.47.0 to avoid test failures.
| @Deprecated( | |
| 'Use the `material_ui` package instead. ' | |
| 'This feature was deprecated after v3.47.', | |
| ) | |
| @Deprecated( | |
| 'Use the "material_ui" package instead. ' | |
| 'This feature was deprecated after v3.47.0.', | |
| ) |
|
Closing in favor of #192957 |
|
This pull request contains changes to Material or Cupertino, which are currently frozen in this repository. Changes should be made in Please refer to #188444 for instructions. |
3 participants
Material is moving to material_ui and Cupertino is moving to cupertino_ui. Once we're ready for those packages to be used, we should deprecate the old libraries so that users receive a deprecation warning and are encouraged to migrate. This PR should not be merged until then.
#172942
TODOs