Repository navigation
Remove redundant disabledBorder check in InputDecorationThemeData - #187556
Closed
MohanadAbdallah-mv wants to merge 2 commits into
Closed
MohanadAbdallah-mv wants to merge 2 commits into
MohanadAbdallah-mv wants to merge 2 commits into
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Renzo-Olivares
self-requested a review
June 8, 2026 22:27
Renzo-Olivares
approved these changes
Jun 8, 2026
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for the quick fix!
Renzo-Olivares
added
CICD
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/187556, because - The status or check suite Check Code Freeze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
Since this PR is ready to land but we are still waiting for the code freeze, I'm going to mark this PR as draft for now. Once the decoupling has done, we can copy the change and create another PR over there:)! Thanks! |
QuncCccccc
added
the
waiting for code freeze
QuncCccccc
marked this pull request as draft
June 10, 2026 02:38
Piinks
added
the
Decoupling: Not ready to port yet
Contributor
|
I've marked this PR as not ready to port to flutter/packages yet. |
9 of 11 tasks
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 16, 2026
…nThemeData (#12797) Removes a duplicate condition in the == operator of InputDecorationThemeData. The check other.disabledBorder == disabledBorder appeared twice ,This was noticed during the review of flutter/flutter#183582. No behavior change since the duplicate was always true when reached. *List which issues are fixed by this PR. You must list at least one issue.* Port of flutter/flutter#187556 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Contributor
|
This can now be ported over to the flutter/packages repo in material_ui! |
Piinks
added
Decoupling: Port to flutter/packages
Contributor
|
This has been ported over to material_ui and the PR has landed flutter/packages#12797. So closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a duplicate condition in the
==operator ofInputDecorationThemeData.The check
other.disabledBorder == disabledBorderappeared twice ,This was noticed during the review of #183582.No behavior change since the duplicate was always true when reached.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
#183582 (comment)
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.