Repository navigation
Implement version code overrides for split ABIs - #187742
auto-submit[bot] merged 11 commits into
Conversation
github-actions
Bot
added
platform-android
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Gradle property, force-version-code-ignoring-abi, allowing developers to bypass ABI-specific version code overrides during Flutter builds. Feedback on the changes highlights several critical issues in the integration tests, including a missing comma leading to implicit string concatenation, a misplaced closing brace that prematurely terminates the main function, and an incorrect aapt command for extracting the APK version code. Additionally, a relative import should be replaced with a package import to adhere to the style guide.
There was a problem hiding this comment.
Code Review
This pull request introduces a new Gradle property force-version-code-ignoring-abi to allow forcing the version code while ignoring the ABI split during Flutter builds, and adds an integration test to verify this behavior. Feedback on the integration test points out compatibility issues on Windows environments, such as incorrect path escaping, carriage return handling, missing directory checks, and the wrong executable name for aapt.
|
I still get a test failure. Not sure whether that is a wrong local setup (using wrong flutter), or a bug. I guess running in CI is easiest to check that. |
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Overall it seems fair to me, but the test needs to be adjusted to work on Windows.
looking at _checkLibIsInApk the other path changes don't seem necessary
|
Thanks for the review. The linked test looks like it creates the android directories from scratch. Based on the runner log I went with the simple binary renaming. Let's see how that goes |
_Description of what this PR is changing or adding, and why:_ As asked in a review of the linked pull request: This pull request updates the Android deployment documentation to explain how split APKs affect the version code and how to bypass this behavior during a build. _Issues fixed by this PR (if any):_ _PRs or commits this PR depends on (if any):_ - flutter/flutter#187742 ## Presubmit checklist - [x] If you are unwilling, or unable, to sign the CLA, even for a _tiny_, one-word PR, please file an issue instead of a PR. - [x] If this PR is not meant to land until a future stable release, mark it as draft with an explanation. - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style)—for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first-person pronouns). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Now that the tree is green again, could this get merged? |
gmackall
added
CICD
flutter-dashboard
Bot
removed
the
autosubmit
5 participants
closes #49544 by implementing a flag to force the flutter plugin to not run override the version code for split APIs.
More or less follows what #177753 did. The design should be sufficient to hook into custom build systems and doesn't do anything else.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.