Repository navigation
[CP-stable][ci] Increase test timeout for Mac_x64 build_tests shards - #188881
Conversation
…8804) Increase `test_timeout_secs` to `2700` (45 minutes) for all five `Mac_x64 build_tests` shards (`1_5` to `5_5`) in `.ci.yaml`. The default test timeout is 30 minutes. Shard `2_5` has been taking close to 29 minutes, leading to timeouts. Since test sharding distribution shuffles when tests are added/removed, all five shards have been updated. Setting `test_timeout_secs` to `2700` provides a 15-minute buffer before the global LUCI task timeout of 60 minutes, ensuring the test runner itself times out and prints diagnostics. Fixes flutter#188242
|
@reidbaker please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
autosubmit label was removed for flutter/flutter/188881, because - The status or check suite Mac_arm64 build_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
@bkonyi odd that the test we are extending the timeout on is failing with the shorter timeout during this cp https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20build_tests_2_5/4657/overview |
|
kicked off a rerun to hopfully have the test pass. I am worried that this wont work given the timeout issue is still showing up. |
8f9096d
into
flutter:flutter-3.44-candidate.0
…lutter#188881) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? flutter#188242 flutter#188872 ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping of production apps (the app crashes on launch). This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick. The `Mac_x64 build_tests` shards (especially shard `2_5`) on CI frequently time out because they take close to 29-30 minutes, exceeding the default 30-minute test timeout. This causes flaky test failures on release branches and blocks the CI/release pipeline. ### Changelog Description: Explain this cherry pick: * In one line that is accessible to most Flutter developers. * That describes the state prior to the fix. * That includes which platforms are impacted. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples. n/a non user facing ### Workaround: Is there a workaround for this issue? < Replace with workaround here > ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? run the post submit tests and see if the failures go away.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#188242
#188872
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.
The
Mac_x64 build_testsshards (especially shard2_5) on CI frequently time out because they take close to 29-30 minutes, exceeding the default 30-minute test timeout. This causes flaky test failures on release branches and blocks the CI/release pipeline.Changelog Description:
Explain this cherry pick:
See best practices for examples.
n/a non user facing
Workaround:
Is there a workaround for this issue?
< Replace with workaround here >
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
run the post submit tests and see if the failures go away.