Use devicectl for screenshots on Xcode 27, remove idevicescreenshot artifact by jmagman · Pull Request #189091 · flutter/flutter

jmagman · 2026-07-07T23:12:49Z

On Xcode 27 use devicectl device capture screenshot instead of idevicescreenshot, which stopped working a few years ago in iOS 17 / Xcode 15.

This will reach stable after Xcode 27 releases.

Add the devicectl device capture code for Xcode 27.
Change the < Xcode 27 fallback to toolExit with: "flutter screenshot requires Xcode 27 or higher." Since Xcode 15 is our minimum now as of Bump minimum required Xcode version to 15 and recommended to 16 #180531, idevicescreenshot doesn't work with any configuration with latest Flutter so there's no reason to keep around the fallbacks if < Xcode 27.
Remove _iMobileDevice.takeScreenshot and idevicescreenshot artifact.

Note I left in the run_verify_binaries_codesigned_tests check because the binary will still be shipping in the libimobiledevice tar ball until we remove it from the recipe.

flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart

Line 154 in cf9e8af

'artifacts/libimobiledevice/idevicescreenshot',

Related to #6118
Fixes #128598

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

jmagman · 2026-07-08T00:11:23Z

/gemini review

gemini-code-assist · 2026-07-08T00:14:30Z

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

jmagman · 2026-07-08T00:20:10Z

/gemini review

gemini-code-assist

Code Review

This pull request adds support for taking screenshots on iOS CoreDevices using devicectl when Xcode 26 or higher is installed, falling back to iMobileDevice for older versions. Feedback points out a potential TypeError when casting the decoded JSON response directly to a map, and a mismatch between the error message thrown in IOSDevice.takeScreenshot and the expected message in the unit tests.

gemini-code-assist

Code Review

This pull request introduces screenshot support for iOS CoreDevices by utilizing the devicectl command-line tool. The feedback correctly points out that devicectl screenshot capabilities are only available starting with Xcode 27, so the checks for Xcode major version 26 or higher in the device and test files must be updated to 27 to prevent failures on Xcode 26. Additionally, the new public getter isDevicectlInstalled requires a documentation comment to comply with the repository style guide.

gemini-code-assist

Code Review

This pull request replaces the deprecated idevicescreenshot tool with devicectl for capturing screenshots on iOS CoreDevices when running Xcode 16 or higher. It removes idevicescreenshot from the cache and artifacts, and integrates the new devicectl command into IOSCoreDeviceControl and IOSDevice. The review feedback highlights a critical typo where Xcode version 27 was specified instead of 16 across implementation and test files, which would disable screenshots for Xcode 16 users. Additionally, the reviewer noted that the new public getter isDevicectlInstalled requires a documentation comment to comply with the repository's style guide.

jmagman · 2026-07-13T19:46:59Z

+        );
+      } on Exception catch (error) {
+        final errorMessage = error.toString();
+        if (errorMessage.contains('CoreDeviceError error 4000') ||


I hit these when my device was either unpaired, or it was wireless paired and was locked.

@autoclosure

…12406) Manual roll Flutter from e52f01c920ad to b766512c65d8 (42 revisions) Manual roll requested by [email protected] flutter/flutter@e52f01c...b766512 2026-08-04 [email protected] Roll Dart SDK from 2a799a2404e9 to 9859c0a39adb (4 revisions) (flutter/flutter#190521) 2026-08-04 [email protected] Revert: iOS: Eliminate use of IOSContextNoop in platform view tests (flutter/flutter#190501) 2026-08-04 [email protected] [Impeller] Enable ETC2/ASTC LDR/BC texture compression features at Vulkan device creation (flutter/flutter#189303) 2026-08-03 [email protected] Remove openglessdf from impeller_unittests. (flutter/flutter#190469) 2026-08-03 [email protected] [web] Unify image decoding and codecs on CanvasKit and Skwasm (flutter/flutter#188573) 2026-08-03 [email protected] iOS: Eliminate use of IOSContextNoop in platform view tests (flutter/flutter#190419) 2026-08-03 [email protected] Add path rendering benchmarks (flutter/flutter#188654) 2026-08-03 [email protected] Add windows platform support for primitive_shape_test integration test (flutter/flutter#190464) 2026-08-03 [email protected] Roll Skia from 958c1c1921a1 to a08d918ebd6a (3 revisions) (flutter/flutter#190467) 2026-08-03 [email protected] tests: add --ios-runtime param (flutter/flutter#190414) 2026-08-03 [email protected] iOS: Remove the synchronous first-frame wait (flutter/flutter#190432) 2026-08-03 [email protected] iOS: Eliminate the Impeller/Skia backend selection params (flutter/flutter#190416) 2026-08-03 [email protected] iOS,macOS: Use @autoclosure in Logger (flutter/flutter#190417) 2026-08-03 [email protected] tools: Support FLUTTER_HOST_ARCH in update_dart_sdk scripts (flutter/flutter#190421) 2026-08-03 [email protected] iOS: Hardcode rendering API to Metal in tests (no-op) (flutter/flutter#190422) 2026-08-03 [email protected] a11y: Map disabled/read-only semantics to AX node restriction (flutter/flutter#190353) 2026-08-03 [email protected] [Infra] Replace defunct umbrella template with Wasm issue form (flutter/flutter#190471) 2026-08-03 [email protected] Roll Skia from abecb0dc02c1 to 958c1c1921a1 (4 revisions) (flutter/flutter#190459) 2026-08-03 [email protected] Roll Dart SDK from 65b163be2485 to 2a799a2404e9 (3 revisions) (flutter/flutter#190454) 2026-08-03 [email protected] Roll Skia from 68efb3f2ad16 to abecb0dc02c1 (1 revision) (flutter/flutter#190443) 2026-08-03 [email protected] Roll Packages from 5351d8c to ac87e65 (4 revisions) (flutter/flutter#190441) 2026-08-03 [email protected] Roll Skia from 5a761eb826c1 to 68efb3f2ad16 (1 revision) (flutter/flutter#190440) 2026-08-03 [email protected] Roll Skia from 4c9f8b4805e2 to 5a761eb826c1 (1 revision) (flutter/flutter#190437) 2026-08-03 [email protected] [macOS] Resume app lifecycle on becomeActive to avoid frozen UI after occlusion (flutter/flutter#188772) 2026-08-03 [email protected] Roll Skia from 39cda9d6d7d2 to 4c9f8b4805e2 (6 revisions) (flutter/flutter#190426) 2026-08-03 [email protected] Roll Skia from df13bfb5a54e to 39cda9d6d7d2 (2 revisions) (flutter/flutter#190425) 2026-08-02 [email protected] iOS: Serialise CADisplayLink access in VSyncClient tests (flutter/flutter#190335) 2026-08-02 [email protected] Roll Skia from 32329e5643b5 to df13bfb5a54e (1 revision) (flutter/flutter#190394) 2026-08-02 [email protected] [Impeller] Skip binding dead-code-eliminated resources on Metal (flutter/flutter#190040) 2026-08-01 [email protected] [Flutter GPU] Raise Dart errors for invalid render pipelines and memoize per-draw pipeline state (flutter/flutter#189899) 2026-08-01 [email protected] Revert "Improve non rect platform view rendering (#182662)" (flutter/flutter#190003) 2026-08-01 [email protected] Roll Skia from ebf50520d720 to 32329e5643b5 (1 revision) (flutter/flutter#190389) 2026-08-01 [email protected] Roll Skia from f73c4510d12d to ebf50520d720 (6 revisions) (flutter/flutter#190376) 2026-07-31 [email protected] Primitive shape integration test (flutter/flutter#190368) 2026-07-31 [email protected] Eliminate some early returns in uber_sdf.frag to fix broken UberSDF AA on Windows (flutter/flutter#190260) 2026-07-31 [email protected] chore: swiftshader mirrored + llvm16 (flutter/flutter#181225) 2026-07-31 [email protected] [web] Remove in-repo agent documentation (flutter/flutter#190326) 2026-07-31 [email protected] [windows]: Uses offscreen MSAA when implicit msaa isn't available. (flutter/flutter#190256) 2026-07-31 [email protected] flutter_tools: Use new FileSystemExtension from devtools (flutter/flutter#190360) 2026-07-31 [email protected] Roll Dart SDK from c3acfc2479f6 to 65b163be2485 (1 revision) (flutter/flutter#190358) 2026-07-31 [email protected] Use devicectl for screenshots on Xcode 27, remove idevicescreenshot artifact (flutter/flutter#189091) 2026-07-31 [email protected] Roll Skia from 7ef86a5b0eb9 to f73c4510d12d (1 revision) (flutter/flutter#190352) If this roll has caused a breakage, revert this CL and stop the roller ...

jmagman self-assigned this Jul 7, 2026

jmagman added tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Jul 7, 2026

github-actions Bot added platform-ios iOS applications specifically team-ios Owned by iOS platform team labels Jul 7, 2026

jmagman force-pushed the screenshot branch 2 times, most recently from d635b7e to c5a5934 Compare July 8, 2026 00:08

jmagman added the CICD Run CI/CD label Jul 8, 2026

gemini-code-assist Bot reviewed Jul 8, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/ios/core_devices.dart

Comment thread packages/flutter_tools/lib/src/ios/devices.dart Outdated

jmagman marked this pull request as ready for review July 8, 2026 20:33

jmagman requested a review from a team as a code owner July 8, 2026 20:33

jmagman changed the title ~~Use devicectl for screenshots on Xcode 27~~ Use devicectl for screenshots on Xcode 26 Jul 8, 2026

gemini-code-assist Bot reviewed Jul 8, 2026

View reviewed changes

vashworth reviewed Jul 8, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/ios/devices.dart Outdated

Comment thread packages/flutter_tools/lib/src/ios/core_devices.dart

Comment thread packages/flutter_tools/lib/src/ios/devices.dart Outdated

jmagman changed the title ~~Use devicectl for screenshots on Xcode 26~~ Use devicectl for screenshots on Xcode 27 Jul 8, 2026

jmagman marked this pull request as draft July 9, 2026 18:20

jmagman force-pushed the screenshot branch from 3e89ef7 to c103b38 Compare July 13, 2026 17:03

jmagman changed the title ~~Use devicectl for screenshots on Xcode 27~~ Use devicectl for screenshots on Xcode 27, remove idevicescreenshot artifact Jul 13, 2026

jmagman marked this pull request as ready for review July 13, 2026 19:06

gemini-code-assist Bot reviewed Jul 13, 2026

View reviewed changes

jmagman commented Jul 13, 2026

View reviewed changes

vashworth reviewed Jul 16, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/ios/devices.dart Outdated

Comment thread packages/flutter_tools/lib/src/ios/devices.dart Outdated

jmagman force-pushed the screenshot branch 2 times, most recently from 0e6c375 to 436e874 Compare July 23, 2026 17:16

vashworth previously approved these changes Jul 23, 2026

View reviewed changes

jmagman added 2 commits July 29, 2026 09:59

Use devicectl for screenshots on Xcode 27

453843b

tests

ac7aaf6

jmagman added 4 commits July 29, 2026 09:59

analyzer

8f8fc08

put back the enum

25cd504

review edits

75485fc

Remove deprecation

0ee9aae

jmagman dismissed vashworth’s stale review via 0ee9aae July 29, 2026 16:59

jmagman force-pushed the screenshot branch from 436e874 to 0ee9aae Compare July 29, 2026 16:59

rebase problem

ac3974e

jmagman requested a review from vashworth July 29, 2026 19:29

vashworth approved these changes Jul 31, 2026

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2026

auto-submit Bot added this pull request to the merge queue Jul 31, 2026

Merged via the queue into flutter:master with commit c4d08b7 Jul 31, 2026
22 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2026

engine-flutter-autoroll mentioned this pull request Jul 31, 2026

Roll Flutter from 2a230d1e8037 to c4d08b7364b6 (63 revisions) flutter/packages#12335

Closed

Piinks mentioned this pull request Jul 31, 2026

Flutter Notable Commits - 2026 #181433

Open

This was referenced Aug 9, 2026

Manual roll Flutter from e52f01c920ad to b766512c65d8 (42 revisions) flutter/packages#12406

Merged

Manual roll Flutter from e52f01c920ad to fd004496f408 (25 revisions) flutter/packages#12416

Closed

Conversation

jmagman commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jmagman commented Jul 8, 2026

Uh oh!

gemini-code-assist Bot commented Jul 8, 2026

Uh oh!

jmagman commented Jul 8, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jmagman commented Jul 7, 2026 •

edited

Loading