Repository navigation
Update Widgets Localizations from Translation Console - #190503
Conversation
github-actions
Bot
added
framework
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for Spanish Castilian as used in Spain (es_ES) by introducing the WidgetsLocalizationEsEs class, updating the supported language counts, and adding the corresponding widgets_es_ES.arb translation file. The feedback suggests correcting the translation of lookUpButtonLabel from the literal 'Mirar hacia arriba' to the standard 'Consultar' in both the ARB and generated files.
| "noResultsFound": "No se encontraron resultados", | ||
| "copyButtonLabel": "Copiar", | ||
| "cutButtonLabel": "Cortar", | ||
| "lookUpButtonLabel": "Mirar hacia arriba", |
There was a problem hiding this comment.
The translation for lookUpButtonLabel as "Mirar hacia arriba" is a literal translation of "look up" (to gaze upwards). In the context of a text selection menu (e.g., looking up a word in a dictionary), the standard Spanish translation is "Consultar".
"lookUpButtonLabel": "Consultar",
| String get noResultsFound => 'No se encontraron resultados'; | ||
|
|
||
| @override | ||
| String get lookUpButtonLabel => 'Mirar hacia arriba'; |
There was a problem hiding this comment.
The translation for lookUpButtonLabel as 'Mirar hacia arriba' is a literal translation of "look up" (to gaze upwards). In the context of a text selection menu (e.g., looking up a word in a dictionary), the standard Spanish translation is 'Consultar'.
| String get lookUpButtonLabel => 'Mirar hacia arriba'; | |
| String get lookUpButtonLabel => 'Consultar'; |
There was a problem hiding this comment.
FYI @QuncCccccc in case we need to check this with the translations team
There was a problem hiding this comment.
Thanks for catching this. I have suggested a correctness to the team. While we are waiting for update from upstream, I'll accept Gemini's suggestion since "Mirar hacia arriba" clearly is a wrong translation.
QuncCccccc
changed the title
QuncCccccc
changed the title
…er#190408) Updates the localized strings for GlobalWidgetsLocalizations ahead of the stable release cut, adding support for the new Spanish (Spain) es_ES translation bundle. Note: In alignment with the new localization pipeline, Material (material_ui) and Cupertino (cupertino_ui) localizations are excluded here as those packages reside in flutter/packages.
20d37e4 to
307babc
Compare
flutter-dashboard
Bot
removed
the
autosubmit
…12420) Manual roll requested by [email protected] flutter/flutter@b766512...27b0988 2026-08-05 [email protected] reland(tool): remove redundant --enable-experiment=record-use flag (flutter/flutter#190591) 2026-08-05 [email protected] Windows: Propagate enabled accessibility state (flutter/flutter#190507) 2026-08-05 [email protected] Roll Fuchsia Test Scripts from ltbuIH9Z3T_yOuigu... to vcANVO8VIDQHasH1X... (flutter/flutter#190589) 2026-08-05 [email protected] Document frozen embedder API structs (flutter/flutter#186842) 2026-08-05 [email protected] Document super call order for State.didChangeDependencies (flutter/flutter#185945) 2026-08-05 [email protected] Move examples of `flutter/widgets` widgets out from `flutter/material` (flutter/flutter#189532) 2026-08-05 [email protected] [web] Use thread local strike caches in skwasm (flutter/flutter#190048) 2026-08-05 [email protected] doc: fix typo in see also section for PrimaryScrollController.maybeOf (flutter/flutter#190386) 2026-08-05 [email protected] Migrate the shell unit tests from legacy Dart native functions to FFI (flutter/flutter#190473) 2026-08-05 [email protected] render proxy box now defaults baseline calculation to null (flutter/flutter#190269) 2026-08-05 [email protected] Update Widgets Localizations from Translation Console (flutter/flutter#190503) 2026-08-04 [email protected] Revert: fix(tool): remove redundant --enable-experiment=record-use flag (flutter/flutter#190583) 2026-08-04 [email protected] Roll Fuchsia Test Scripts from 1frGe_KltAJKkeyPg... to ltbuIH9Z3T_yOuigu... (flutter/flutter#190561) 2026-08-04 [email protected] iOS,macOS: add tsan and ubsan support for Swift (flutter/flutter#190497) 2026-08-04 [email protected] fix: update on_message_ to nullptr after window destroy so that dart gets destroy message (flutter/flutter#185807) 2026-08-04 [email protected] [flutter_tools] Gracefully handle locked Windows files during clean (flutter/flutter#190095) 2026-08-04 [email protected] iOS,macOS: make Logger thread-safe, conform to Sendable (flutter/flutter#190488) 2026-08-04 [email protected] iOS: Eliminate use of IOSContextNoop in platform view tests (reland) (flutter/flutter#190509) 2026-08-04 [email protected] fix(tool): remove redundant --enable-experiment=record-use flag (flutter/flutter#190475) 2026-08-04 [email protected] android_hardware_smoke_test: Detect blank image failures or EGL initialization warnings and retry (flutter/flutter#190110) 2026-08-04 [email protected] Bumps text gamma on windows to match skia. (flutter/flutter#190477) 2026-08-04 [email protected] Roll Skia from 48b58ee222f1 to a8583a0a2c11 (2 revisions) (flutter/flutter#190537) 2026-08-04 [email protected] [tool][web] Intercept dart2wasm errors & append JS migration footers (flutter/flutter#190476) 2026-08-04 [email protected] [record_use] Migrate IconTreeShaker to `package:record_use` (flutter/flutter#190225) 2026-08-04 [email protected] Handle unexpected exceptions during Azure metadata detection (flutter/flutter#189457) 2026-08-04 [email protected] Fix merge conflict from flutter/flutter#190369 (flutter/flutter#190544) 2026-08-04 [email protected] Prepare device support symbols (flutter/flutter#190369) 2026-08-04 [email protected] Roll Packages from ac87e65 to 3498b9d (1 revision) (flutter/flutter#190532) 2026-08-04 [email protected] Roll Skia from a08d918ebd6a to 48b58ee222f1 (11 revisions) (flutter/flutter#190527) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
This PR is to update localizations in widgets layer from translation console. It doesn't fetch material and cupertino localziations because they have been decoupled from core flutter and will be updated in material_ui and cupertino_ui.
Fixes #190408
Pre-launch Checklist
///).