Repository navigation
[wimp] Turn multithreading on for wimp. - #190626
Conversation
After flutter#190048, we no longer have multthreading issues with wimp, so we should turn multithreading on.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates skwasm_loader.js to remove the config.enableWimp condition from the skwasmSingleThreaded configuration property, along with the comments discussing multi-threaded wimp instability. There are no review comments, and I have no feedback to provide.
eyebrowsoffire
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
|
A reason for requesting a revert of flutter/flutter/190626 could not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why this issue is being reverted. |
flutteractionsbot
removed
the
revert
|
Reason for revert: failing Linux linux_web_engine_tests on tree. |
|
Successfully created revert PR: #191423 |
flutteractionsbot
removed
the
revert
|
Successfully created revert PR: #191424 |
Reverts: [[wimp] Turn multithreading on for wimp.](flutter#190626) Initiated by: @bkonyi Reason for reverting: [failing Linux linux_web_engine_tests on tree](https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/9022). Original PR Author: @eyebrowsoffire Reviewed By: @mdebbar The original PR description is provided below: After flutter#190048, we no longer have multthreading issues with wimp, so we should turn multithreading on. This addresses flutter#178749
Reverts: [[wimp] Turn multithreading on for wimp.](flutter#190626) Initiated by: @bkonyi Reason for reverting: [failing Linux linux_web_engine_tests on tree](https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/9022). Original PR Author: @eyebrowsoffire Reviewed By: @mdebbar The original PR description is provided below: After flutter#190048, we no longer have multthreading issues with wimp, so we should turn multithreading on. This addresses flutter#178749
4 participants
After #190048, we no longer have multthreading issues with wimp, so we should turn multithreading on.
This addresses #178749