[tool] Migrate DoctorCommand to modular dependency injection by bkonyi · Pull Request #190758 · flutter/flutter

bkonyi · 2026-08-07T21:39:47Z

Summary

Part 7 of the modular dependency injection migration.

Migrates DoctorCommand to explicit constructor dependency injection via ToolContext, Doctor, and AndroidLicenseValidator, removing ambient access from FlutterCommand and adding hermetic unit tests.

Stacked on #190751
Compare: bkonyi/flutter@di/05-channel...di/06-doctor

Part of #47161

gemini-code-assist

Code Review

This pull request refactors dependency injection in flutter_tools by introducing structured context classes (ToolContext, AndroidContext, AppleContext, and ToolDependencies) to bootstrap and manage tool dependencies, replacing global references across various commands and updating associated tests to run without zone-based context overrides. The review feedback identifies a critical issue where DoctorCommand is instantiated without its required dependencies, which would cause it to fail. It also suggests making doctor and androidLicenseValidator required in DoctorCommand for compile-time safety, and using the local finalShutdownHooks variable instead of creating unmanaged ShutdownHooks when bootstrapping the file system.

…ners

…ired non-nullable contexts

# Conflicts: # packages/flutter_tools/lib/src/context/tool_dependencies.dart # packages/flutter_tools/test/general.shard/context/dependency_injection_test.dart

…ection

… globals fallback

…ctly in FlutterCommandRunner

…ool_dependencies.dart

…n channel_test.dart

… doctor_test.dart

gemini-code-assist

Code Review

This pull request refactors DoctorCommand to inject its dependencies, such as ToolContext, Doctor, and AndroidLicenseValidator, instead of accessing them via globals, and adds corresponding unit tests. The review feedback suggests making the injected Doctor dependency required and non-nullable, which would simplify the command's implementation by removing redundant null-safety checks.

…cutable.dart Retain the shared singleton from `globals.doctor` in `DoctorCommand` until dependent commands (such as `DevicesCommand` and `EmulatorsCommand`) are migrated to dependency injection, avoiding instance divergence.

… validator lazily

flutter/flutter@0cbd1a4...70797e1 2026-09-02 [email protected] [analysis] Upgrade package:analyzer to 14.3.0 and enable custom plugin compilation (flutter/flutter#191590) 2026-09-02 [email protected] Roll Dart SDK from d8d7869d8031 to 9a8fbde80f6c (1 revision) (flutter/flutter#192179) 2026-09-02 [email protected] Roll Skia from dec311244db4 to ae22da2e8308 (1 revision) (flutter/flutter#192177) 2026-09-02 [email protected] [tool] Migrate DoctorCommand to modular dependency injection (flutter/flutter#190758) 2026-09-02 [email protected] Roll Skia from 482b7e285244 to dec311244db4 (3 revisions) (flutter/flutter#192161) 2026-09-02 [email protected] Roll Skia from 28447e9fb8d5 to 482b7e285244 (3 revisions) (flutter/flutter#192157) 2026-09-02 [email protected] feat: Add placeholder to DecorationImage (flutter/flutter#191528) 2026-09-02 [email protected] [Android] Do not schedule engine frames on a detached FlutterJNI (flutter/flutter#191204) 2026-09-02 [email protected] Roll Skia from 3a242fb7cdb3 to 28447e9fb8d5 (1 revision) (flutter/flutter#192145) 2026-09-02 [email protected] Roll Dart SDK from 9164def35347 to d8d7869d8031 (2 revisions) (flutter/flutter#192144) 2026-09-02 [email protected] Add FadeInImageTransition.fadeInOver to fade the image in over the placeholder (flutter/flutter#186246) 2026-09-02 [email protected] Roll Skia from 63d13ec4df6d to 3a242fb7cdb3 (9 revisions) (flutter/flutter#192138) 2026-09-02 [email protected] [flutter_tools] Add --no-plugins flag and disable plugins for benchmark (flutter/flutter#192129) 2026-09-02 [email protected] [tool] Migrate ChannelCommand to modular dependency injection (flutter/flutter#190751) 2026-09-01 [email protected] Add mouseCursor to RawScrollbar (flutter/flutter#185750) 2026-09-01 [email protected] Fix self-comparison and assert typos in TestSemantics (flutter/flutter#191938) 2026-09-01 [email protected] [Linux] Wait for frames to be rendered before using them in another context (flutter/flutter#192094) 2026-09-01 [email protected] [wimp] Turn on multithreading for wimp. (flutter/flutter#191747) 2026-09-01 [email protected] Roll Skia from 3911a1fe7f7a to 63d13ec4df6d (6 revisions) (flutter/flutter#192125) 2026-09-01 [email protected] Remove the redundant flutter/shell/platform/android:robolectric_tests build target (flutter/flutter#192117) 2026-09-01 [email protected] [iOS] Preserve semantics parents after reparenting (flutter/flutter#189686) 2026-09-01 [email protected] [flutter_tools] Report preview reload timing analytics in LspPreviewDetector (flutter/flutter#192120) 2026-09-01 [email protected] [flutter_tools] Implement Templates slice and flutter create integration (flutter/flutter#191748) 2026-09-01 [email protected] Uiscene migrate add2app hosts (flutter/flutter#191847) 2026-09-01 [email protected] Roll Packages from d642322 to 7a7912f (8 revisions) (flutter/flutter#192119) 2026-09-01 [email protected] [web] Anchor flt-semantics-host at 0,0 to fix WebKit semantics offset (flutter/flutter#190486) 2026-09-01 [email protected] Replace Shell::WaitForFirstFrame with an asynchronous API that matches the Shell threading model (flutter/flutter#191841) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#12727) flutter/flutter@0cbd1a4...70797e1 2026-09-02 [email protected] [analysis] Upgrade package:analyzer to 14.3.0 and enable custom plugin compilation (flutter/flutter#191590) 2026-09-02 [email protected] Roll Dart SDK from d8d7869d8031 to 9a8fbde80f6c (1 revision) (flutter/flutter#192179) 2026-09-02 [email protected] Roll Skia from dec311244db4 to ae22da2e8308 (1 revision) (flutter/flutter#192177) 2026-09-02 [email protected] [tool] Migrate DoctorCommand to modular dependency injection (flutter/flutter#190758) 2026-09-02 [email protected] Roll Skia from 482b7e285244 to dec311244db4 (3 revisions) (flutter/flutter#192161) 2026-09-02 [email protected] Roll Skia from 28447e9fb8d5 to 482b7e285244 (3 revisions) (flutter/flutter#192157) 2026-09-02 [email protected] feat: Add placeholder to DecorationImage (flutter/flutter#191528) 2026-09-02 [email protected] [Android] Do not schedule engine frames on a detached FlutterJNI (flutter/flutter#191204) 2026-09-02 [email protected] Roll Skia from 3a242fb7cdb3 to 28447e9fb8d5 (1 revision) (flutter/flutter#192145) 2026-09-02 [email protected] Roll Dart SDK from 9164def35347 to d8d7869d8031 (2 revisions) (flutter/flutter#192144) 2026-09-02 [email protected] Add FadeInImageTransition.fadeInOver to fade the image in over the placeholder (flutter/flutter#186246) 2026-09-02 [email protected] Roll Skia from 63d13ec4df6d to 3a242fb7cdb3 (9 revisions) (flutter/flutter#192138) 2026-09-02 [email protected] [flutter_tools] Add --no-plugins flag and disable plugins for benchmark (flutter/flutter#192129) 2026-09-02 [email protected] [tool] Migrate ChannelCommand to modular dependency injection (flutter/flutter#190751) 2026-09-01 [email protected] Add mouseCursor to RawScrollbar (flutter/flutter#185750) 2026-09-01 [email protected] Fix self-comparison and assert typos in TestSemantics (flutter/flutter#191938) 2026-09-01 [email protected] [Linux] Wait for frames to be rendered before using them in another context (flutter/flutter#192094) 2026-09-01 [email protected] [wimp] Turn on multithreading for wimp. (flutter/flutter#191747) 2026-09-01 [email protected] Roll Skia from 3911a1fe7f7a to 63d13ec4df6d (6 revisions) (flutter/flutter#192125) 2026-09-01 [email protected] Remove the redundant flutter/shell/platform/android:robolectric_tests build target (flutter/flutter#192117) 2026-09-01 [email protected] [iOS] Preserve semantics parents after reparenting (flutter/flutter#189686) 2026-09-01 [email protected] [flutter_tools] Report preview reload timing analytics in LspPreviewDetector (flutter/flutter#192120) 2026-09-01 [email protected] [flutter_tools] Implement Templates slice and flutter create integration (flutter/flutter#191748) 2026-09-01 [email protected] Uiscene migrate add2app hosts (flutter/flutter#191847) 2026-09-01 [email protected] Roll Packages from d642322 to 7a7912f (8 revisions) (flutter/flutter#192119) 2026-09-01 [email protected] [web] Anchor flt-semantics-host at 0,0 to fix WebKit semantics offset (flutter/flutter#190486) 2026-09-01 [email protected] Replace Shell::WaitForFirstFrame with an asynchronous API that matches the Shell threading model (flutter/flutter#191841) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bkonyi requested review from a team as code owners August 7, 2026 21:39

bkonyi requested review from jesswrd and removed request for a team August 7, 2026 21:39

flutter-dashboard Bot added the CICD Run CI/CD label Aug 7, 2026

github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. team-android Owned by Android platform team team-ios Owned by iOS platform team team-macos Owned by the macOS platform team labels Aug 7, 2026

gemini-code-assist Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/executable.dart Outdated

Comment thread packages/flutter_tools/lib/src/commands/doctor.dart Outdated

Comment thread packages/flutter_tools/lib/src/commands/doctor.dart Outdated

Comment thread packages/flutter_tools/lib/src/context/tool_dependencies.dart

bkonyi force-pushed the di/06-doctor branch from 0c75d37 to 0704b1e Compare August 8, 2026 00:37

bkonyi marked this pull request as draft August 8, 2026 16:38

bkonyi removed request for a team and jesswrd August 8, 2026 16:41

bkonyi force-pushed the di/06-doctor branch from 0704b1e to 79d9fbb Compare August 11, 2026 14:47

[tool] Define modular dependency injection containers and bootstrapper

85aa4f1

bkonyi force-pushed the di/06-doctor branch from 79d9fbb to 407e60f Compare August 11, 2026 15:31

bkonyi added 2 commits August 11, 2026 17:52

[tool] Address review comments on modular dependency injection contai…

341b711

…ners

[tool] Wire dependency injection into runner and executable with requ…

5533bb8

…ired non-nullable contexts

bkonyi force-pushed the di/06-doctor branch 2 times, most recently from d57494c to 6ec14e5 Compare August 11, 2026 19:48

bkonyi added 4 commits August 12, 2026 17:19

Merge remote-tracking branch 'origin/master' into di/02-runner-bootstrap

0125d94

# Conflicts: # packages/flutter_tools/lib/src/context/tool_dependencies.dart # packages/flutter_tools/test/general.shard/context/dependency_injection_test.dart

[tool] Address review feedback on FlutterCommandRunner dependency inj…

cd90309

…ection

[tool] Require ToolDependencies on FlutterCommandRunner and eliminate…

9f24ddb

… globals fallback

[tool] Remove unused getters and store analytics and toolContext dire…

15d4ff6

…ctly in FlutterCommandRunner

bkonyi force-pushed the di/06-doctor branch from 6ec14e5 to 9500e9f Compare August 12, 2026 18:16

github-actions Bot removed the team-android Owned by Android platform team label Aug 12, 2026

[tool] Remove unused dart:convert import and revert doc comments in t…

6538999

…ool_dependencies.dart

bkonyi added 7 commits August 28, 2026 18:35

Merge branch 'di/05-channel' into di/06-doctor

ef6aea3

[tool] Restore precacheArtifacts documentation and use FakePlatform i…

618c28a

…n channel_test.dart

Merge branch 'di/05-channel' into di/06-doctor

2f922e8

Merge remote-tracking branch 'upstream/master' into di/05-channel

18c47bc

Merge branch 'di/05-channel' into di/06-doctor

8c55dbd

Merge remote-tracking branch 'upstream/master' into di/06-doctor

b414cb7

[tool] Explicitly override toolContext getter and assert injection in…

2cb7264

… doctor_test.dart

bkonyi marked this pull request as ready for review September 2, 2026 01:32

gemini-code-assist Bot reviewed Sep 2, 2026

View reviewed changes

bkonyi added 4 commits September 2, 2026 01:37

[tool] Make Doctor parameter required in DoctorCommand

65e4936

[tool] Instantiate Doctor directly in executable.dart

69f90bb

[tool] Make DoctorCommand constructor parameters optional and resolve…

3b1d0bc

… validator lazily

bkonyi requested a review from chingjun September 2, 2026 03:36

bkonyi mentioned this pull request Sep 2, 2026

[tool] Migrate LogsCommand to modular dependency injection #190765

Merged

chingjun approved these changes Sep 2, 2026

View reviewed changes

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2026

auto-submit Bot added this pull request to the merge queue Sep 2, 2026

Merged via the queue into flutter:master with commit 6b456df Sep 2, 2026
23 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2026

Navigation Menu

Repository navigation

[tool] Migrate DoctorCommand to modular dependency injection - #190758

[tool] Migrate DoctorCommand to modular dependency injection#190758
auto-submit[bot] merged 79 commits into
flutter:masterfrom
bkonyi:di/06-doctor

bkonyi commented Aug 7, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bkonyi commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bkonyi commented Aug 7, 2026 •

edited

Loading