[tool] Migrate EmulatorsCommand to modular dependency injection by bkonyi · Pull Request #190769 · flutter/flutter

bkonyi · 2026-08-08T02:37:18Z

Summary

Part 11 of the modular dependency injection migration.

Migrates EmulatorsCommand to modular constructor dependency injection with zero global fallbacks:

EmulatorsCommand({
  required Doctor doctor,
  required EmulatorManager emulatorManager,
  required ToolContext toolContext,
  super.verboseHelp,
})

Requires non-nullable Doctor, EmulatorManager, and ToolContext, completely eliminating ambient globals.* references and globals.dart imports from emulators.dart.
Resolves toolContext.logger, toolContext.platform, toolContext.processManager, and toolContext.terminal directly from toolContext.
Wires dependencies via toolDependencies.toolContext in executable.dart.
Adds comprehensive hermetic unit tests in packages/flutter_tools/test/commands.shard/hermetic/emulators_test.dart under testWithoutContext.

Part of #188471

Update EmulatorsCommand constructor to support optional dependency injection with ambient fallbacks to globals.doctor, globals.emulatorManager, and toolContext. Wire toolContext and verboseHelp in executable.dart lazily to eliminate eager Java/process evaluation during command generation. Add hermetic unit tests verifying both explicit injection and ambient fallback.

gemini-code-assist

Code Review

This pull request refactors EmulatorsCommand to support dependency injection for its dependencies (Doctor, EmulatorManager, toolContext, and verboseHelp), falling back to ambient globals when they are omitted. It also adds comprehensive hermetic tests for the command. The review feedback suggests updating the constructor documentation to clarify that all omitted dependencies fall back to globals, and simplifying the class implementation by overriding the inherited emulatorManager getter from FlutterCommand instead of introducing a new custom getter.

…sCommand

…rsCommand

bkonyi · 2026-09-02T13:50:20Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors EmulatorsCommand to inject dependencies (Doctor, EmulatorManager, and ToolContext) instead of relying on global variables, and adds a comprehensive test suite. The reviewer suggests refactoring doctor and emulatorManager to be non-nullable and required dependencies within EmulatorsCommand. This would eliminate the need for null-gating checks, redundant null checks, and complex switch expressions throughout the command's implementation, simplifying the code and preventing potential silent failures.

bkonyi · 2026-09-02T14:04:33Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors EmulatorsCommand to use dependency injection by passing Doctor, EmulatorManager, and ToolContext through its constructor rather than accessing them via global variables. It also adds a new emulatorManager getter to globals.dart and introduces a comprehensive suite of unit tests in emulators_test.dart to verify the command's behavior. There are no review comments, and I have no feedback to provide.

…tlight scan

…atorsCommand

* Make `doctor` and `emulatorManager` optional constructor parameters in `EmulatorsCommand` and resolve them lazily via `_effectiveDoctor` and `_effectiveEmulatorManager`. * Remove temporary backup and script files. * Restore hermetic unit tests in `emulators_test.dart` using `testWithoutContext`.

…minate all fallbacks Make Doctor and EmulatorManager required non-nullable dependencies in EmulatorsCommand, eliminating fallback getters and all references to ambient globals. Expose both dependencies in ToolDependencies and update fakes and command runner wiring accordingly.

…-emulators

flutter/flutter@b444e78...63b9518 2026-09-09 [email protected] Roll Packages from 9af9c60 to 36e088a (24 revisions) (flutter/flutter#192485) 2026-09-09 [email protected] Re-add Xcode and OpenJDK dependencies to macOS wasm local_engine builders (flutter/flutter#192238) 2026-09-09 [email protected] Roll Dart SDK from 77094991d1c1 to 4be1b711b4ba (5 revisions) (flutter/flutter#192453) 2026-09-09 [email protected] [material] Use super parameters in more places (flutter/flutter#192149) 2026-09-09 [email protected] [cupertino] Use super parameters in more places (flutter/flutter#192148) 2026-09-09 [email protected] [flutter_tools] Gracefully handle EROFS and write-protected file system errors (flutter/flutter#192431) 2026-09-09 [email protected] [tool] Migrate BuildIOSCommand and BuildIOSArchiveCommand to modular dependency injection (flutter/flutter#192250) 2026-09-09 [email protected] Replace more enum instances comparison to use `equality ==` instead of `identical` and update related tests (flutter/flutter#192229) 2026-09-09 [email protected] [web] Support local screenshot and golden testing in felt test (flutter/flutter#191318) 2026-09-09 [email protected] [tool] Migrate DaemonCommand and DebugAdapterCommand to modular dependency injection (flutter/flutter#190793) 2026-09-09 [email protected] [web] Support local golden testing in flutter test (flutter/flutter#191386) 2026-09-09 [email protected] [flutter_tools] Ignore widget previews outside lib/ during LSP code generation (flutter/flutter#192326) 2026-09-09 [email protected] [flutter_tools] Read package_config.json asynchronously in loadPackageConfigWithLogging (flutter/flutter#192443) 2026-09-08 [email protected] Add precacheTestImage to flutter_test and unskip web image tests (flutter/flutter#191435) 2026-09-08 [email protected] et: Fix compile_commands.json post-processing (flutter/flutter#192395) 2026-09-08 [email protected] Refactor createDebuggingOptions and option registrations to OptionDescriptor (flutter/flutter#192307) 2026-09-08 [email protected] [flutter_tools] Fix test separation between `VersionFreshnessValidator` and `FlutterVersion.checkFlutterVersionFreshness` (flutter/flutter#191593) 2026-09-08 [email protected] [tool] Migrate EmulatorsCommand to modular dependency injection (flutter/flutter#190769) 2026-09-08 [email protected] [tool] Migrate Desktop build subcommands and toolchain to modular dependency injection (flutter/flutter#190781) 2026-09-08 [email protected] [tool] Migrate Tooling and Analysis commands to modular dependency injection (flutter/flutter#190788) 2026-09-08 [email protected] Skip KGP version validation for AGP built-in Kotlin (flutter/flutter#192206) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#12814) flutter/flutter@b444e78...63b9518 2026-09-09 [email protected] Roll Packages from 9af9c60 to 36e088a (24 revisions) (flutter/flutter#192485) 2026-09-09 [email protected] Re-add Xcode and OpenJDK dependencies to macOS wasm local_engine builders (flutter/flutter#192238) 2026-09-09 [email protected] Roll Dart SDK from 77094991d1c1 to 4be1b711b4ba (5 revisions) (flutter/flutter#192453) 2026-09-09 [email protected] [material] Use super parameters in more places (flutter/flutter#192149) 2026-09-09 [email protected] [cupertino] Use super parameters in more places (flutter/flutter#192148) 2026-09-09 [email protected] [flutter_tools] Gracefully handle EROFS and write-protected file system errors (flutter/flutter#192431) 2026-09-09 [email protected] [tool] Migrate BuildIOSCommand and BuildIOSArchiveCommand to modular dependency injection (flutter/flutter#192250) 2026-09-09 [email protected] Replace more enum instances comparison to use `equality ==` instead of `identical` and update related tests (flutter/flutter#192229) 2026-09-09 [email protected] [web] Support local screenshot and golden testing in felt test (flutter/flutter#191318) 2026-09-09 [email protected] [tool] Migrate DaemonCommand and DebugAdapterCommand to modular dependency injection (flutter/flutter#190793) 2026-09-09 [email protected] [web] Support local golden testing in flutter test (flutter/flutter#191386) 2026-09-09 [email protected] [flutter_tools] Ignore widget previews outside lib/ during LSP code generation (flutter/flutter#192326) 2026-09-09 [email protected] [flutter_tools] Read package_config.json asynchronously in loadPackageConfigWithLogging (flutter/flutter#192443) 2026-09-08 [email protected] Add precacheTestImage to flutter_test and unskip web image tests (flutter/flutter#191435) 2026-09-08 [email protected] et: Fix compile_commands.json post-processing (flutter/flutter#192395) 2026-09-08 [email protected] Refactor createDebuggingOptions and option registrations to OptionDescriptor (flutter/flutter#192307) 2026-09-08 [email protected] [flutter_tools] Fix test separation between `VersionFreshnessValidator` and `FlutterVersion.checkFlutterVersionFreshness` (flutter/flutter#191593) 2026-09-08 [email protected] [tool] Migrate EmulatorsCommand to modular dependency injection (flutter/flutter#190769) 2026-09-08 [email protected] [tool] Migrate Desktop build subcommands and toolchain to modular dependency injection (flutter/flutter#190781) 2026-09-08 [email protected] [tool] Migrate Tooling and Analysis commands to modular dependency injection (flutter/flutter#190788) 2026-09-08 [email protected] Skip KGP version validation for AGP built-in Kotlin (flutter/flutter#192206) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. team-android Owned by Android platform team team-ios Owned by iOS platform team team-macos Owned by the macOS platform team labels Aug 8, 2026

bkonyi force-pushed the di/10-emulators branch 5 times, most recently from b5a2eb5 to 7591910 Compare August 12, 2026 18:17

github-actions Bot removed the team-android Owned by Android platform team label Aug 12, 2026

bkonyi force-pushed the di/10-emulators branch from 7591910 to b49d777 Compare August 12, 2026 18:39

github-actions Bot removed team-ios Owned by iOS platform team team-macos Owned by the macOS platform team labels Aug 28, 2026

bkonyi added 2 commits September 2, 2026 12:45

[tool] Migrate EmulatorsCommand to modular dependency injection

9e39fbe

bkonyi force-pushed the di/10-emulators branch from 56175f6 to 013f02f Compare September 2, 2026 12:57

bkonyi marked this pull request as ready for review September 2, 2026 12:57

bkonyi added the CICD Run CI/CD label Sep 2, 2026

gemini-code-assist Bot reviewed Sep 2, 2026

View reviewed changes

bkonyi added 2 commits September 2, 2026 13:28

[tool] Require ToolContext and eliminate global fallbacks in Emulator…

72920ca

…sCommand

[tool] Eliminate variable mirroring without null promotion in Emulato…

c83b24c

…rsCommand

gemini-code-assist Bot reviewed Sep 2, 2026

View reviewed changes

[tool] Require doctor and emulatorManager in EmulatorsCommand

e8a89c8

gemini-code-assist Bot reviewed Sep 2, 2026

View reviewed changes

bkonyi added 4 commits September 2, 2026 19:03

[tool] Provide FakeAndroidStudio override in args_test to prevent Spo…

727d07d

…tlight scan

[tool] Remove globals.emulatorManager and ambient injection from Emul…

b916803

…atorsCommand

[tool] Fix EmulatorsCommand compilation errors

452d2ca

[tool] Clean up EmulatorsCommand tests and remove temporary files

a90a287

bkonyi added 7 commits September 3, 2026 16:19

[tool] Restore license header to emulators.dart

d5b3a00

Merge branch 'master' into di/10-emulators

28e6508

[tool] Merge upstream master into di/10-emulators

16446b5

[tool] Merge remote-tracking branch 'fork/di/10-emulators' into di/10…

b56f757

…-emulators

[tool] Re-trigger checks with G3Fix CL 976550240

811354d

bkonyi requested a review from chingjun September 8, 2026 18:50

chingjun approved these changes Sep 8, 2026

View reviewed changes

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2026

auto-submit Bot added this pull request to the merge queue Sep 8, 2026

Merged via the queue into flutter:master with commit edac39b Sep 8, 2026
23 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2026

This was referenced Sep 9, 2026

Roll Flutter from b444e7897e24 to 0056d8b88d34 (19 revisions) flutter/packages#12813

Closed

Roll Flutter from b444e7897e24 to 63b9518f16bc (21 revisions) flutter/packages#12814

Merged

Navigation Menu

Repository navigation

[tool] Migrate EmulatorsCommand to modular dependency injection - #190769

[tool] Migrate EmulatorsCommand to modular dependency injection#190769
auto-submit[bot] merged 16 commits into
flutter:masterfrom
bkonyi:di/10-emulators

bkonyi commented Aug 8, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Sep 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Sep 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bkonyi commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Sep 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Sep 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bkonyi commented Aug 8, 2026 •

edited

Loading