Skip to content

Roll Skia from 5dddf11de22a to 508fc9e7f9ad (4 revisions) - #190778

Closed
engine-flutter-autoroll wants to merge 1 commit into
flutter:masterfrom
engine-flutter-autoroll:skia-flutter-autoroll-9426e265-82a8-4fa4-a0c9-e495c9190b0b-1786163640
Closed

engine-flutter-autoroll wants to merge 1 commit into
flutter:masterfrom
engine-flutter-autoroll:skia-flutter-autoroll-9426e265-82a8-4fa4-a0c9-e495c9190b0b-1786163640

Conversation

@engine-flutter-autoroll

Copy link
Copy Markdown
Contributor

https://skia.googlesource.com/skia.git/+log/5dddf11de22a..508fc9e7f9ad

2026-08-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2026-08-07 [email protected] Roll vulkan-deps from e8c6af24af68 to 47bfc06ded40 (9 revisions)
2026-08-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2026-08-07 [email protected] Manual roll Dawn from 1c9c16c9ad1c to bf6225076ff5 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/5dddf11de22a..508fc9e7f9ad

2026-08-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2026-08-07 [email protected] Roll vulkan-deps from e8c6af24af68 to 47bfc06ded40 (9 revisions)
2026-08-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2026-08-07 [email protected] Manual roll Dawn from 1c9c16c9ad1c to bf6225076ff5 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 8, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Aug 8, 2026
@auto-submit

auto-submit Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/190778, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2026
@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2026
@auto-submit

auto-submit Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/190778, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2026
@auto-submit

auto-submit Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/190778, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll

Copy link
Copy Markdown
Contributor Author

Commit queue failed; closing this roll.

@engine-flutter-autoroll
engine-flutter-autoroll deleted the skia-flutter-autoroll-9426e265-82a8-4fa4-a0c9-e495c9190b0b-1786163640 branch August 15, 2026 05:17
dhc-tech pushed a commit to dhc-tech/flutter that referenced this pull request Sep 15, 2026
… dependency injection (flutter#190776)

## Summary

Part 14 of the modular dependency injection migration.

* Migrates `BuildApkCommand` (`flutter build apk`) and shared Android
toolchain components to modular constructor dependency injection:
  ```dart
  BuildApkCommand({
    required AndroidBuilder androidBuilder,
    required AndroidContext androidContext,
    required BuildSystem buildSystem,
    required ToolContext toolContext,
    bool verboseHelp = false,
  })
  ```
* Requires non-nullable `AndroidBuilder` in `BuildCommand` and
`AndroidGradleBuilder`, eliminating ambient `globals.dart` and
`context.get<AndroidBuilder>()` fallbacks.
* Requires explicit `Analytics` and `Logger` in `exitWithNoSdkMessage`.
* Defers `BuildAppBundleCommand` and `BuildAarCommand` migrations to
stacked follow-up PRs
([flutter#190778](flutter#190778) /
`di/14b-build-appbundle` and `di/14c-build-aar`).
* Converts Android build command tests to hermetic `testWithoutContext`
where applicable.

Part of flutter#188471

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants