Revert "Improve initial size and placement logic for popups and toolt…ips on Linux (#189994) by mattkae · Pull Request #191498 · flutter/flutter

mattkae · 2026-08-21T17:58:11Z

This reverts commit f6061d0.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

flutter-dashboard · 2026-08-21T17:58:19Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

google-cla · 2026-08-21T17:58:29Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist

Code Review

This pull request simplifies the Linux windowing platform code by removing the deferred-show and reposition-on-resize logic previously implemented in _SizedToContentWindowMixin. Tooltip and popup windows are now shown immediately upon receiving the first frame callback, and the on_size_changed callback has been removed from FlViewMonitor in both the C++ engine and Dart wrapper. Feedback is provided regarding several newly introduced lines in _window_linux.dart that exceed the 80-character limit enforced by dart format.

gemini-code-assist · 2026-08-21T17:59:14Z

 ///  * [DialogWindowController], the base class for dialog windows.
-class DialogWindowControllerLinux extends DialogWindowController
-    implements BaseWindowControllerLinux {
+class DialogWindowControllerLinux extends DialogWindowController implements BaseWindowControllerLinux {


This line exceeds the 80-character limit enforced by dart format. Please wrap the line to adhere to the Flutter style guide.

class DialogWindowControllerLinux extends DialogWindowController implements BaseWindowControllerLinux {

References

All Dart code is formatted using dart format. This is enforced by CI. ^(link)

gemini-code-assist · 2026-08-21T17:59:14Z

-class PopupWindowControllerLinux extends PopupWindowController
-    with _SizedToContentWindowMixin
-    implements BaseWindowControllerLinux {
+class PopupWindowControllerLinux extends PopupWindowController implements BaseWindowControllerLinux {


This line exceeds the 80-character limit enforced by dart format. Please wrap the line to adhere to the Flutter style guide.

class PopupWindowControllerLinux extends PopupWindowController implements BaseWindowControllerLinux {

References

All Dart code is formatted using dart format. This is enforced by CI. ^(link)

gemini-code-assist · 2026-08-21T17:59:14Z

+  _FlViewMonitor._internal(ffi.Pointer<ffi.NativeType> view, this._onFirstFrameFunction)
+    : super(_flViewMonitorNew(view, _onFirstFrameFunction.nativeFunction));


This constructor declaration exceeds the 80-character limit enforced by dart format. Please wrap the parameters to adhere to the Flutter style guide.

_FlViewMonitor._internal( ffi.Pointer<ffi.NativeType> view, this._onFirstFrameFunction, ) : super(_flViewMonitorNew(view, _onFirstFrameFunction.nativeFunction));

References

All Dart code is formatted using dart format. This is enforced by CI. ^(link)

…ips on Linux (flutter#189994)" This reverts commit f6061d0.

auto-submit · 2026-08-21T19:47:08Z

autosubmit label was removed for flutter/flutter/191498, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter/flutter@65c9a8d...9a82789 2026-08-24 [email protected] Roll Packages from 252bb33 to df2ba94 (5 revisions) (flutter/flutter#191578) 2026-08-24 [email protected] Roll Dart SDK from cb056da580b6 to 78bbc37b6ff6 (13 revisions) (flutter/flutter#191574) 2026-08-24 [email protected] Roll Skia from 50452b13f05b to 57968d087d18 (1 revision) (flutter/flutter#191572) 2026-08-24 [email protected] Move more RSE rendering cases to complex_rse.frag (flutter/flutter#191235) 2026-08-24 [email protected] Roll Skia from 925e13559532 to 50452b13f05b (2 revisions) (flutter/flutter#191570) 2026-08-24 [email protected] iOS: Add stylus pointer tests (flutter/flutter#191564) 2026-08-24 [email protected] iOS: Improve FlutterEngineGroup tests (flutter/flutter#191563) 2026-08-24 [email protected] Roll Skia from c78782c7c1c2 to 925e13559532 (5 revisions) (flutter/flutter#191568) 2026-08-24 [email protected] Roll Skia from 886302c7c68e to c78782c7c1c2 (1 revision) (flutter/flutter#191566) 2026-08-24 [email protected] Revert "Improve initial size and placement logic for popups and toolt…ips on Linux (#189994) (flutter/flutter#191498) 2026-08-23 [email protected] Roll Fuchsia Linux SDK from Cqs-NyeELd60hqv1e... to 8Xu4ujBJniC0nQGx3... (flutter/flutter#191561) 2026-08-23 [email protected] Fixes MSAA on the linux embedder. (flutter/flutter#191379) 2026-08-23 [email protected] Remove Material/Cupertino references in error messages (flutter/flutter#191305) 2026-08-23 [email protected] Roll Skia from a1825062f832 to 886302c7c68e (1 revision) (flutter/flutter#191559) 2026-08-23 [email protected] Roll Skia from ad2106c0bb64 to a1825062f832 (1 revision) (flutter/flutter#191555) 2026-08-22 [email protected] Roll Fuchsia Linux SDK from ic6GjOSn-KN508XyK... to Cqs-NyeELd60hqv1e... (flutter/flutter#191547) 2026-08-22 [email protected] [WebParagraph] Fixing minor problem with getBoxesForRange (flutter/flutter#191419) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#12578) flutter/flutter@65c9a8d...9a82789 2026-08-24 [email protected] Roll Packages from 252bb33 to df2ba94 (5 revisions) (flutter/flutter#191578) 2026-08-24 [email protected] Roll Dart SDK from cb056da580b6 to 78bbc37b6ff6 (13 revisions) (flutter/flutter#191574) 2026-08-24 [email protected] Roll Skia from 50452b13f05b to 57968d087d18 (1 revision) (flutter/flutter#191572) 2026-08-24 [email protected] Move more RSE rendering cases to complex_rse.frag (flutter/flutter#191235) 2026-08-24 [email protected] Roll Skia from 925e13559532 to 50452b13f05b (2 revisions) (flutter/flutter#191570) 2026-08-24 [email protected] iOS: Add stylus pointer tests (flutter/flutter#191564) 2026-08-24 [email protected] iOS: Improve FlutterEngineGroup tests (flutter/flutter#191563) 2026-08-24 [email protected] Roll Skia from c78782c7c1c2 to 925e13559532 (5 revisions) (flutter/flutter#191568) 2026-08-24 [email protected] Roll Skia from 886302c7c68e to c78782c7c1c2 (1 revision) (flutter/flutter#191566) 2026-08-24 [email protected] Revert "Improve initial size and placement logic for popups and toolt…ips on Linux (#189994) (flutter/flutter#191498) 2026-08-23 [email protected] Roll Fuchsia Linux SDK from Cqs-NyeELd60hqv1e... to 8Xu4ujBJniC0nQGx3... (flutter/flutter#191561) 2026-08-23 [email protected] Fixes MSAA on the linux embedder. (flutter/flutter#191379) 2026-08-23 [email protected] Remove Material/Cupertino references in error messages (flutter/flutter#191305) 2026-08-23 [email protected] Roll Skia from a1825062f832 to 886302c7c68e (1 revision) (flutter/flutter#191559) 2026-08-23 [email protected] Roll Skia from ad2106c0bb64 to a1825062f832 (1 revision) (flutter/flutter#191555) 2026-08-22 [email protected] Roll Fuchsia Linux SDK from ic6GjOSn-KN508XyK... to Cqs-NyeELd60hqv1e... (flutter/flutter#191547) 2026-08-22 [email protected] [WebParagraph] Fixing minor problem with getBoxesForRange (flutter/flutter#191419) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

mattkae requested a review from knopp August 21, 2026 17:58

mattkae requested a review from a team as a code owner August 21, 2026 17:58

flutter-dashboard Bot added the CICD Run CI/CD label Aug 21, 2026

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop team-linux Owned by the Linux platform team labels Aug 21, 2026

knopp approved these changes Aug 21, 2026

View reviewed changes

gemini-code-assist Bot reviewed Aug 21, 2026

View reviewed changes

Revert "Improve initial size and placement logic for popups and toolt…

47b0719

…ips on Linux (flutter#189994)" This reverts commit f6061d0.

mattkae force-pushed the revert-189994 branch from decd2ad to 47b0719 Compare August 21, 2026 18:03

mattkae added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2026

Merge branch 'master' into revert-189994

50aea58

robert-ancell added this pull request to the merge queue Aug 24, 2026

Merged via the queue into flutter:master with commit a6d9dcd Aug 24, 2026
17 checks passed

robert-ancell deleted the revert-189994 branch August 24, 2026 02:46

This was referenced Aug 24, 2026

Roll Flutter from 65c9a8dc60bc to a48daa092b0b (16 revisions) flutter/packages#12573

Closed

Roll Flutter from 65c9a8dc60bc to 9a8278982588 (17 revisions) flutter/packages#12578

Merged

Navigation Menu

Repository navigation

Revert "Improve initial size and placement logic for popups and toolt…ips on Linux (#189994) - #191498

Revert "Improve initial size and placement logic for popups and toolt…ips on Linux (#189994)#191498
robert-ancell merged 2 commits into
flutter:masterfrom
canonical:revert-189994

mattkae commented Aug 21, 2026 •

edited

Loading

Uh oh!

flutter-dashboard Bot commented Aug 21, 2026

Uh oh!

google-cla Bot commented Aug 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Uh oh!

auto-submit Bot commented Aug 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		_FlViewMonitor._internal(ffi.Pointer<ffi.NativeType> view, this._onFirstFrameFunction)
		: super(_flViewMonitorNew(view, _onFirstFrameFunction.nativeFunction));

Conversation

mattkae commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard Bot commented Aug 21, 2026

Uh oh!

google-cla Bot commented Aug 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Aug 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mattkae commented Aug 21, 2026 •

edited

Loading