Repository navigation
Fix FilledButton Material 3 default style docs - #191721
Closed
saurabh-mirajkar wants to merge 1 commit into
Closed
saurabh-mirajkar wants to merge 1 commit into
saurabh-mirajkar wants to merge 1 commit into
Conversation
|
This pull request contains changes to Material or Cupertino, which are currently frozen in this repository. Changes should be made in Please refer to #188444 for instructions. |
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for FilledButton in filled_button.dart to reflect changes in the default color scheme values. Specifically, it updates the documented default colors for backgroundColor, foregroundColor, and overlayColor from using the secondary container color scheme to the primary color scheme. There are no review comments, and I have no feedback to provide.
10 of 11 tasks
Contributor
Author
|
Ported this change to |
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 8, 2026
Fixes flutter/flutter#191556 This is the port of flutter/flutter#191721 following the Material/Cupertino decoupling. ## Description The Material 3 defaults documented in `FilledButton.defaultStyleOf` did not match the values used by `_FilledButtonDefaultsM3`. The documentation described the tonal variant colors (`secondaryContainer` / `onSecondaryContainer`) and corresponding overlay colors, while the implementation uses `primary` / `onPrimary`. This updates the Material 3 defaults documentation to match the existing implementation. ## Tests - Ran `dart format packages/material_ui/lib/src/filled_button.dart`. - No tests added as this is a documentation-only change. Original Flutter PR: flutter/flutter#191721 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…#12620) Fixes flutter/flutter#191556 This is the port of flutter/flutter#191721 following the Material/Cupertino decoupling. ## Description The Material 3 defaults documented in `FilledButton.defaultStyleOf` did not match the values used by `_FilledButtonDefaultsM3`. The documentation described the tonal variant colors (`secondaryContainer` / `onSecondaryContainer`) and corresponding overlay colors, while the implementation uses `primary` / `onPrimary`. This updates the Material 3 defaults documentation to match the existing implementation. ## Tests - Ran `dart format packages/material_ui/lib/src/filled_button.dart`. - No tests added as this is a documentation-only change. Original Flutter PR: flutter/flutter#191721 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…#12620) Fixes flutter/flutter#191556 This is the port of flutter/flutter#191721 following the Material/Cupertino decoupling. ## Description The Material 3 defaults documented in `FilledButton.defaultStyleOf` did not match the values used by `_FilledButtonDefaultsM3`. The documentation described the tonal variant colors (`secondaryContainer` / `onSecondaryContainer`) and corresponding overlay colors, while the implementation uses `primary` / `onPrimary`. This updates the Material 3 defaults documentation to match the existing implementation. ## Tests - Ran `dart format packages/material_ui/lib/src/filled_button.dart`. - No tests added as this is a documentation-only change. Original Flutter PR: flutter/flutter#191721 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #191556
Description
The Material 3 defaults documented in
FilledButton.defaultStyleOfdo not match the values used by_FilledButtonDefaultsM3.The documentation currently describes the tonal variant colors (
secondaryContainer/onSecondaryContainer), while the implementation usesprimary/onPrimary.This updates the Material 3 defaults documentation to match the actual implementation.
Tests
dart format packages/flutter/lib/src/material/filled_button.dart.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.