[tool] Migrate dev/tools from dart_skills_lint to skills_lint package by reidbaker-agent · Pull Request #191997 · flutter/flutter

reidbaker-agent · 2026-08-28T20:55:58Z

skills_lint is now published to pub so git hash in the pubspec is not needed. Changes align with the repo and packages changed name.

@reidbaker

Agent authored description

Migrates `dev/tools` skill validation tooling from the legacy `dart_skills_lint` repository dependency to the official published `skills_lint: ^0.5.1` package on pub.dev.

Summary of Changes

Updated `dev/tools/pubspec.yaml` to depend on `skills_lint: ^0.5.1`.
Renamed `dev/tools/dart_skills_lint.yaml` to `dev/tools/skills_lint.yaml` and updated the root configuration key.
Renamed `.agents/skills/dart_skills_lint_ignore.json` to `skills_lint_ignore.json`.
Updated `dev/tools/test/validate_skills_test.dart` and `check_backticks_relative_paths_rule.dart` imports and configuration filename.
Updated `pubspec.lock`.
Verified with `dart pub get`, `dart analyze --fatal-infos`, and `dart test`.

- Update dev/tools/pubspec.yaml to depend on published skills_lint: ^0.5.1 - Rename dev/tools/dart_skills_lint.yaml to dev/tools/skills_lint.yaml and update root key - Rename .agents/skills/dart_skills_lint_ignore.json to skills_lint_ignore.json - Update test imports and references to package:skills_lint - Update pubspec.lock

gemini-code-assist

Code Review

This pull request migrates the project's linting dependency from the git-hosted dart_skills_lint package to the pub.dev-hosted skills_lint package (version 0.5.1). This includes updating the dependency in pubspec.yaml and pubspec.lock, renaming the configuration file and its root key to skills_lint, and updating the corresponding package imports and references in the test files. There are no review comments, and I have no feedback to provide.

jtmcdole

The CodeFu Platinum LGTM Card: For everywhere you want your PR to land.

1.337% LGTM-back savings on every landing
Zero annual fees - its open source software
Some repository restrictions apply. Not valid on flaky or missing tests, unapproved infra changes

flutter/flutter@c8c5e3b...0cbd1a4 2026-09-01 [email protected] Roll Skia from 6be7f8547c3c to 3911a1fe7f7a (1 revision) (flutter/flutter#192110) 2026-09-01 [email protected] Roll Fuchsia Linux SDK from EPzxifoyt36b5qiBy... to idslm9FikVLy2K_A-... (flutter/flutter#192104) 2026-09-01 [email protected] Roll Skia from 47df2ae3226c to 6be7f8547c3c (1 revision) (flutter/flutter#192103) 2026-09-01 [email protected] Roll Skia from e22ebf131e44 to 47df2ae3226c (4 revisions) (flutter/flutter#192099) 2026-09-01 [email protected] Roll Skia from 5489a16a5998 to e22ebf131e44 (5 revisions) (flutter/flutter#192093) 2026-09-01 [email protected] [flutter_tools] Safely handle broken symlinks and existing files during plugin symlink creation (flutter/flutter#191496) 2026-09-01 [email protected] Support wide gamut colors in gradient_generator's CreateGradientTexture (flutter/flutter#191980) 2026-09-01 [email protected] Clean up semantics code (flutter/flutter#191620) 2026-08-31 [email protected] Add website documentation item to PR pre-launch checklist (flutter/flutter#192080) 2026-08-31 [email protected] [windows] Fix null-deref in HostWindowPopup::UpdatePosition (Fixes #191478) (flutter/flutter#191479) 2026-08-31 [email protected] Removes deprecated ignoreSemantics parementers (flutter/flutter#191493) 2026-08-31 [email protected] Roll Dart SDK from b319095e317b to 9164def35347 (1 revision) (flutter/flutter#192073) 2026-08-31 [email protected] test: dynamic _tapOutside helper for TapRegion navigation tests (flutter/flutter#185397) 2026-08-31 [email protected] [Windows] fix: Remove quotes from compiler warning suppression (flutter/flutter#190873) 2026-08-31 [email protected] Migrate to listen package (flutter/flutter#189111) 2026-08-31 [email protected] Roll Skia from 15db98a90bbd to 5489a16a5998 (2 revisions) (flutter/flutter#192070) 2026-08-31 [email protected] Add regression test for plugin compileSdkExtension warning (flutter/flutter#191281) 2026-08-31 [email protected] Explicitly disable HCPP in platform view benchmarks and integration tests (flutter/flutter#191908) 2026-08-31 [email protected] Documentation and script for Gradle Distribution cache for CI (flutter/flutter#190323) 2026-08-31 [email protected] Roll Skia from 5549c93c9a1c to 15db98a90bbd (2 revisions) (flutter/flutter#192068) 2026-08-31 [email protected] Roll Packages from cd4cdd0 to d642322 (7 revisions) (flutter/flutter#192063) 2026-08-31 [email protected] Roll Dart SDK from 48f641e8b249 to b319095e317b (1 revision) (flutter/flutter#192061) 2026-08-31 [email protected] [tool] Migrate dev/tools from dart_skills_lint to skills_lint package (flutter/flutter#191997) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#12712) flutter/flutter@c8c5e3b...0cbd1a4 2026-09-01 [email protected] Roll Skia from 6be7f8547c3c to 3911a1fe7f7a (1 revision) (flutter/flutter#192110) 2026-09-01 [email protected] Roll Fuchsia Linux SDK from EPzxifoyt36b5qiBy... to idslm9FikVLy2K_A-... (flutter/flutter#192104) 2026-09-01 [email protected] Roll Skia from 47df2ae3226c to 6be7f8547c3c (1 revision) (flutter/flutter#192103) 2026-09-01 [email protected] Roll Skia from e22ebf131e44 to 47df2ae3226c (4 revisions) (flutter/flutter#192099) 2026-09-01 [email protected] Roll Skia from 5489a16a5998 to e22ebf131e44 (5 revisions) (flutter/flutter#192093) 2026-09-01 [email protected] [flutter_tools] Safely handle broken symlinks and existing files during plugin symlink creation (flutter/flutter#191496) 2026-09-01 [email protected] Support wide gamut colors in gradient_generator's CreateGradientTexture (flutter/flutter#191980) 2026-09-01 [email protected] Clean up semantics code (flutter/flutter#191620) 2026-08-31 [email protected] Add website documentation item to PR pre-launch checklist (flutter/flutter#192080) 2026-08-31 [email protected] [windows] Fix null-deref in HostWindowPopup::UpdatePosition (Fixes #191478) (flutter/flutter#191479) 2026-08-31 [email protected] Removes deprecated ignoreSemantics parementers (flutter/flutter#191493) 2026-08-31 [email protected] Roll Dart SDK from b319095e317b to 9164def35347 (1 revision) (flutter/flutter#192073) 2026-08-31 [email protected] test: dynamic _tapOutside helper for TapRegion navigation tests (flutter/flutter#185397) 2026-08-31 [email protected] [Windows] fix: Remove quotes from compiler warning suppression (flutter/flutter#190873) 2026-08-31 [email protected] Migrate to listen package (flutter/flutter#189111) 2026-08-31 [email protected] Roll Skia from 15db98a90bbd to 5489a16a5998 (2 revisions) (flutter/flutter#192070) 2026-08-31 [email protected] Add regression test for plugin compileSdkExtension warning (flutter/flutter#191281) 2026-08-31 [email protected] Explicitly disable HCPP in platform view benchmarks and integration tests (flutter/flutter#191908) 2026-08-31 [email protected] Documentation and script for Gradle Distribution cache for CI (flutter/flutter#190323) 2026-08-31 [email protected] Roll Skia from 5549c93c9a1c to 15db98a90bbd (2 revisions) (flutter/flutter#192068) 2026-08-31 [email protected] Roll Packages from cd4cdd0 to d642322 (7 revisions) (flutter/flutter#192063) 2026-08-31 [email protected] Roll Dart SDK from 48f641e8b249 to b319095e317b (1 revision) (flutter/flutter#192061) 2026-08-31 [email protected] [tool] Migrate dev/tools from dart_skills_lint to skills_lint package (flutter/flutter#191997) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

reidbaker self-requested a review August 28, 2026 20:59

reidbaker previously approved these changes Aug 28, 2026

View reviewed changes

reidbaker added the CICD Run CI/CD label Aug 28, 2026

Update dev/tools pubspec checksum

d9f2abf

reidbaker dismissed their stale review via d9f2abf August 28, 2026 21:19

flutter-dashboard Bot removed the CICD Run CI/CD label Aug 28, 2026

reidbaker approved these changes Aug 28, 2026

View reviewed changes

reidbaker added the CICD Run CI/CD label Aug 28, 2026

reidbaker-agent marked this pull request as ready for review August 28, 2026 21:30

reidbaker-agent requested a review from jtmcdole as a code owner August 28, 2026 21:30

gemini-code-assist Bot reviewed Aug 28, 2026

View reviewed changes

jtmcdole approved these changes Aug 28, 2026

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2026

auto-submit Bot added this pull request to the merge queue Aug 29, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 29, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2026

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2026

auto-submit Bot added this pull request to the merge queue Aug 31, 2026

Merged via the queue into flutter:master with commit a38c5c6 Aug 31, 2026
37 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2026

reidbaker deleted the migrate-to-skills-lint-pub branch August 31, 2026 16:15

engine-flutter-autoroll mentioned this pull request Sep 1, 2026

Roll Flutter from c8c5e3bd7542 to 0cbd1a4be0a4 (23 revisions) flutter/packages#12712

Merged

Navigation Menu

Repository navigation

[tool] Migrate dev/tools from dart_skills_lint to skills_lint package - #191997

[tool] Migrate dev/tools from dart_skills_lint to skills_lint package#191997
auto-submit[bot] merged 2 commits into
flutter:masterfrom
reidbaker-agent:migrate-to-skills-lint-pub

reidbaker-agent commented Aug 28, 2026 •

edited by reidbaker

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

jtmcdole left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

reidbaker-agent commented Aug 28, 2026 • edited by reidbaker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Agent authored description

Summary of Changes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

jtmcdole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

reidbaker-agent commented Aug 28, 2026 •

edited by reidbaker

Loading