Skip to content

Fix more unresolved doc comment references - #193216

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
szakarias:fix-misc-doc-references
Sep 23, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
szakarias:fix-misc-doc-references

Conversation

@szakarias

Copy link
Copy Markdown
Contributor

Follow-up to #192734 and #193087. These are leftovers: four in packages/flutter/test, which the earlier PRs didn't cover, and a few one-offs.

One fix removes a directive rather than changing a comment:
image_stream.dart doc imported dart:ui, which made [Image] point at dart:ui's Image rather than the widgets library's Image. Nothing needed that doc import: the file's dart:ui references are all prefixed, e.g.[ui.Image] and resolve through its real import.

Towards #192870 — enabling the comment_references lint.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 23, 2026
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. labels Sep 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation comments across several Flutter framework and test files. The changes include adding or removing @DocImport directives, correcting typos (such as fixing MedaiQueryData to MediaQueryData), and refining reference links to improve documentation accuracy and resolve potential doc-linking issues. I have no feedback to provide as there are no review comments.

@szakarias
szakarias requested a review from Piinks September 23, 2026 12:19
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Sep 23, 2026
Merged via the queue into flutter:master with commit ed2392e Sep 23, 2026
23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2026
pull Bot pushed a commit to fucheng-guo-sun/flutter that referenced this pull request Sep 28, 2026
…ter#193283)

Follow-up to flutter#192734, flutter#193087 and flutter#193216, covering the references
inside `lib/src/material` and `lib/src/cupertino`. Doc comment changes
only.

The changes fall into four kinds:
- missing `@docImport` directives
- qualified member references, e.g. `[value]` →
`[MaterialStatesController.value]`
- a constructor parameter in backticks instead of brackets
(`liveRegion`)
- references to names that do not exist, reworded (`child`, `enabled` in
`cupertino/menu_anchor.dart`)

Towards flutter#192870 — enabling the
`comment_references` lint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants