Repository navigation
[Android 17] Updated Templates to AGP 9.3.1 - #193262
Conversation
… 9.3.1, KGP 2.4.20, and Gradle 9.5.0.
There was a problem hiding this comment.
Code Review
This pull request updates the template default Gradle version to 9.5.0, Android Gradle Plugin (AGP) version to 9.3.1, and Kotlin Gradle Plugin (KGP) version to 2.4.20, along with adjusting the version validation logic and updating related tests. Feedback indicates that corresponding version constants and warning thresholds in packages/flutter_tools/gradle/build.gradle.kts and packages/flutter_tools/gradle/src/main/kotlin/DependencyVersionChecker.kt must also be updated to avoid potential build failures or incorrect warnings.
| // See https://mvnrepository.com/artifact/com.android.tools.build/gradle | ||
| const templateAndroidGradlePluginVersion = '9.1.0'; | ||
| const templateAndroidGradlePluginVersionForModule = '9.1.0'; | ||
| const templateAndroidGradlePluginVersion = '9.3.1'; |
There was a problem hiding this comment.
When bumping the template AGP, KGP, and Gradle versions, please ensure that the corresponding version constants and warning thresholds are also updated in packages/flutter_tools/gradle/build.gradle.kts and packages/flutter_tools/gradle/src/main/kotlin/DependencyVersionChecker.kt. These files are currently missing from this pull request, which could lead to build failures or incorrect version warnings.
There was a problem hiding this comment.
It looks like
references the agp version from this file, so there is no longer a need to update this dependency in both files.I am removing the comment.
…ter to AGP 9.3.1 (flutter#193264) **DO NOT MERGE** until this merges: flutter#193262 Bumping Flutter add-to-app Android test apps dependency values to: AGP 9.3.1 KGP 2.4.20 Gradle 9.5.0 Ensuring we are using an AGP version that supports Android 17 (API 37). Partially Addresses flutter#189518 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Updated template values to:
AGP 9.3.1
KGP 2.4.20
Gradle 9.5.0
Ensuring we are using an AGP version that supports Android 17 (API 37).
Partially Addresses #189518
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.