Repository navigation
feat(flutter_tools): migrate Desktop build commands to typed options - #193323
Merged
auto-submit[bot] merged 4 commits intoOct 8, 2026
Merged
Conversation
Migrate `BuildLinuxCommand` (`build linux`) and `BuildWindowsCommand` (`build windows`) to typed `OptionDescriptor`s and `OptionBundle`s: - Add `DesktopBuildOptionsBundle` in `common_options.dart` (encapsulating `CommonBuildOptionsBundle`, `BuildModeOptionsBundle`, `DartCompileOptionsBundle`, `BuildInfoOptions.flavor`, `splitDebugInfo`, `obfuscate`, `extraFrontEndOptions`, `extraGenSnapshotOptions`, `performanceMeasurementFile`, `analyzeSize`, `codeSizeDirectory`, `trackWidgetCreation`, and `configOnly`). - Migrate `BuildLinuxCommand` to `DesktopBuildOptionsBundle`, `DefaultedEnumOptionDescriptor<TargetPlatform>` (`_targetPlatformOption`), and `DefaultedStringOptionDescriptor` (`_targetSysroot`). - Migrate `BuildWindowsCommand` to `DesktopBuildOptionsBundle`. - Remove obsolete `FlutterCommand.addCommonDesktopBuildOptions`.
github-actions
Bot
added
tool
kevmoo
marked this pull request as ready for review
September 25, 2026 04:02
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the desktop build commands for Linux and Windows to use the new DesktopBuildOptionsBundle for registering common build options, removing the deprecated addCommonDesktopBuildOptions helper. Feedback suggests refactoring the _targetPlatformOption in BuildLinuxCommand from a static factory method to a late final instance field to avoid recreating the descriptor when retrieving its value.
…eld on BuildLinuxCommand
bkonyi
approved these changes
Oct 8, 2026
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Oct 8, 2026
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
BuildLinuxCommand(build linux) andBuildWindowsCommand(build windows) to typedOptionDescriptors andOptionBundles (following #191018, #191510, #191760, #192307, #192455, #192524, and #192818):DesktopBuildOptionsBundleincommon_options.dart, encapsulatingCommonBuildOptionsBundle,BuildModeOptionsBundle,DartCompileOptionsBundle,BuildInfoOptions.flavor,splitDebugInfo,obfuscate,extraFrontEndOptions,extraGenSnapshotOptions,performanceMeasurementFile,analyzeSize,codeSizeDirectory,trackWidgetCreation, andconfigOnly.BuildLinuxCommand(build_linux.dart) toDesktopBuildOptionsBundle,DefaultedEnumOptionDescriptor<TargetPlatform>(_targetPlatformOption), andDefaultedStringOptionDescriptor(_targetSysroot), replacing untypedboolArg('config-only'),stringArg('target-platform')!, andstringArg('target-sysroot')!queries.BuildWindowsCommand(build_windows.dart) toDesktopBuildOptionsBundleandgetValue(DesktopBuildOptionsBundle.configOnly).FlutterCommand.addCommonDesktopBuildOptionshelper method fromflutter_command.dart(no remaining callers influtter_tools).Pre-launch Checklist
///).