Repository navigation
feat(flutter_tools): add IntOptionDescriptor and DefaultedIntOptionDescriptor - #192455
Merged
Merged
Conversation
…scriptor Adds IntOptionDescriptor (OptionDescriptor<int?>) and DefaultedIntOptionDescriptor (OptionDescriptor<int>) to option_descriptor.dart. - Parses single-value integer CLI options and throws a descriptive FormatException on invalid numeric strings. - Migrates DebuggingOptionDescriptors.ddsPort, WebOptions.webPort, and WebOptions.webBrowserDebugPort from StringOptionDescriptor to IntOptionDescriptor. - Eliminates redundant manual int.tryParse / int.parse call sites in FlutterCommand.ddsPort and RunCommand. - Adds comprehensive unit tests in option_descriptor_test.dart.
github-actions
Bot
added
the
tool
…ults.getValue - Catches FormatException in SafeArgResults.getValue and calls throwToolExit(e.message) so invalid integer flags (--dds-port=abc, --web-port=abc) exit cleanly instead of triggering unhandled tool crash reports. - Deduplicates integer parsing logic into _IntOptionDescriptorBase._parseValue. - Removes redundant wasParsed(WebOptions.webBrowserDebugPort) check in RunCommandBase. - Adds unit test verifying SafeArgResults.getValue converts FormatException into ToolExit.
kevmoo
marked this pull request as ready for review
September 9, 2026 00:16
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces IntOptionDescriptor and DefaultedIntOptionDescriptor to natively support integer command-line options, replacing manual string parsing for options such as dds-port, web-port, and web-browser-debug-port. Additionally, SafeArgResults.getValue is updated to catch FormatException and throw a ToolExit. The review feedback suggests restricting the defaultsTo parameter type to int? in the _IntOptionDescriptorBase constructor to ensure compile-time type safety.
harryterkelsen
previously requested changes
Sep 9, 2026
bkonyi
reviewed
Sep 9, 2026
bkonyi
left a comment
bkonyi
left a comment
Contributor
There was a problem hiding this comment.
LGTM other than the DDS port concern.
…default 0 - Updates DebuggingOptionDescriptors.ddsPort from IntOptionDescriptor to DefaultedIntOptionDescriptor with defaultsTo: 0. - Simplifies FlutterCommand.ddsPort to directly return getValue(DebuggingOptionDescriptors.ddsPort) when explicit ddsPort or fallback random port 0 is used.
bkonyi
approved these changes
Sep 9, 2026
Contributor
|
autosubmit label was removed for flutter/flutter/192455, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 10, 2026
8 of 9 tasks
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Oct 8, 2026
…lutter#193323) Migrate `BuildLinuxCommand` (`build linux`) and `BuildWindowsCommand` (`build windows`) to typed `OptionDescriptor`s and `OptionBundle`s (following flutter#191018, flutter#191510, flutter#191760, flutter#192307, flutter#192455, flutter#192524, and flutter#192818): - Add `DesktopBuildOptionsBundle` in `common_options.dart`, encapsulating `CommonBuildOptionsBundle`, `BuildModeOptionsBundle`, `DartCompileOptionsBundle`, `BuildInfoOptions.flavor`, `splitDebugInfo`, `obfuscate`, `extraFrontEndOptions`, `extraGenSnapshotOptions`, `performanceMeasurementFile`, `analyzeSize`, `codeSizeDirectory`, `trackWidgetCreation`, and `configOnly`. - Migrate `BuildLinuxCommand` (`build_linux.dart`) to `DesktopBuildOptionsBundle`, `DefaultedEnumOptionDescriptor<TargetPlatform>` (`_targetPlatformOption`), and `DefaultedStringOptionDescriptor` (`_targetSysroot`), replacing untyped `boolArg('config-only')`, `stringArg('target-platform')!`, and `stringArg('target-sysroot')!` queries. - Migrate `BuildWindowsCommand` (`build_windows.dart`) to `DesktopBuildOptionsBundle` and `getValue(DesktopBuildOptionsBundle.configOnly)`. - Delete the obsolete `FlutterCommand.addCommonDesktopBuildOptions` helper method from `flutter_command.dart` (no remaining callers in `flutter_tools`). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds IntOptionDescriptor (OptionDescriptor<int?>) and DefaultedIntOptionDescriptor (OptionDescriptor) to option_descriptor.dart.