[flutter_tools] Include dev_dependencies hooks for release integration tests by dcharkes · Pull Request #193436 · flutter/flutter

dcharkes · 2026-09-28T09:13:51Z

When running release-mode tests (such as flutter test integration_test --release), createFlutterNativeAssetsBuildRunner previously set includeDevDependencies = !buildMode.isRelease, which excluded hooks from dev_dependencies.

Bug:

hook/build.dart Data assets support #146264

Changes

Check _isTestTarget(environment) (whether kTargetFile is under integration_test/, test_driver/, or test/) so includeDevDependencies is true for test targets even in release mode.
Add a unit test in native_assets_test.dart verifying includeDevDependencies is false for lib/main.dart in release mode and true for integration_test/app_test.dart, test_driver/app.dart, and test/app_test.dart.

PR Stack

#	PR	Branch	Commit
1	#193434	`data-assets-empty-pubspec`	`ab37f42`
2	#193435	`data-assets-flutter-test`	`4956c97`
3	👉 #193436 (this PR)	`data-assets-dev-dependencies-release-test`	`596124d`
4	#193437	`data-assets-widget-preview`	`bd246d9`

Pre-launch Checklist

dcharkes · 2026-09-28T10:20:39Z

  );
 }
+
+bool _isTestTarget(Environment environment) {


@bkonyi I am surprised we have nothing like this yet in the codebase. It seems that the usual logic on dev deps or not is dependent on release mode, but that is too strict if you want to use dev deps in tests or integration tests in release mode.

There is no existing shared helper in flutter_tools that checks whether kTargetFile is a test target across integration_test/, test_driver/, and test/:

_shouldRunAsIntegrationTests in test.dart only checks integration_test/.

DriveCommand.runCommand in drive.dart only checks _fileSystem.path.isWithin('test_driver', targetFile) for an error message.

RunCommand in run.dart only checks targetFile.endsWith('_test.dart') for analytics.

The closest related helper in flutter_tools is PackageConfigWorkspaceExtension.toPackageUriForWorkspace (used in WebEntrypointTarget.build and KernelCompiler.compile), which returns null whenever the entrypoint is outside lib/.

…mpty (flutter#193434) When `flutterManifest.isEmpty` (for example, a `pubspec.yaml` without a `flutter:` section), `ManifestAssetBundle.build` previously returned early with an empty `AssetManifest.bin`, ignoring any data assets produced by build/link hooks (`flutterHookResult.dataAssets`). Bug: * flutter#146264 ### Changes - Only short-circuit with an empty manifest in `ManifestAssetBundle.build` when both `flutterManifest.isEmpty` and `flutterHookResult?.dataAssets.isEmpty ?? true`. - Skip `computeTransitiveDependencies` when `flutterManifest.isEmpty`. - Add a unit test in `asset_bundle_test.dart` verifying that data assets from hooks are bundled when `pubspec.yaml` is empty. ### PR Stack | # | PR | Branch | Commit | | :-: | :--- | :--- | :--- | | **1** | **👉 flutter#193434 (this PR)** | `data-assets-empty-pubspec` | flutter@62199c4 | | 2 | flutter#193435 | `data-assets-flutter-test` | flutter@25be1ab | | 3 | flutter#193436 | `data-assets-dev-dependencies-release-test` | flutter@79abad9 | | 4 | flutter#193437 | `data-assets-widget-preview` | flutter@98f1001 | ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…r#193435) Previously, `flutter test` ran native assets hooks via `TestCompilerNativeAssetsBuilder.build(buildInfo)`, which only returned the `NativeAssetsManifest.json` URI and discarded the `FlutterHookResult` containing hook-generated data assets. Bug: * flutter#146264 ### Changes - Add `buildWithHookResult` to `TestCompilerNativeAssetsBuilder` returning both `nativeAssetsManifest` and `flutterHookResult`. - Pass `flutterHookResult` to `_buildTestAsset` / `assetBundle.build` in `TestCommand`. - Update `TestCommand._needsRebuild` to check if bundled asset files exist on disk, guard `pub.existsSync()`, and check `flutterHookResult.dependencies` modification timestamps. - Add a hermetic test in `test_test.dart` verifying that `flutter test` bundles data assets from hooks into `build/unit_test_assets`. ### PR Stack | # | PR | Branch | Commit | | :-: | :--- | :--- | :--- | | 1 | flutter#193434 | `data-assets-empty-pubspec` | flutter@62199c4 | | **2** | **👉 flutter#193435 (this PR)** | `data-assets-flutter-test` | flutter@390c757 | | 3 | flutter#193436 | `data-assets-dev-dependencies-release-test` | flutter@cca04e9 | | 4 | flutter#193437 | `data-assets-widget-preview` | flutter@0a5a8e9 | > **Note:** This PR is stacked on flutter#193434. To review only this PR's diff before the base PR lands, view commit flutter@390c757. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request updates the native assets build runner to include dev dependencies for release test targets, such as those located in the integration_test, test_driver, or test directories, and adds corresponding tests. Feedback suggests wrapping the relative path calculation in a try-catch block to prevent potential PathException crashes on Windows when paths are on different drives, as well as using triple-slash (///) comments for private member documentation per the style guide.

gemini-code-assist · 2026-10-02T14:38:50Z

+bool _isTestTarget(Environment environment) {
+  final String? targetFile = environment.defines[kTargetFile];
+  if (targetFile == null) {
+    return false;
+  }
+  final String absoluteTargetPath = environment.fileSystem.path.isAbsolute(targetFile)
+      ? targetFile
+      : environment.fileSystem.path.join(environment.projectDir.path, targetFile);
+  final String relativePath = environment.fileSystem.path.relative(
+    environment.fileSystem.path.normalize(absoluteTargetPath),
+    from: environment.projectDir.path,
+  );
+  final List<String> parts = environment.fileSystem.path.split(relativePath);
+  return parts.isNotEmpty &&
+      const <String>{'integration_test', 'test_driver', 'test'}.contains(parts.first);
+}


To prevent potential crashes on Windows when targetFile and environment.projectDir.path are on different drives (which causes path.relative to throw a PathException), we should wrap the relative path computation in a try-catch block.

Additionally, per the Flutter Style Guide, we should use /// for public-quality documentation, even on private members.

/// Returns whether the target file in the [environment] is a test target. /// /// This checks if the target file is located within the test, test_driver, /// or integration_test directories of the project. bool _isTestTarget(Environment environment) { final String? targetFile = environment.defines[kTargetFile]; if (targetFile == null) { return false; } final String absoluteTargetPath = environment.fileSystem.path.isAbsolute(targetFile) ? targetFile : environment.fileSystem.path.join(environment.projectDir.path, targetFile); try { final String relativePath = environment.fileSystem.path.relative( environment.fileSystem.path.normalize(absoluteTargetPath), from: environment.projectDir.path, ); final List<String> parts = environment.fileSystem.path.split(relativePath); return parts.isNotEmpty && const <String>{'integration_test', 'test_driver', 'test'}.contains(parts.first); } catch (_) { return false; } }

References

Use /// for public-quality documentation, even on private members. ^(link)

path.relative across drives on Windows (try-catch) — False (Python hallucination):

Unlike Python's os.path.relpath (which raises ValueError across drives), Dart's package:path Context.relative does not throw a PathException when two absolute paths are on different Windows drives (C:\... vs D:\...).

Instead, package:path checks if (fromParsed.root != pathParsed.root) return path; and simply returns D:\... unchanged, so parts.first is 'D:\\' and _isTestTarget returns false.

(Context.relative only throws PathException if a root-relative Windows path like \foo without a drive letter is compared against C:\bar when current has no drive letter.)

bkonyi

LGTM overall with one question.

bkonyi · 2026-10-05T19:11:55Z

  }
+
+  testUsingContext(
+    'createFlutterNativeAssetsBuildRunner includes dev dependencies for release test targets',


Do we need another case here for test/?

…n tests

bkonyi

LGTM!

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 28, 2026

This was referenced Sep 28, 2026

[flutter_tools] Include data assets from hooks when pubspec.yaml is empty #193434

Merged

[flutter_tools] Bundle data assets from hooks in flutter test #193435

Merged

[flutter_tools] Reload widget-preview when data assets change #193437

Draft

dcharkes force-pushed the data-assets-dev-dependencies-release-test branch from ce610e8 to 79abad9 Compare September 28, 2026 09:58

dcharkes commented Sep 28, 2026

View reviewed changes

dcharkes added the CICD Run CI/CD label Sep 28, 2026

dcharkes requested a review from bkonyi September 28, 2026 10:20

dcharkes force-pushed the data-assets-dev-dependencies-release-test branch 6 times, most recently from 4e9c425 to 76799a8 Compare October 1, 2026 09:40

dcharkes force-pushed the data-assets-dev-dependencies-release-test branch from 76799a8 to bd93510 Compare October 2, 2026 14:33

dcharkes marked this pull request as ready for review October 2, 2026 14:37

gemini-code-assist Bot reviewed Oct 2, 2026

View reviewed changes

bkonyi previously approved these changes Oct 5, 2026

View reviewed changes

[flutter_tools] Include dev_dependencies hooks for release integratio…

596124d

…n tests

dcharkes dismissed bkonyi’s stale review via 596124d October 6, 2026 08:15

dcharkes force-pushed the data-assets-dev-dependencies-release-test branch from bd93510 to 596124d Compare October 6, 2026 08:15

dcharkes requested a review from bkonyi October 6, 2026 08:35

bkonyi approved these changes Oct 6, 2026

View reviewed changes

dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2026

auto-submit Bot added this pull request to the merge queue Oct 12, 2026

Navigation Menu

Repository navigation

[flutter_tools] Include dev_dependencies hooks for release integration tests - #193436

[flutter_tools] Include dev_dependencies hooks for release integration tests#193436
dcharkes wants to merge 1 commit into
flutter:masterfrom
dcharkes:data-assets-dev-dependencies-release-test

dcharkes commented Sep 28, 2026 •

edited

Loading

Uh oh!

dcharkes Sep 28, 2026

Uh oh!

dcharkes Sep 28, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Oct 2, 2026

Uh oh!

dcharkes Oct 2, 2026

Uh oh!

bkonyi left a comment

Uh oh!

bkonyi Oct 5, 2026

Uh oh!

bkonyi left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dcharkes commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

PR Stack

Pre-launch Checklist

Uh oh!

dcharkes Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

dcharkes Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

dcharkes Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

bkonyi Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dcharkes commented Sep 28, 2026 •

edited

Loading