Skip to content

[H] Cleanup - #21542

Merged
Hixie merged 2 commits into
flutter:masterfrom
Hixie:cleanup
Sep 22, 2018
Merged

Hixie merged 2 commits into
flutter:masterfrom
Hixie:cleanup

Conversation

@Hixie

@Hixie Hixie commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

A small variety of trivial changes.

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The analyzer rightfully complains that MyDataObject is not a thing.

@Hixie Hixie changed the title Cleanup [H] Cleanup Sep 19, 2018
The phrase "note that" is basically meaningless as a prefix to an
otherwise fine sentence.
@Hixie
Hixie merged commit 989cf18 into flutter:master Sep 22, 2018
@Hixie
Hixie deleted the cleanup branch September 22, 2018 09:02
hereisderek added a commit to hereisderek/flutter that referenced this pull request Sep 27, 2018
…dle-fix

* commit 'adcf226e2ac585700fde5706666db351622a08a6':
  Roll engine f3a3d0c..57fd394 (1 commits) (flutter#22176)
  expose the debugProfileBuildsEnabled flag as a service extension (flutter#21492)
  [H] Cleanup (flutter#21542)
  Roll engine cc3009c..f3a3d0c (5 commits) (flutter#22162)
  Roll engine a8890fd to 8471862 (flutter#22153)
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants