Skip to content

Make FlexibleSpaceBar title offset more flexible. - #22548

Closed
showang wants to merge 3 commits into
flutter:masterfrom
showang:master
Closed

showang wants to merge 3 commits into
flutter:masterfrom
showang:master

Conversation

@showang

@showang showang commented Oct 2, 2018 •

Copy link
Copy Markdown

Customize left padding of FlexibleSpaceBar title by titleStartOffset parameter.
screen shot 2018-10-03 at 2 33 00 pm

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@showang showang closed this Oct 2, 2018
@showang showang reopened this Oct 2, 2018
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 2, 2018
@filipproch

Copy link
Copy Markdown

Hi @showang , I am also looking to implement such change, but as I see, now your PR has a merge issue, can you check it and update it? I didn't notice your PR first so I implemented it myself also, but would make sense if you still plan to go forward, I will close my PR in favor of yours.

@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Nov 28, 2018
@HansMuller

Copy link
Copy Markdown
Contributor

First of all: I apologize for how long it's taken to get to this PR. It looks like it's been about 4 months which is a record, but not a good one.

I've moved the change to a new PR: #27623 which accomplishes the same thing in terms of a newtitlePadding parameter. I'm closing this PR in favor of the new one. With any luck the new one will land later this week.

So thank you for the contribution and, again, sorry that it's taken so long to move it along.

@HansMuller HansMuller closed this Feb 7, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants