Skip to content

Make FlexibleSpaceBar title padding configurable - #27623

Merged
HansMuller merged 1 commit into
flutter:masterfrom
HansMuller:flexible_spacebar_title_insets
Feb 8, 2019
Merged

Make FlexibleSpaceBar title padding configurable#27623
HansMuller merged 1 commit into
flutter:masterfrom
HansMuller:flexible_spacebar_title_insets

Conversation

@HansMuller

@HansMuller HansMuller commented Feb 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

An earlier version of these changes was contributed by @showang in #22548

Fixes #23864
Fixes #11951
Fixes #9212

@HansMuller HansMuller mentioned this pull request Feb 7, 2019
Closed
@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Feb 7, 2019
@zoechi

zoechi commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

Does this fix #23864?
Others that look related #11951, #11954, #9212

@HansMuller

HansMuller commented Feb 7, 2019

Copy link
Copy Markdown
Contributor Author

@zoechi Thanks for looking up the related bugs, this PR does address 3 of them. I've updated the description.

@HansMuller HansMuller added waiting for PR to land (fixed) A fix is in flight and removed waiting for PR to land (fixed) A fix is in flight labels Feb 7, 2019
@gspencergoog

gspencergoog commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@HansMuller
HansMuller merged commit 022f7d8 into flutter:master Feb 8, 2019
@HansMuller
HansMuller deleted the flexible_spacebar_title_insets branch February 8, 2019 18:45
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
Hans Muller @kangwang1988
Make FlexibleSpaceBar title padding configurable (flutter#27623)
536e4ac
@jayasio

jayasio commented Jun 28, 2019

Copy link
Copy Markdown

When titlePadding is set to something like EdgeInsetsDirectional.only(start: 16.0, bottom: 16.0) and if the FlexibleSpaceBar has a leading widget, they just overlap. Is there a way to animate the title to it's place in the default AppBar layout?
Screenshot (30)
Screenshot (31)

@hardypatel30

hardypatel30 commented Dec 9, 2019

Copy link
Copy Markdown

@jayasio Found any solution? Even I am also facing the same issue.

@hardypatel30

hardypatel30 commented Dec 21, 2019

Copy link
Copy Markdown

@jayasio Can find answer here.

https://stackoverflow.com/questions/59243525/sliver-appbar-collapsing-toolbar-animate-title-from-left-to-center-in-flutter/59434248#59434248

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

6 participants

@HansMuller @zoechi @gspencergoog @jayasio @hardypatel30 @googlebot