Skip to content

Log received messages for exceptions as well as timeouts - #23287

Merged
DanTup merged 1 commit into
flutter:masterfrom
DanTup:log-exceptions-plus-timeouts
Oct 24, 2018
Merged

Log received messages for exceptions as well as timeouts#23287
DanTup merged 1 commit into
flutter:masterfrom
DanTup:log-exceptions-plus-timeouts

Conversation

@DanTup

@DanTup DanTup commented Oct 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

The code previously only included the recent messages received in the error message for a timeout. This changes it to output for all exceptions to make it easier to understand errors like #19273 (comment).

Before:

00:19 +0 -1: hot reload works without error [E]                                                                                                                
  Received app.stop event while waiting for app.started event.
  
  test/integration/test_driver.dart 362:7   FlutterTestDriver._timeoutWithMessages.<fn>
  ===== asynchronous gap ===========================
  dart:async                                Future.catchError
  test/integration/test_driver.dart 361:8   FlutterTestDriver._timeoutWithMessages
  test/integration/test_driver.dart 339:12  FlutterTestDriver._waitFor
  ===== asynchronous gap ===========================
  dart:async                                _asyncThenWrapperHelper
  test/integration/test_driver.dart         FlutterTestDriver._setupProcess
  test/integration/test_driver.dart 60:11   FlutterTestDriver.run

After:

00:19 +0 -1: hot reload works without error [E]                                                                                                                
  Received app.stop event while waiting for app.started event.
  
  
  Received:
  [+   195] [{"event":"app.start","params":{"appId":"81a63a61-3820-4cf1-b7ad-7df5fe0f74ab","deviceId":"flutter-tester","directory":"/private/var/folders/8r/5r4vmgn94h9fy343vxdvr4_r00hbgw/T/flutter_hot_reload_test_app.ZvM5t6","supportsRestart":true}}]
  [+   793] Launching lib/main.dart on Flutter test device in debug mode...
  [+  5152] topLevelFunction
  [+  5244] [{"event":"app.debugPort","params":{"appId":"81a63a61-3820-4cf1-b7ad-7df5fe0f74ab","port":50874,"wsUri":"ws://127.0.0.1:50874/ws","baseUri":"file:///var/folders/8r/5r4vmgn94h9fy343vxdvr4_r00hbgw/T/flutter_hot_reload_test_app.ZvM5t6uKdtGb/flutter_hot_reload_test_app.ZvM5t6/"}}]
  [+  5289] [{"event":"app.progress","params":{"appId":"81a63a61-3820-4cf1-b7ad-7df5fe0f74ab","id":"0","progressId":null,"message":"Syncing files to device Flutter test device..."}}]
  [+  8861] [{"event":"app.progress","params":{"appId":"81a63a61-3820-4cf1-b7ad-7df5fe0f74ab","id":"0","progressId":null,"finished":true}}]
  [+  8870] [{"event":"app.started","params":{"appId":"81a63a61-3820-4cf1-b7ad-7df5fe0f74ab"}}]
  [+ 10445] Lost connection to device.
  [+ 10709] [{"event":"app.stop","params":{"appId":"81a63a61-3820-4cf1-b7ad-7df5fe0f74ab"}}]
  
  test/integration/test_driver.dart 362:7   FlutterTestDriver._timeoutWithMessages.<fn>
  ===== asynchronous gap ===========================
  dart:async                                Future.catchError
  test/integration/test_driver.dart 361:8   FlutterTestDriver._timeoutWithMessages
  test/integration/test_driver.dart 339:12  FlutterTestDriver._waitFor
  ===== asynchronous gap ===========================
  dart:async                                _asyncThenWrapperHelper
  test/integration/test_driver.dart         FlutterTestDriver._setupProcess
  test/integration/test_driver.dart 60:11   FlutterTestDriver.run

@DanTup DanTup mentioned this pull request Oct 19, 2018
Closed
@gspencergoog

gspencergoog commented Oct 19, 2018

Copy link
Copy Markdown
Contributor

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@DanTup
DanTup merged commit 9dfc0f3 into flutter:master Oct 24, 2018
@DanTup
DanTup deleted the log-exceptions-plus-timeouts branch October 24, 2018 06:22
Xavjer pushed a commit to Xavjer/flutter that referenced this pull request Oct 24, 2018
@DanTup @Xavjer
Log received messages for exceptions as well as timeouts (flutter#23287)
1196d48
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanTup @gspencergoog @googlebot