Repository navigation
Re-land "Initial framework support for iOS platform views." - #23781
Merged
Merged
Conversation
Contributor
Author
liyuqian
approved these changes
Oct 31, 2018
liyuqian
left a comment
liyuqian
left a comment
Contributor
There was a problem hiding this comment.
The change related with the retained rendering looks good to me.
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Nov 1, 2018
…23781) Re-landing flutter#23412 with a fix to the PlatformLayer's addToScene signature. flutter#23412 was broken by the change to Layer done in flutter#23434. It seemed green as the presubmits were done before flutter#23434 was landed, and when flutter#23412 landed it broke the build. Reverts flutter#23779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-landing #23412 with a fix to the PlatformLayer's addToScene signature.
#23412 was broken by the change to Layer done in #23434.
It seemed green as the presubmits were done before #23434 was landed, and when #23412 landed it broke the build.
Reverts #23779