Repository navigation
Revert "Revert "obscureText and enableInteractiveSelection defaults"" - #25342
Merged
justinmc merged 7 commits intoDec 17, 2018
Merged
Conversation
This reverts commit 01694ab.
…d (1 commits) (flutter-team-archive/engine#7211) (#25333)" This reverts commit a37099f.
Contributor
Author
|
@HansMuller Check out the 4 lines I removed in main_test.dart to get the test to work. |
zoechi
added
a: text input
justinmc
deleted the
revert-25335-revert-24527-text-field-obscured-copiable
branch
December 17, 2018 19:15
Contributor
|
I encourage you to read https://github.com/flutter/flutter/wiki/Tree-hygiene (notably, please see the section on revert commits -- for clarity, we'd like to avoid having more than one "revert" per commit message). |
Contributor
Author
|
Whoops missed that one, thanks for the reminder 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #25335
Revert of a reverted PR. It was reverted due to a device lab test failure. I've fixed the failure and am resubmitting.