Skip to content

Use stderr instead of stdout to contain errors in flutter attach test - #25305

Merged
DaveShuckerow merged 1 commit into
masterfrom
DaveShuckerow-flutter-attach-test-fix
Dec 13, 2018
Merged

DaveShuckerow merged 1 commit into
masterfrom
DaveShuckerow-flutter-attach-test-fix

Conversation

@DaveShuckerow

Copy link
Copy Markdown
Contributor

Fixes #25304

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoechi zoechi added the a: tests "flutter test", flutter_test, or one of our tests label Dec 13, 2018
@DaveShuckerow
DaveShuckerow merged commit 2b819dd into master Dec 13, 2018
justinmc added a commit that referenced this pull request Dec 13, 2018
jonahwilliams pushed a commit that referenced this pull request Dec 14, 2018
@jonahwilliams

Copy link
Copy Markdown
Contributor

This PR did not address the Method not found error which has been fairly consistently printed to stdout for a while now. It's not clear to me what the fix is

justinmc added a commit that referenced this pull request Dec 17, 2018
…#25342)

* Revert "Add imports section to sample code templates, and more docs. (#25184)"

This reverts commit 95b0124.

* Revert "Use stderr instead of stdout to contain errors in flutter attach test (#25305)"

This reverts commit 2b819dd.

* Revert "Allow detection of taps on TabBar (#23919)"

This reverts commit 01694ab.

* Revert "a549981da Roll src/third_party/skia a69b10312977..5eb29448dfbd (1 commits) (flutter-team-archive/engine#7211) (#25333)"

This reverts commit a37099f.

* Revert "Revert "obscureText and enableInteractiveSelection defaults (#24527)" (#25335)"

This reverts commit c545706.

* Password fields are no longer selectable nor copiable
@goderbauer
goderbauer deleted the DaveShuckerow-flutter-attach-test-fix branch January 2, 2019 18:28
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential issue in flutter_attach_test.dart

5 participants