Skip to content

Revert "Adds support for floating cursor" - #25352

Merged
jonahwilliams merged 1 commit into
masterfrom
revert-24761-force-cursor
Dec 14, 2018
Merged

Revert "Adds support for floating cursor"#25352
jonahwilliams merged 1 commit into
masterfrom
revert-24761-force-cursor

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Dec 14, 2018

Copy link
Copy Markdown
Contributor

Reverts #24761

The floating cursor test is pretty broken:

  EditableTextState#a8f1d(tickers: tracking 1 ticker))>
   Which: did not match the pattern.
          It called drawRRect with RRect, RRect.fromLTRBR(464.5, -0.0, 467.5, 16.0, 1.0), which was
          not exactly the expected RRect (RRect.fromLTRBR(406.5, 0.0, 409.5, 14.0, 1.0)).

cc @jslavitz

@jonahwilliams

jonahwilliams commented Dec 14, 2018

Copy link
Copy Markdown
Contributor Author

TBR @xster

@jonahwilliams
jonahwilliams requested a review from xster December 14, 2018 04:35
@jonahwilliams

jonahwilliams commented Dec 14, 2018

Copy link
Copy Markdown
Contributor Author

Landing on red to fi build

@jonahwilliams
jonahwilliams merged commit 4cd8770 into master Dec 14, 2018
@jonahwilliams
jonahwilliams deleted the revert-24761-force-cursor branch December 14, 2018 04:36
@xster

xster commented Dec 14, 2018

Copy link
Copy Markdown
Member

LGTM

@zoechi zoechi added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages p: cupertino_ui cupertino_ui package in flutter/packages labels Dec 14, 2018
jonahwilliams pushed a commit that referenced this pull request Dec 14, 2018
Jonah Williams
Revert "Revert "Adds support for floating cursor (#24761)" (#25352)"
162205d 
This reverts commit 4cd8770.
@lucien144 lucien144 mentioned this pull request Jul 31, 2020
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster Awaiting requested review from xster

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @xster @zoechi @googlebot