Skip to content

Reland "Call mark* methods before attaching child (#25239)" - #25395

Merged
goderbauer merged 1 commit into
flutter:masterfrom
goderbauer:relandreland
Dec 15, 2018
Merged

goderbauer merged 1 commit into
flutter:masterfrom
goderbauer:relandreland

Conversation

@goderbauer

@goderbauer goderbauer commented Dec 15, 2018 •

Copy link
Copy Markdown
Member

This reverts commit ea7d086.

The revert did not fix the flakiness.

Fixes #24029 (again).

This reverts commit ea7d086.

The revert did not fix the flakiness.

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
goderbauer merged commit 59bfab1 into flutter:master Dec 15, 2018
@goderbauer
goderbauer deleted the relandreland branch December 15, 2018 21:30
@zoechi zoechi added the framework flutter/packages/flutter repository. See also f: labels. label Dec 16, 2018
@goderbauer goderbauer added the c: crash Stack traces logged to the console label Feb 22, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: crash Stack traces logged to the console framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

markNeedsCompositingBitsUpdate fails after re-attaching a RepaintBoundary

4 participants