Repository navigation
Call mark* methods before attaching child - #25239
Merged
Merged
Conversation
zoechi
added
the
framework
Contributor
|
|
goderbauer
added a commit
to goderbauer/flutter
that referenced
this pull request
Dec 14, 2018
This reverts commit 5c1f1d7. Reverting to see if that fixes flakiness of flutter_gallery__transition_perf_with_semantics in devicelab.
goderbauer
added a commit
that referenced
this pull request
Dec 14, 2018
goderbauer
added a commit
to goderbauer/flutter
that referenced
this pull request
Dec 15, 2018
This reverts commit ea7d086. The revert did not fix the flakiness.
goderbauer
added a commit
that referenced
this pull request
Dec 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows children to assume that their parents are already in a valid state. In particular,
markNeedsCompositingBitsUpdatemakes assumptions about the parent's dirty state that may not be true if a child is attached before the parent has been marked as dirty. See #24029 (comment) for a detailed description of the root cause for that bug.Fixes #24029.