Skip to content

targetSdkVersion 28 - #26798

Merged
dnfield merged 1 commit into
flutter:masterfrom
dnfield:master
Jan 19, 2019
Merged

dnfield merged 1 commit into
flutter:masterfrom
dnfield:master

Conversation

@dnfield

@dnfield dnfield commented Jan 19, 2019

Copy link
Copy Markdown
Contributor

I should have bumped this up with the last PR that bumped compileSdkVersion.

This is less essential because CI is passing now, but I think it's technically incorrect to have this be lower than compileSdkVersion.

@dnfield
dnfield requested review from amirh and mklim January 19, 2019 06:24
@dnfield dnfield added c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-android Android applications specifically labels Jan 19, 2019
@dnfield

dnfield commented Jan 19, 2019

Copy link
Copy Markdown
Contributor Author

This is not fixing CI. It ends up complaining that it can't find (licenses?) for Android-27. I'm not sure why it's looking for Android-27.

@fkorotkov - could this be an issue with the Docker container for Flutter? Or is there something we're missing here that's still looking for Platform 27?

@fkorotkov

Copy link
Copy Markdown
Contributor

@dnfield it might a question to whom created gcr.io/flutter-cirrus/build-flutter-image:latest. You might want to update it. 😅

@dnfield

dnfield commented Jan 19, 2019

Copy link
Copy Markdown
Contributor Author

I just did updated that one yesterday. I'll see if I can add platform 27 to it.....

@dnfield

dnfield commented Jan 19, 2019

Copy link
Copy Markdown
Contributor Author

Sorry, I missed that that image was based on ours. And Gradle is confusing :D

@mklim mklim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dnfield
dnfield merged commit d8d36bc into flutter:master Jan 19, 2019
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-android Android applications specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants