Repository navigation
Table widget - #2961
Merged
Merged
Table widget#2961
Conversation
Hixie
added a commit
to Hixie/mahogony-staircase
that referenced
this pull request
Mar 29, 2016
Also, analyze everything. This will break the build until flutter/flutter#2961 lands.
- Add x and y to the parent data, in case it's useful. In point of fact, I ended up not needing it. - Make columnWidths settable rather than having a setter so that the code in the widgets layer is more idiomatic. - Teach setFlatChildren about avoiding unnecessary drop/adopt loops. - Assert that the child list length is correct more aggressively so that we catch the dumb bug I had more quickly next time. - Improve the toString() to handle empty tables better. - Resort the imports in framework.dart. - Introduce a LocalKey for cases where you don't want to allow use of GlobalKey. - Make inflateWidget and deactivateChild public for subclass use. - Table widget. - Cell widget. - TableRow fake widget.
Contributor
Author
|
WRITE TESTS |
Contributor
|
LGTM |
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ended up not needing it.
code in the widgets layer is more idiomatic.
we catch the dumb bug I had more quickly next time.
GlobalKey.