Cupertino localization step 12: push translation for all supported languages by xster · Pull Request #31644 · flutter/flutter

xster · 2019-04-26T05:02:28Z

When making change suggestions, please double check in iOS so I can justify it with our translators.

xster · 2019-05-01T23:46:18Z

Pending another xml push into TC before pulling again

xster · 2019-05-03T19:27:52Z

@@ -0,0 +1,22 @@
+{
+  "todayLabel": "a temporary hack",


the latin script in this file is a placeholder while the remaining 3 strings are being translated

xster · 2019-05-03T19:28:03Z

@@ -0,0 +1,22 @@
+{
+  "todayLabel": "a temporary hack",


the latin script in this file is a placeholder while the remaining 3 strings are being translated

lgfranco

I made the changes to reflect the iOS in pt and pt_PT

lgfranco · 2019-05-03T20:29:56Z

@@ -0,0 +1,22 @@
+{
+  "todayLabel": "Hoje",
+  "datePickerHourSemanticsLabelOne": "$hour em ponto",


"$hour hora"

Suggested change

"datePickerHourSemanticsLabelOne": "$hour em ponto",

"datePickerHourSemanticsLabelOne": "$hour hora",

Thanks for diff'ing and reviewing. We'll backport these into the translation console

I assume these are both for brazilian and portugal portuguese?

Yes, the use of "em ponto" is not for this situation.

The use wold be for something like 8 o'clock (8 "horas em ponto").

lgfranco · 2019-05-03T20:33:34Z

+  "timerPickerHourLabelOther": "horas",
+  "timerPickerMinuteLabelOne": "min",
+  "timerPickerMinuteLabelOther": "min",
+  "timerPickerSecondLabelOne": "s",


The correct would be s but the iOS writes "seg" in this locale.

Suggested change

"timerPickerSecondLabelOne": "s",

"timerPickerSecondLabelOne": "seg",

lgfranco · 2019-05-03T20:38:19Z

+  "timerPickerHourLabelOther": "horas",
+  "timerPickerMinuteLabelOne": "min",
+  "timerPickerMinuteLabelOther": "min",
+  "timerPickerSecondLabelOne": "seg",


Suggested change

"timerPickerSecondLabelOne": "seg",

"timerPickerSecondLabelOne": "s",

Seems like you're suggesting opposite things between here and the same label in the previous file.

Yes, for some reason the iOS abbreviates seconds in different ways in pt and pt_PT.

I changed my iPhone to pt_PT, accessed the Timer (in the clock App), and used the strings I found there.

lgfranco · 2019-05-03T20:38:32Z

+  "timerPickerMinuteLabelOne": "min",
+  "timerPickerMinuteLabelOther": "min",
+  "timerPickerSecondLabelOne": "seg",
+  "timerPickerSecondLabelOther": "seg",


Suggested change

"timerPickerSecondLabelOther": "seg",

"timerPickerSecondLabelOther": "s",

HansMuller

RSLGTM

Translation feedback will have to be funneled through the Google TC

lgfranco · 2019-05-07T20:33:58Z

pt_PT examples
https://photos.app.goo.gl/121XPagGJbiGS1C46

pt examples
https://photos.app.goo.gl/CV4xU75wqF1n8ZPL7

xster · 2019-05-10T06:18:52Z

I'm merging this one in for now. The feedback received will cycle through via another update once the TC translations are internalized.

…orted languages (#31644)" This reverts commit 10922df.

…orted languages (#31644)" (#32470) This reverts commit 10922df.

xster requested a review from HansMuller April 26, 2019 05:02

googlebot added the cla: yes label Apr 26, 2019

goderbauer added p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Apr 29, 2019

xster added the work in progress; do not review label May 1, 2019

xster added 2 commits May 3, 2019 14:54

Push translations from TC

9da5e12

update from new TC

9cbf088

xster force-pushed the push branch from 313900b to 9cbf088 Compare May 3, 2019 18:54

xster added 3 commits May 3, 2019 15:08

more update from TC

082ba40

more update from TC

52cf071

generate

c48f71f

xster removed the work in progress; do not review label May 3, 2019

xster changed the title ~~Push translations from TC~~ Cupertino localization step 12: push translation for all supported languages May 3, 2019

xster added the a: internationalization Supporting other languages or locales. (aka i18n) label May 3, 2019

xster commented May 3, 2019

View reviewed changes

xster mentioned this pull request May 3, 2019

Need Cupertino Translations #13452

Closed

ivk1800 reviewed May 3, 2019

View reviewed changes

Comment thread packages/flutter_localizations/lib/src/l10n/cupertino_ru.arb

ivk1800 reviewed May 3, 2019

View reviewed changes

Comment thread packages/flutter_localizations/lib/src/l10n/cupertino_ru.arb

ivk1800 reviewed May 3, 2019

View reviewed changes

Comment thread packages/flutter_localizations/lib/src/l10n/cupertino_ru.arb

ivk1800 reviewed May 3, 2019

View reviewed changes

Comment thread packages/flutter_localizations/lib/src/l10n/cupertino_ru.arb

lgfranco suggested changes May 3, 2019

View reviewed changes

HansMuller approved these changes May 7, 2019

View reviewed changes

update more translations from TC

875b575

xster force-pushed the push branch from 981eed5 to 875b575 Compare May 7, 2019 20:42

xster merged commit 10922df into flutter:master May 10, 2019

xster deleted the push branch May 10, 2019 06:19

xster added a commit that referenced this pull request May 10, 2019

Revert "Cupertino localization step 12: push translation for all supp…

17161a2

…orted languages (#31644)" This reverts commit 10922df.

xster mentioned this pull request May 10, 2019

Revert "Cupertino localization step 12: push translation for all supported languages" #32470

Merged

xster added a commit that referenced this pull request May 10, 2019

Revert "Cupertino localization step 12: push translation for all supp…

87d9c55

…orted languages (#31644)" (#32470) This reverts commit 10922df.

xster mentioned this pull request May 10, 2019

Cupertino localization step 12 try 2: push translation for all supported languages #32513

Merged

github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021

	"datePickerHourSemanticsLabelOne": "$hour em ponto",
	"datePickerHourSemanticsLabelOne": "$hour hora",

	"timerPickerSecondLabelOne": "s",
	"timerPickerSecondLabelOne": "seg",

	"timerPickerSecondLabelOther": "seg",
	"timerPickerSecondLabelOther": "s",

Conversation

xster commented Apr 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xster commented May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgfranco left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

lgfranco commented May 7, 2019

Uh oh!

xster commented May 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xster commented Apr 26, 2019 •

edited

Loading

xster commented May 1, 2019 •

edited

Loading