Repository navigation
Start abstracting platform logic builds behind a shared interface - #31889
Merged
Merged
Conversation
jonahwilliams
force-pushed
the
platform_build_api
branch
from
May 1, 2019 07:40
32898ca to
0ff6f76
Compare
goderbauer
added
the
tool
zanderso
approved these changes
May 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To move to a world where platform builds are pluggable, we'll need to start defining them in terms of a unified interface. Here, I've added the capability to select a step based on the target platform and build mode, this can almost be done without knowledge of the device.
To follow this up, we'll need to determine what device specific and build specific results are interesting enough. For example, for android we need to know something like the launchActivity. For other platforms we might only need the executable.
Related Issues
#25377